* [PATCH 2/3] common/cnxk: added new API to enable disable SQ
2023-12-05 10:00 [PATCH 1/3] common/cnxk: optimize ethdev teardown time Rakesh Kudurumalla
@ 2023-12-05 10:00 ` Rakesh Kudurumalla
2023-12-05 10:00 ` [PATCH 3/3] net/cnxk: reduce Tx queue release time Rakesh Kudurumalla
1 sibling, 0 replies; 4+ messages in thread
From: Rakesh Kudurumalla @ 2023-12-05 10:00 UTC (permalink / raw)
To: Nithin Dabilpuram, Kiran Kumar K, Sunil Kumar Kori, Satha Rao
Cc: dev, jerinj, Rakesh Kudurumalla
Added a new roc API to disable SQB aura FC
and update SQ state to disabled state in TX queue
stop.The same SQ status is verified during sq flush
to enable or disable SQB aura FC during ethdev
teardown.This fix reduces teardown time by 90%.
Signed-off-by: Rakesh Kudurumalla <rkudurumalla@marvell.com>
---
drivers/common/cnxk/roc_nix.h | 2 ++
drivers/common/cnxk/roc_nix_queue.c | 15 +++++++++++++++
drivers/common/cnxk/roc_nix_tm.c | 20 ++++++++++++--------
drivers/common/cnxk/version.map | 1 +
4 files changed, 30 insertions(+), 8 deletions(-)
diff --git a/drivers/common/cnxk/roc_nix.h b/drivers/common/cnxk/roc_nix.h
index a96cf73757..82997c38ce 100644
--- a/drivers/common/cnxk/roc_nix.h
+++ b/drivers/common/cnxk/roc_nix.h
@@ -401,6 +401,7 @@ struct roc_nix_sq {
void *sqe_mem;
void *fc;
uint8_t tc;
+ bool enable;
};
struct roc_nix_link_info {
@@ -952,6 +953,7 @@ void __roc_api roc_nix_cq_head_tail_get(struct roc_nix *roc_nix, uint16_t qid,
uint32_t *head, uint32_t *tail);
int __roc_api roc_nix_sq_init(struct roc_nix *roc_nix, struct roc_nix_sq *sq);
int __roc_api roc_nix_sq_fini(struct roc_nix_sq *sq);
+int __roc_api roc_nix_sq_ena_dis(struct roc_nix_sq *sq, bool enable);
void __roc_api roc_nix_sq_head_tail_get(struct roc_nix *roc_nix, uint16_t qid,
uint32_t *head, uint32_t *tail);
diff --git a/drivers/common/cnxk/roc_nix_queue.c b/drivers/common/cnxk/roc_nix_queue.c
index f96d5c3a96..ae4e0ea40c 100644
--- a/drivers/common/cnxk/roc_nix_queue.c
+++ b/drivers/common/cnxk/roc_nix_queue.c
@@ -92,6 +92,20 @@ nix_rq_ena_dis(struct dev *dev, struct roc_nix_rq *rq, bool enable)
return rc;
}
+int
+roc_nix_sq_ena_dis(struct roc_nix_sq *sq, bool enable)
+{
+ int rc = 0;
+
+ rc = roc_nix_tm_sq_aura_fc(sq, enable);
+ if (rc)
+ goto done;
+
+ sq->enable = enable;
+done:
+ return rc;
+}
+
int
roc_nix_rq_ena_dis(struct roc_nix_rq *rq, bool enable)
{
@@ -1409,6 +1423,7 @@ roc_nix_sq_init(struct roc_nix *roc_nix, struct roc_nix_sq *sq)
}
mbox_put(mbox);
+ sq->enable = true;
nix->sqs[qid] = sq;
sq->io_addr = nix->base + NIX_LF_OP_SENDX(0);
/* Evenly distribute LMT slot for each sq */
diff --git a/drivers/common/cnxk/roc_nix_tm.c b/drivers/common/cnxk/roc_nix_tm.c
index ece88b5e99..6a61e448a1 100644
--- a/drivers/common/cnxk/roc_nix_tm.c
+++ b/drivers/common/cnxk/roc_nix_tm.c
@@ -887,10 +887,12 @@ nix_tm_sq_flush_pre(struct roc_nix_sq *sq)
if (!sq)
continue;
- rc = roc_nix_tm_sq_aura_fc(sq, false);
- if (rc) {
- plt_err("Failed to disable sqb aura fc, rc=%d", rc);
- goto cleanup;
+ if (sq->enable) {
+ rc = roc_nix_tm_sq_aura_fc(sq, false);
+ if (rc) {
+ plt_err("Failed to disable sqb aura fc, rc=%d", rc);
+ goto cleanup;
+ }
}
/* Wait for sq entries to be flushed */
@@ -997,10 +999,12 @@ nix_tm_sq_flush_post(struct roc_nix_sq *sq)
once = true;
}
- rc = roc_nix_tm_sq_aura_fc(s_sq, true);
- if (rc) {
- plt_err("Failed to enable sqb aura fc, rc=%d", rc);
- return rc;
+ if (s_sq->enable) {
+ rc = roc_nix_tm_sq_aura_fc(s_sq, true);
+ if (rc) {
+ plt_err("Failed to enable sqb aura fc, rc=%d", rc);
+ return rc;
+ }
}
}
diff --git a/drivers/common/cnxk/version.map b/drivers/common/cnxk/version.map
index aa884a8fe2..4907b62013 100644
--- a/drivers/common/cnxk/version.map
+++ b/drivers/common/cnxk/version.map
@@ -339,6 +339,7 @@ INTERNAL {
roc_nix_rx_queue_intr_disable;
roc_nix_rx_queue_intr_enable;
roc_nix_sq_dump;
+ roc_nix_sq_ena_dis;
roc_nix_sq_fini;
roc_nix_sq_head_tail_get;
roc_nix_sq_init;
--
2.25.1
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH 3/3] net/cnxk: reduce Tx queue release time
2023-12-05 10:00 [PATCH 1/3] common/cnxk: optimize ethdev teardown time Rakesh Kudurumalla
2023-12-05 10:00 ` [PATCH 2/3] common/cnxk: added new API to enable disable SQ Rakesh Kudurumalla
@ 2023-12-05 10:00 ` Rakesh Kudurumalla
2023-12-07 6:15 ` Jerin Jacob
1 sibling, 1 reply; 4+ messages in thread
From: Rakesh Kudurumalla @ 2023-12-05 10:00 UTC (permalink / raw)
To: Nithin Dabilpuram, Kiran Kumar K, Sunil Kumar Kori, Satha Rao
Cc: dev, jerinj, Rakesh Kudurumalla
Invoked newly added roc API to disable
SQB aura FC during TX queue start and TX queue
stop. This fix reduces ethdev teardown time
Signed-off-by: Rakesh Kudurumalla <rkudurumalla@marvell.com>
---
drivers/net/cnxk/cnxk_ethdev.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/cnxk/cnxk_ethdev.c b/drivers/net/cnxk/cnxk_ethdev.c
index 5e11bbb017..2372a4e793 100644
--- a/drivers/net/cnxk/cnxk_ethdev.c
+++ b/drivers/net/cnxk/cnxk_ethdev.c
@@ -1521,7 +1521,7 @@ cnxk_nix_tx_queue_start(struct rte_eth_dev *eth_dev, uint16_t qid)
if (data->tx_queue_state[qid] == RTE_ETH_QUEUE_STATE_STARTED)
return 0;
- rc = roc_nix_tm_sq_aura_fc(sq, true);
+ rc = roc_nix_sq_ena_dis(sq, true);
if (rc) {
plt_err("Failed to enable sq aura fc, txq=%u, rc=%d", qid, rc);
goto done;
@@ -1543,7 +1543,7 @@ cnxk_nix_tx_queue_stop(struct rte_eth_dev *eth_dev, uint16_t qid)
if (data->tx_queue_state[qid] == RTE_ETH_QUEUE_STATE_STOPPED)
return 0;
- rc = roc_nix_tm_sq_aura_fc(sq, false);
+ rc = roc_nix_sq_ena_dis(sq, false);
if (rc) {
plt_err("Failed to disable sqb aura fc, txq=%u, rc=%d", qid,
rc);
--
2.25.1
^ permalink raw reply [flat|nested] 4+ messages in thread