From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E7E4EA0526; Wed, 8 Jul 2020 15:31:11 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 333031DB46; Wed, 8 Jul 2020 15:31:11 +0200 (CEST) Received: from mail-io1-f68.google.com (mail-io1-f68.google.com [209.85.166.68]) by dpdk.org (Postfix) with ESMTP id F1C481DB22; Wed, 8 Jul 2020 15:31:08 +0200 (CEST) Received: by mail-io1-f68.google.com with SMTP id i4so46911422iov.11; Wed, 08 Jul 2020 06:31:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=jP+kl/hkaFBHbgRyR7ioofgUOJbjdczcDgxf0M8hXW0=; b=AeuaP2Bd99kM85zx0ba5iWKKhvhoBOel6K0TVoRCfGXiPHrnwyyNexley8nhlyg+cN UndUrckLFLfyRInySSBLtCNv/n1g/+hVeuz+0kJvbAuCyeokc23Mg7b9ksKmVeWGsdF1 jg90XAohrO17O1To8DmAVyEOZjPxhtQj0IQ9MH0/WvcsIbLjAGHnvF4dYRzKQQydHY2x xMtiO6zpYCcdLbBvPzrnbN887foNLOdJSh94yxXFsIv7BwBZ+nM4A2EN9BmSySTsTq8r mWc9Ux3AvUMA50G5jMlAL3W5h6+C9hU9u0lexa/CqAxpFBCvB0azJWrfU29pYYp5glf2 p5oQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=jP+kl/hkaFBHbgRyR7ioofgUOJbjdczcDgxf0M8hXW0=; b=bFfVWblY+Z/KoYGGnAAKQGunsPkECuEJntCqnICyIrA3OX7JxFvv8QnVgzysJL2Kgp aP9fJFsi31v2Tu1rO8grAa7SG4QXw/Djy0MWBTTy5fH5w8R0CQx14VrhEoOIztR2gdAP EPIoLjZpxxz9gBG+1ySYtLUtGl9ozrzLvXKFsPy3k6QAmivpgT8oDqMl4SKN84gjJxaZ +RTsyOqKmVGdVNPyqFnjVC16s9egwHWNoI3aSM8HZn/+05od/dzo6a/pN7i63Ic/tb7U mqVzo8ffyJKW50IXyvpK0vChnQion0QJaDaJ8l9otuBBkRUN4yYLGGN+ea/TcmtUSSUV uS1Q== X-Gm-Message-State: AOAM532GJYdBgylE0Y15+PAqUL0TC4vcWbzKDoMio7dUuqjiIwD6us/B 36tn2xTLcwXBF7DlEZDvseIpARpUtBxlksgyqNc= X-Google-Smtp-Source: ABdhPJz/Iat5HgujdLW3LrH0biKRY7bzsCpPC5j9g3B0I6yzJVBxoVnELfTt9G79wW0bZKJ8y7j4DDO2jazwpdtplDE= X-Received: by 2002:a5e:880f:: with SMTP id l15mr34996693ioj.94.1594215068045; Wed, 08 Jul 2020 06:31:08 -0700 (PDT) MIME-Version: 1.0 References: <1594120403-17643-1-git-send-email-phil.yang@arm.com> <1594137293-22468-1-git-send-email-phil.yang@arm.com> In-Reply-To: <1594137293-22468-1-git-send-email-phil.yang@arm.com> From: Jerin Jacob Date: Wed, 8 Jul 2020 19:00:51 +0530 Message-ID: To: Phil Yang Cc: Jerin Jacob , dpdk-dev , Thomas Monjalon , Erik Gabriel Carrillo , Honnappa Nagarahalli , David Christensen , "Ruifeng Wang (Arm Technology China)" , Dharmik Thakkar , nd , David Marchand , Ray Kinsella , Neil Horman , dodji@redhat.com, dpdk stable Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v4 1/4] eventdev: fix race condition on timer list counter X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Jul 7, 2020 at 9:25 PM Phil Yang wrote: > > The n_poll_lcores counter and poll_lcore array are shared between lcores > and the update of these variables are out of the protection of spinlock > on each lcore timer list. The read-modify-write operations of the counter > are not atomic, so it has the potential of race condition between lcores. > > Use c11 atomics with RELAXED ordering to prevent confliction. > > Fixes: cc7b73ea9e3b ("eventdev: add new software timer adapter") > Cc: erik.g.carrillo@intel.com > Cc: stable@dpdk.org > > Signed-off-by: Phil Yang > Reviewed-by: Dharmik Thakkar > Reviewed-by: Ruifeng Wang > Acked-by: Erik Gabriel Carrillo Hi Thomas, The latest version does not have ABI breakage issue. I have added the ABI verifier in my local patch verification setup. Series applied to dpdk-next-eventdev/master. Please pull this series from dpdk-next-eventdev/master. Thanks. I am marking this patch series as "Awaiting Upstream" in patchwork status to reflect the actual status.