From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 55065A0A0A; Fri, 26 Mar 2021 15:33:43 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 15ADC140EE6; Fri, 26 Mar 2021 15:33:43 +0100 (CET) Received: from mail-io1-f45.google.com (mail-io1-f45.google.com [209.85.166.45]) by mails.dpdk.org (Postfix) with ESMTP id 77C3540685 for ; Fri, 26 Mar 2021 15:33:41 +0100 (CET) Received: by mail-io1-f45.google.com with SMTP id k8so5559993iop.12 for ; Fri, 26 Mar 2021 07:33:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=1/lcDtQrmKO0/oShQ/8Qp983XNQp0yjKsXUtQ9yEmfI=; b=XLlj3lm0HC7VKO59/Qygj3NuXCzySLu1lpNsgreePZrIfS5A82XUuOi99UyeT663DS UjkWpHdH75tR0cPqAurA268AYT9TDn+sOlu8qVDnjpHHcBsE+bn+hj8o5b0QIZGV4kmp GvUGcIQRuPx9AgPROmIlKuSXiA5NAAIINfdhLuKjvWnnvSJNCs7GLUN2k4OfwrRd/84b nFsHjpSX2NsxC2U+nJGD7zwL/QfF4E3W6pRe5bqf1Ff5HbgJ2IP+xBilO/dVVBOwLNM8 5NPjCI0wIpOgPOKfFlcK5lGAziC5xbKKnVxAwIovialDgupx6AToSzaDPe+8oboPFpWK ID9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=1/lcDtQrmKO0/oShQ/8Qp983XNQp0yjKsXUtQ9yEmfI=; b=MUEx7Gl7HejmvAJg143BJOgqsnJWVQOx2VRCmRoWTBoJsKle0zN9FwuMl6XllBl1uA mi/pKQMcK8eZsGp4Qyg9GshojK2YKd/4Km2U0SxuYmzD2qP8n3EIV4TcesnmEOJiGVyb UGqZ4QzRRqP8Oc0+VI5KYDvk+67RdiIUgB1BSIdl1t5zjf4QZhIpaKzPAhLzdxA//2fI ENoSFYoadaHqX42U/OxUDoepdcxHpwC+o4t7NWl78keZY5vcNKzDMaTCMwJEjtxS7pCC qtrD+gQnkQY6BYCzG24+tClwk0YiVkWdkNQfp3U9n9xJoKIA7d/t4bP9yLnqqhKAjSSc 156Q== X-Gm-Message-State: AOAM533kbkOOdf7WBEOz4usFm/QGz5Y+YHFiteABwzGOySDATE0TgOd0 y4obtDCwJRLQqKoopYeYlQP1W0/REQG3o0AvSZM= X-Google-Smtp-Source: ABdhPJy+k2zOJjCAZ4i8YjwoJWWVns0dwgpyHzU3qoPXuoXDTguooAJs1OWOFkRBIWVhR4WarkprT9xR/WokrUAbeLc= X-Received: by 2002:a02:7086:: with SMTP id f128mr12007462jac.104.1616769220273; Fri, 26 Mar 2021 07:33:40 -0700 (PDT) MIME-Version: 1.0 References: <20210316221857.2254-1-timothy.mcdaniel@intel.com> <20210316221857.2254-2-timothy.mcdaniel@intel.com> In-Reply-To: From: Jerin Jacob Date: Fri, 26 Mar 2021 20:03:24 +0530 Message-ID: To: "McDaniel, Timothy" Cc: dpdk-dev , Jerin Jacob , "Van Haaren, Harry" , Ray Kinsella , Neil Horman , "Rao, Nikhil" , "Carrillo, Erik G" , "Gujjar, Abhinandan S" , Pavan Nikhilesh , Hemant Agrawal , "mattias.ronnblom" , "Mccarthy, Peter" Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH 01/25] event/dlb2: add dlb v2.5 probe X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Mar 26, 2021 at 7:33 PM McDaniel, Timothy wrote: > > > > > -----Original Message----- > > From: Jerin Jacob > > Sent: Friday, March 26, 2021 6:01 AM > > To: McDaniel, Timothy > > Cc: dpdk-dev ; Jerin Jacob ; Van Haaren, > > Harry ; Ray Kinsella ; Neil > > Horman ; Rao, Nikhil ; > > Carrillo, Erik G ; Gujjar, Abhinandan S > > ; Pavan Nikhilesh > > ; Hemant Agrawal ; > > mattias.ronnblom ; Mccarthy, Peter > > > > Subject: Re: [dpdk-dev] [PATCH 01/25] event/dlb2: add dlb v2.5 probe > > > > On Thu, Mar 25, 2021 at 1:01 AM McDaniel, Timothy > > wrote: > > > > > > > > > > > > > -----Original Message----- > > > > From: Jerin Jacob > > > > Sent: Sunday, March 21, 2021 4:48 AM > > > > To: McDaniel, Timothy > > > > Cc: dpdk-dev ; Jerin Jacob ; Van > > Haaren, > > > > Harry ; Ray Kinsella ; Neil > > > > Horman ; Rao, Nikhil ; > > > > Carrillo, Erik G ; Gujjar, Abhinandan S > > > > ; Pavan Nikhilesh > > > > ; Hemant Agrawal > > ; > > > > mattias.ronnblom ; Mccarthy, Peter > > > > > > > > Subject: Re: [dpdk-dev] [PATCH 01/25] event/dlb2: add dlb v2.5 probe > > > > > > > > On Wed, Mar 17, 2021 at 3:49 AM Timothy McDaniel > > > > wrote: > > > > > > > > > > This commit adds dlb v2.5 probe support, and updates > > > > > parameter parsing. > > > > > > > > > > The dlb v2.5 device differs from dlb v2, in that the > > > > > number of resources (ports, queues, ...) is different, > > > > > so macros have been added to take the device version > > > > > into account. > > > > > > > > > > This commit also cleans up a few issues in the original > > > > > dlb2 source: > > > > > - eliminate duplicate constant definitions > > > > > - removed unused constant definitions > > > > > > > > > > Signed-off-by: Timothy McDaniel > > > > > --- > > > > > > > > > > > > > > -#define EVDEV_DLB2_NAME_PMD dlb2_event > > > > > +#define EVDEV_DLB2_NAME_PMD dlb_event > > > > > > > > Is this an intended change? why change the driver's name. > > > > > > Yes, This is an intentional change. We will be using the same driver name > > going forward, regardless of the hardware version. > > > Internally, we know which version of the hardware is present. > > > > Since the driver name is still driver/event/dlb2. Keep it as same > > prefix scheme with other drivers. > > > > > > > > > > Thanks, > > > Tim > > > > > Would it be acceptable to rename drivers/event/dlb2 to drivers/event/dlb? > We may have additional dlb devices in the pipeline, such as v3, and we would really like > to have them all use a common name. Makes sense to change to drivers/event/dlb. I think, we can make to dlb when you add v3 support. Now there is no need. >