From: Jerin Jacob <jerinjacobk@gmail.com>
To: pbhagavatula@marvell.com,
"Ruifeng Wang (Arm Technology China)" <ruifeng.wang@arm.com>,
Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>
Cc: jerinj@marvell.com, Shijith Thotton <sthotton@marvell.com>, dev@dpdk.org
Subject: Re: [PATCH] event/cnxk: use WFE LDP loop for getwork routine
Date: Tue, 9 Jan 2024 13:26:57 +0530 [thread overview]
Message-ID: <CALBAE1PuVtw4p8=Wfx3Y8LxfRFRR8k9prRXQqVjnP_VhgjrU1A@mail.gmail.com> (raw)
In-Reply-To: <20240104193633.2264-1-pbhagavatula@marvell.com>
On Fri, Jan 5, 2024 at 9:24 AM <pbhagavatula@marvell.com> wrote:
>
> From: Pavan Nikhilesh <pbhagavatula@marvell.com>
>
> Use WFE LDP loop while polling for GETWORK completion for better
> power savings.
> Disabled by default and can be enabled by setting
> `RTE_ARM_USE_WFE` to `true` in `config/arm/meson.build`
>
> Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
> ---
> doc/guides/eventdevs/cnxk.rst | 9 ++++++
> drivers/event/cnxk/cn10k_worker.h | 52 +++++++++++++++++++++++++------
> 2 files changed, 52 insertions(+), 9 deletions(-)
>
> diff --git a/doc/guides/eventdevs/cnxk.rst b/doc/guides/eventdevs/cnxk.rst
> index cccb8a0304..d62c143c77 100644
> --- a/doc/guides/eventdevs/cnxk.rst
> +++ b/doc/guides/eventdevs/cnxk.rst
> @@ -198,6 +198,15 @@ Runtime Config Options
>
> -a 0002:0e:00.0,tim_eclk_freq=122880000-1000000000-0
>
> +Power Savings on CN10K
> +----------------------
> +
> +ARM cores can additionally use WFE when polling for transactions on SSO bus
> +to save power i.e., in the event dequeue call ARM core can enter WFE and exit
> +when either work has been scheduled or dequeue timeout has reached.
> +This can be enabled by setting ``RTE_ARM_USE_WFE`` to ``true`` in
> +``config/arm/meson.build``.
+ ARM maintainers
IMO, Updating config/arm/meson.build for enabling RTE_ARM_USE_WFE,
needs to improved.
Could you push a patch for enabling via -D... or via -Dc_args=...
next prev parent reply other threads:[~2024-01-09 7:57 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-04 19:36 pbhagavatula
2024-01-09 7:56 ` Jerin Jacob [this message]
2024-01-17 14:25 ` [PATCH v2 1/2] config/arm: allow WFE to be enabled config time pbhagavatula
2024-01-17 14:26 ` [PATCH v2 2/2] event/cnxk: use WFE LDP loop for getwork routine pbhagavatula
2024-01-18 1:52 ` [PATCH v2 1/2] config/arm: allow WFE to be enabled config time Ruifeng Wang
2024-01-21 15:21 ` [PATCH v3 " pbhagavatula
2024-01-21 15:21 ` [PATCH v3 2/2] event/cnxk: use WFE LDP loop for getwork routine pbhagavatula
2024-01-22 6:37 ` [PATCH v3 1/2] config/arm: allow WFE to be enabled config time fengchengwen
2024-01-22 6:43 ` Ruifeng Wang
2024-02-01 16:37 ` Jerin Jacob
2024-02-01 22:03 ` [PATCH v4] event/cnxk: use WFE LDP loop for getwork routine pbhagavatula
2024-02-25 15:20 ` Jerin Jacob
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALBAE1PuVtw4p8=Wfx3Y8LxfRFRR8k9prRXQqVjnP_VhgjrU1A@mail.gmail.com' \
--to=jerinjacobk@gmail.com \
--cc=Honnappa.Nagarahalli@arm.com \
--cc=dev@dpdk.org \
--cc=jerinj@marvell.com \
--cc=pbhagavatula@marvell.com \
--cc=ruifeng.wang@arm.com \
--cc=sthotton@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).