From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 281864386F; Tue, 9 Jan 2024 08:57:25 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 12A6C40261; Tue, 9 Jan 2024 08:57:25 +0100 (CET) Received: from mail-qk1-f174.google.com (mail-qk1-f174.google.com [209.85.222.174]) by mails.dpdk.org (Postfix) with ESMTP id B128D4021F for ; Tue, 9 Jan 2024 08:57:23 +0100 (CET) Received: by mail-qk1-f174.google.com with SMTP id af79cd13be357-783293278adso83984585a.3 for ; Mon, 08 Jan 2024 23:57:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1704787043; x=1705391843; darn=dpdk.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=MEMtbSo3cB4fxycDIdtIu873LAKnOHKHxRIqcF36Vbc=; b=HvA3cvEFVMdaAHifEQcBRWzFGBuQThFLkbfUUrn3tgJJxJOOe5hBvayjs/v3hXwSzo JD+lWqFjw+NPn+kbGJx66NPPZ90CqU5xcxYwOdRnFMf6I0ZBUIdp5IkYSJITlB6qZxKi m+/qIDlTBpNdJqj1jgUitNHUaiIDY7G2hdjVwxoi5jKKmCrzkjBXDT2EXZEgxvPdbgJ+ riKlmNhd/OTU/JuD+fJs2QpKgiQuzQAaI2u3PEUttpF3drcNmYI8vkeGZ8ygri4Zb8xg ww7PrfNXDSwSweoJfYNj9C6wNSr2zaa3VDWgsOzxLQq+jsWMy/aa3EAouB4nOc5e2T1S dMsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704787043; x=1705391843; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=MEMtbSo3cB4fxycDIdtIu873LAKnOHKHxRIqcF36Vbc=; b=FnF5GUimv+yg96v3qA+HxF0+xUBgIrE06DQGt2fMdyh+kFNQG8pRpUyCzsVCDbPfQ2 S/yNNco15+nBvsg6s9JxTYQ5PafGZsgrAZhu1BiDe+tWX0rcy8HzoKJra5aNsXO+jQzG iv6jbWDyTwGvthZYjw/QxbxS2OIUJfdgkE/aDksSCVBSCXll/sznvAb62NQ18jlUqCsj k++yQMekMpui1KWUIElAB7PrQvvwlwVH+eL6TytJCRYfzhgRNx3xlBYcZDML7iPEcvOa 9T7ijSilI5JsQc30y5x3JKe1XHVCjf/bIdH+gIIQqyaq6c+XIDJ+YbT9VYzw5oMTbyZD G4oA== X-Gm-Message-State: AOJu0YzQZn3Ege/vlQwsTSfaDYf1b1RB165vUbjj6udyFSWFYUFeGSbi nxKsqahjpWytbt2ZU6Arv2A3gvJ+IhuKEAMhkRM= X-Google-Smtp-Source: AGHT+IHOrYofSOMN6dHffXtvyML5Ka60F9EQWkLXW6EM8Xr3lGHSULIUrqQD2CVB6ETI6NyWrPrkHrOJ+AbxbaxTEa8= X-Received: by 2002:a05:622a:38d:b0:425:85b7:a784 with SMTP id j13-20020a05622a038d00b0042585b7a784mr6508519qtx.53.1704787042938; Mon, 08 Jan 2024 23:57:22 -0800 (PST) MIME-Version: 1.0 References: <20240104193633.2264-1-pbhagavatula@marvell.com> In-Reply-To: <20240104193633.2264-1-pbhagavatula@marvell.com> From: Jerin Jacob Date: Tue, 9 Jan 2024 13:26:57 +0530 Message-ID: Subject: Re: [PATCH] event/cnxk: use WFE LDP loop for getwork routine To: pbhagavatula@marvell.com, "Ruifeng Wang (Arm Technology China)" , Honnappa Nagarahalli Cc: jerinj@marvell.com, Shijith Thotton , dev@dpdk.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Jan 5, 2024 at 9:24=E2=80=AFAM wrote: > > From: Pavan Nikhilesh > > Use WFE LDP loop while polling for GETWORK completion for better > power savings. > Disabled by default and can be enabled by setting > `RTE_ARM_USE_WFE` to `true` in `config/arm/meson.build` > > Signed-off-by: Pavan Nikhilesh > --- > doc/guides/eventdevs/cnxk.rst | 9 ++++++ > drivers/event/cnxk/cn10k_worker.h | 52 +++++++++++++++++++++++++------ > 2 files changed, 52 insertions(+), 9 deletions(-) > > diff --git a/doc/guides/eventdevs/cnxk.rst b/doc/guides/eventdevs/cnxk.rs= t > index cccb8a0304..d62c143c77 100644 > --- a/doc/guides/eventdevs/cnxk.rst > +++ b/doc/guides/eventdevs/cnxk.rst > @@ -198,6 +198,15 @@ Runtime Config Options > > -a 0002:0e:00.0,tim_eclk_freq=3D122880000-1000000000-0 > > +Power Savings on CN10K > +---------------------- > + > +ARM cores can additionally use WFE when polling for transactions on SSO = bus > +to save power i.e., in the event dequeue call ARM core can enter WFE and= exit > +when either work has been scheduled or dequeue timeout has reached. > +This can be enabled by setting ``RTE_ARM_USE_WFE`` to ``true`` in > +``config/arm/meson.build``. + ARM maintainers IMO, Updating config/arm/meson.build for enabling RTE_ARM_USE_WFE, needs to improved. Could you push a patch for enabling via -D... or via -Dc_args=3D...