DPDK patches and discussions
 help / color / mirror / Atom feed
From: Jerin Jacob <jerinjacobk@gmail.com>
To: Maxime Coquelin <maxime.coquelin@redhat.com>
Cc: David Marchand <david.marchand@redhat.com>,
	Thomas Monjalon <thomas@monjalon.net>,
	 Jerin Jacob <jerinj@marvell.com>, dpdk-dev <dev@dpdk.org>,
	Zhihong Wang <zhihong.wang@intel.com>,
	 "Ye, Xiaolong" <xiaolong.ye@intel.com>,
	Harman Kalra <hkalra@marvell.com>,
	 Kevin Traynor <ktraynor@redhat.com>,
	Luca Boccassi <bluca@debian.org>, Gaetan Rivet <grive@u256.net>
Subject: Re: [dpdk-dev] [PATCH] bus/pci: optimize pci device probe
Date: Wed, 6 May 2020 12:13:16 +0530	[thread overview]
Message-ID: <CALBAE1PvC-9bLG3aXf1VyBzuSO94n+efSptRS1NuE4qxiwhZFQ@mail.gmail.com> (raw)
In-Reply-To: <9115e497-8c08-a0dc-51c1-1eea358d49b5@redhat.com>

On Wed, May 6, 2020 at 12:05 PM Maxime Coquelin
<maxime.coquelin@redhat.com> wrote:
>
> Hi,
>
> On 5/5/20 6:16 PM, David Marchand wrote:
> > On Tue, May 5, 2020 at 5:50 PM Jerin Jacob <jerinjacobk@gmail.com> wrote:
> >>>>
> >>>> Removing this special case could break x86 applications running with
> >>>> legacy virtio.
> >>>>
> >>>>
> >>>> On the plus side, we have been announcing for some time in virtio:
> >>>> RTE_PMD_REGISTER_KMOD_DEP(net_virtio, "* igb_uio | uio_pci_generic | vfio-pci");
> >>>
> >>> What is to conclude?
> >>> # The In-tree virtio driver uses ""* igb_uio | uio_pci_generic |
> >>> vfio-pci"" driver as backend and it does not need RTE_KDRV_NONE?
> >>> OR
> >>> # The in-tree, legacy virtio(const struct virtio_pci_ops legacy_op)
> >>> can work without any kernel driver in the backend. So RTE_KDRV_NONE
> >>> need?
> >>
> >> Ping. What is the conclusion? If it is former then this patch is valid.
> >
> > I am fine with dropping the legacy part, but I wanted to hear from
> > Maxime at least.
> >
> >
>
> IIUC, it means that with Jerin patch, Virtio Legacy devices support will
> be dropped as they won't be probed anymore?

The device drivers with RTE_KDRV_NONE as the backend will not be probed.
1) Are Virtio Legacy devices are type of RTE_KDRV_NONE?
2) if yes, Would you like to support for virtio legacy device?
3) if yes, Please fix RTE_PMD_REGISTER_KMOD_DEP(net_virtio, "* igb_uio
| uio_pci_generic | vfio-pci");




>
> Maxime
>

  reply	other threads:[~2020-05-06  6:43 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-26 17:38 jerinj
2020-04-26 18:08 ` Thomas Monjalon
2020-04-26 18:41   ` Jerin Jacob
2020-04-26 20:06     ` Thomas Monjalon
2020-04-27 17:59       ` Jerin Jacob
2020-04-28  8:50       ` David Marchand
2020-04-28  9:34         ` Jerin Jacob
2020-05-05 15:50           ` Jerin Jacob
2020-05-05 16:16             ` David Marchand
2020-05-06  6:34               ` Maxime Coquelin
2020-05-06  6:43                 ` Jerin Jacob [this message]
2020-05-06  7:52                   ` Maxime Coquelin
2020-05-06 10:51                     ` Jerin Jacob
2020-05-06 11:37                       ` David Marchand
2020-05-06 11:44                         ` Maxime Coquelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CALBAE1PvC-9bLG3aXf1VyBzuSO94n+efSptRS1NuE4qxiwhZFQ@mail.gmail.com \
    --to=jerinjacobk@gmail.com \
    --cc=bluca@debian.org \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=grive@u256.net \
    --cc=hkalra@marvell.com \
    --cc=jerinj@marvell.com \
    --cc=ktraynor@redhat.com \
    --cc=maxime.coquelin@redhat.com \
    --cc=thomas@monjalon.net \
    --cc=xiaolong.ye@intel.com \
    --cc=zhihong.wang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).