From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4BB52A0350; Wed, 6 May 2020 08:43:35 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id EE1CA1D6FF; Wed, 6 May 2020 08:43:34 +0200 (CEST) Received: from mail-il1-f194.google.com (mail-il1-f194.google.com [209.85.166.194]) by dpdk.org (Postfix) with ESMTP id 9DDE01D6FD for ; Wed, 6 May 2020 08:43:32 +0200 (CEST) Received: by mail-il1-f194.google.com with SMTP id c18so726569ile.5 for ; Tue, 05 May 2020 23:43:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=jBi14jgfI9B+qOcsDrqaaWNkQ/V4aW+QR75K9CaxpPQ=; b=R06iFomYfYK9HTkNDylmgDJlZyRI5+P+1ohSAc/EZ+OeYdowmZPbWxcKNoB9g1fEOl h2Vcov58oEq6zDADdH+DL+dgLcSxj3f5TaSu9NHIOGUJfUSb7lyHUv7JDQcWf5+H/edn hsKTrIT79PwLiNbvXdoZWt7RuveqbEw/te09t1mev1+AyUnxuqqiXIqlp1ZBDNocHt43 ANriUGDvc2QpK/JKBJ43zRBcPOlzznpPPRK3HxBT3BDNa4pLBAOLM2nSM26a0LghnZN1 wsdA1LhZVfQ6URkoVUNtzMkS8AaZDBUyZcr5smAjHdKrcogP8EkOBZT0sdDAutCjH8Y8 djmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=jBi14jgfI9B+qOcsDrqaaWNkQ/V4aW+QR75K9CaxpPQ=; b=RE4oDhXDhNip5+wTFqxbSSJPDwvk5CrfiITsjD/WFzekN7BijpHs9n8eBSdLdcw/fL niM5/SDf9prZCJXgHiNVhWV1+ASRbnLbfBi8AikMtATdthcsYEbqec+gze5/mpZ9iR07 EzI01eLPaElaU9S2a4sN2R6MNlnxKuUg+Y1WvNfMXQdNz7ZYQg2HAC6FfVEFgj2cSxkT ETAtFQFW+kL9ZwhnPUjkB7KzzkJNqJGD3E940GUSVGuVp0PquWCDbvTzbAfkkL2ZW43a nS/DU14AgTDlzMhS4ZO+r38PujtcZYk4p400+6y6CxEkrpFtqmXe4KuCIgkoBR6sHZLo B31w== X-Gm-Message-State: AGi0PuZxMLmbmgiCjMuBdPUJf+lsfwmkIWl/w+Boaxu0/TYJq4yXIGd+ SF3MBtBGBbc3HppFz7sEu3HC6xj0Lm+hAqjWdN4= X-Google-Smtp-Source: APiQypKdO4CBFslEzi0nvIZ3N336NYre46LawbyoSjL2VzOAHoo1tooQJGBrtTviF6n3LF+CDV5RH/Zk5APy3kAajLg= X-Received: by 2002:a05:6e02:790:: with SMTP id q16mr7028269ils.60.1588747411959; Tue, 05 May 2020 23:43:31 -0700 (PDT) MIME-Version: 1.0 References: <20200426173811.49788-1-jerinj@marvell.com> <3102527.CAdn2TfLgq@thomas> <6277521.uz5P2jW1tq@thomas> <9115e497-8c08-a0dc-51c1-1eea358d49b5@redhat.com> In-Reply-To: <9115e497-8c08-a0dc-51c1-1eea358d49b5@redhat.com> From: Jerin Jacob Date: Wed, 6 May 2020 12:13:16 +0530 Message-ID: To: Maxime Coquelin Cc: David Marchand , Thomas Monjalon , Jerin Jacob , dpdk-dev , Zhihong Wang , "Ye, Xiaolong" , Harman Kalra , Kevin Traynor , Luca Boccassi , Gaetan Rivet Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] bus/pci: optimize pci device probe X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, May 6, 2020 at 12:05 PM Maxime Coquelin wrote: > > Hi, > > On 5/5/20 6:16 PM, David Marchand wrote: > > On Tue, May 5, 2020 at 5:50 PM Jerin Jacob wrote: > >>>> > >>>> Removing this special case could break x86 applications running with > >>>> legacy virtio. > >>>> > >>>> > >>>> On the plus side, we have been announcing for some time in virtio: > >>>> RTE_PMD_REGISTER_KMOD_DEP(net_virtio, "* igb_uio | uio_pci_generic | vfio-pci"); > >>> > >>> What is to conclude? > >>> # The In-tree virtio driver uses ""* igb_uio | uio_pci_generic | > >>> vfio-pci"" driver as backend and it does not need RTE_KDRV_NONE? > >>> OR > >>> # The in-tree, legacy virtio(const struct virtio_pci_ops legacy_op) > >>> can work without any kernel driver in the backend. So RTE_KDRV_NONE > >>> need? > >> > >> Ping. What is the conclusion? If it is former then this patch is valid. > > > > I am fine with dropping the legacy part, but I wanted to hear from > > Maxime at least. > > > > > > IIUC, it means that with Jerin patch, Virtio Legacy devices support will > be dropped as they won't be probed anymore? The device drivers with RTE_KDRV_NONE as the backend will not be probed. 1) Are Virtio Legacy devices are type of RTE_KDRV_NONE? 2) if yes, Would you like to support for virtio legacy device? 3) if yes, Please fix RTE_PMD_REGISTER_KMOD_DEP(net_virtio, "* igb_uio | uio_pci_generic | vfio-pci"); > > Maxime >