From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id DCD12A0577; Mon, 6 Apr 2020 15:39:02 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 588442B96; Mon, 6 Apr 2020 15:39:02 +0200 (CEST) Received: from mail-io1-f66.google.com (mail-io1-f66.google.com [209.85.166.66]) by dpdk.org (Postfix) with ESMTP id 6E7612B83 for ; Mon, 6 Apr 2020 15:39:01 +0200 (CEST) Received: by mail-io1-f66.google.com with SMTP id c16so15758935iod.6 for ; Mon, 06 Apr 2020 06:39:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=5J+ABHQ84XrAlOR8eWYUFA3BYNe2IBrqQWBMEne2wrU=; b=ZQOopE4+yqCsL2o0lM90yfy8aH8gD2Wqf7fygHHyoyWozer5t9SuA3l1e3x+UkSiZX NBF0xdxH64tjjeSxVmQgGVjBcvP2W+v5Vjulfi6el6BrJzQoFeNBfFGNc5cL5B746TXa 2+UQx5QCsCa9LNfdJA3QCjaiThAllZ7uHnCLhoQ7BOKBw6/UzeG9i83a97sLBlXH3V/j 6gh68FbKYK8hSkldbWROZyNOowUqhAV1Uv/rB30rNnSaFhDVeW48d4gIaDiYd6P3GXTE NK/J1K1NG1jkCBHcP8DR+tDNwkAg3oi7l+18uFjSIbz/nk0FcOcCjXmVGvExkexh1bct dSuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=5J+ABHQ84XrAlOR8eWYUFA3BYNe2IBrqQWBMEne2wrU=; b=aWku3m8VWeMWyULbXJW7qwbOx56Ki/RVM2DpRfn8Km2wpVqw3/VXbJZmGn1up3Lkwa CPpX6bLN+t+1ph9Z/0WaTopUye8i0ZGN5SyhkKtnrEgVv62yKXzSsGvZM2FI1npvyZX6 9uz/m4em9wXGfRVkgZreNQ/vsZ3u1csrNjpgYjlL0GfofXFcfqNty6GzlGu0J4Ai40Zm TMrAwt5jMYGevVhXlPmDwpDwHo8XMTuF383i1wKpa0lXiy35VbHXYjP24cusUeCe4FGw 0XdMlT6KC8OsOlIkfjkUKrkOWkdiTKDADnZbvRoP29d+2lQYUOCXTP2dAcJH/1nv7+UC IUAg== X-Gm-Message-State: AGi0PubNFFjY9s/n6JE4sHi67oFblDWeMSOwTmF7LzvQqxKT7pZHCvtX UeHG7GWQVdkWpksjcuvuMZ7NrEWOf83gnTBUcnA= X-Google-Smtp-Source: APiQypKOWnfMDu1ENYIRaBicBFFvNqbEIoxhCQV48oHvgz0/FyLKwCg7IO1sWRMiK+eJq2aQ5AJRO9neNohf16jKJUo= X-Received: by 2002:a05:6602:2f87:: with SMTP id u7mr7981950iow.94.1586180340713; Mon, 06 Apr 2020 06:39:00 -0700 (PDT) MIME-Version: 1.0 References: <1585464438-111285-1-git-send-email-orika@mellanox.com> <2061995.157zFVKu8G@xps> In-Reply-To: <2061995.157zFVKu8G@xps> From: Jerin Jacob Date: Mon, 6 Apr 2020 19:08:44 +0530 Message-ID: To: Thomas Monjalon Cc: Ori Kam , Jerin Jacob Kollanukkaran , "xiang.w.wang@intel.com" , Pavan Nikhilesh Bhagavatula , "dev@dpdk.org" , Shahaf Shuler , "hemant.agrawal@nxp.com" , Opher Reviv , Alex Rosenbaum , Dovrat Zifroni , Prasun Kapoor , "nipun.gupta@nxp.com" , "bruce.richardson@intel.com" , "yang.a.hong@intel.com" , "harry.chang@intel.com" , "gu.jian1@zte.com.cn" , "shanjiangh@chinatelecom.cn" , "zhangy.yun@chinatelecom.cn" , "lixingfu@huachentel.com" , "wushuai@inspur.com" , "yuyingxia@yxlink.com" , "fanchenggang@sunyainfo.com" , "davidfgao@tencent.com" , "liuzhong1@chinaunicom.cn" , "zhaoyong11@huawei.com" , "oc@yunify.com" , "jim@netgate.com" , "hongjun.ni@intel.com" , "j.bromhead@titan-ic.com" , "deri@ntop.org" , "fc@napatech.com" , "arthur.su@lionic.com" , Parav Pandit Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [EXT] [PATCH v1 3/4] regexdev: add regexdev core functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Apr 6, 2020 at 7:00 PM Thomas Monjalon wrote: > > 06/04/2020 14:48, Pavan Nikhilesh Bhagavatula: > > > From: Pavan Nikhilesh Bhagavatula > > >> >> From: Pavan Nikhilesh Bhagavatula > > >> >> > > >> >> Looks like this implementation is incomplete? > > >> >> I don't see any pmd specific helper functions for @see > > >> >rte_cryptodev_pmd.c, > > >> >> rte_eventdev_pmd* > > >> >> > > >> >I think the current implementation includes all needed functions, > > >> >at least for the first stage. > > >> >You can find in rte_regexdev_driver.h the functions that should be > > >> >called > > >> >by the PMD. We have the register / unregister which acts the same > > >as > > >> >create > > >> >and destroy. For parsing argument the PMD may call > > >rte_kvargs_parse. > > >> > > > >> > > >> _driver.h should atleast include > > >> rte_regex_dev_pci_generic_probe/rte_regex_pmd_vdev_init > > >> else there would be a lot of code repetition and possibly udefined > > >behavior > > >> at the driver layer. > > >> > > >Why should they be included? At least in this stage, there is no code to > > >share > > >ethdev why should we add code for the vdev? > > > > Ok I think I failed to communicate my concerns across. > > Let me retry > > > > 1. SW based regex devices such as PCRE/Hyperscan rely on vdev framework > > i.e. user needs to pass an EAL argument --vdev="regex_pcre" for the driver to > > initialize all the other EAL subsystems (ethdev, eventdev, cryptodev, etc..)support this. > > vdev helpers do not have to be part of the first patches which define API. > It should be added when adding the first vdev driver. Yes. When we add vdev, we should not rewrite again to support vdev. So care must taken for proper implementation in the first place avoid rework. If it abstracts it properly adding vdev and PCI is a simple change. See lib/librte_eventdev/rte_eventdev_pmd_vdev.h lib/librte_eventdev/rte_eventdev_pmd_pci.h I think, the common code should take from other matured subsystem instead if writing from scratch, > > > 2. HW based independent regex devices that are exposed as PCI devices would need > > pci probe helpers. > > Same, PCI helpers can be added while adding the first PCI driver. > > We can synchronize about how to split the work, avoiding two developers > doing the same thing. But let's not mandate this work to be done > as part of this first series. > > >