From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6B0C6A034F; Wed, 28 Jul 2021 11:30:59 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D839540E64; Wed, 28 Jul 2021 11:30:58 +0200 (CEST) Received: from mail-il1-f169.google.com (mail-il1-f169.google.com [209.85.166.169]) by mails.dpdk.org (Postfix) with ESMTP id 3E4D840142 for ; Wed, 28 Jul 2021 11:30:57 +0200 (CEST) Received: by mail-il1-f169.google.com with SMTP id r5so2001949ilc.13 for ; Wed, 28 Jul 2021 02:30:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=phzvDU+KVQXCaVvwrCQDBYcVGthsWAn8JtcB6/h7g3c=; b=O7QvU3rOY29mdqdczxUKbJ32wbnscIJwSvr2/EXbz914pM/NnPBos8Gh3MBJEidk+y rUg8I6ynWj5u3oSqa2vw65EQjcUxtVZ93BMuqLxslaRqx2aUWpk/UWXS8uWF7Avy9L8L 0CBEb2mmzLek4qjLKR5a3ih07af2J9jpcSzYWz60JXTjYpLYWYCnqw37/2SRFU7af15b vcuwg2RTLLCstFwRxwiAwIyALS+jWZLiYX2gdiFL9fbPQ+zwzUhjy96qgLatlBR5WV37 0jrpozvgzRlthaqKVkwejYdYM86jji6aIBEBD92I7vFW2nbCcypICG6mDRbh+c9DIl/7 i3Fw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=phzvDU+KVQXCaVvwrCQDBYcVGthsWAn8JtcB6/h7g3c=; b=U8mDVg8objb8tJ/rCso556X2vq8AHZvbDNc3C+hCbu7mhsX2ScIbOpQ0XL71rHZVzb 7YUW93h4BF0aZfAcw+uQsdbQsE1EdZzjuoYqKevHSu0SeTlqHgM3+zaCc1XNXY6H61j7 jqkxlZz7gYkxfM9JNgTvxdoajc0ymefA8kJgbkmSd7Rxo2V3+Es1jIquFz2ScwZRqT0t hDiwNGURmqaUBBBkjbDai6Uf9Ey0Jv8XG3gQUY4mMCVqu4+tgRjqlNDe1o3PciQ9aoAn 2RmXn3VGniALoxM/IvHVRPmmKRLg2Sh8j3ZKeuB9ZhcBPLm8vBHosjDAzzLBNN8mN4T2 v1/g== X-Gm-Message-State: AOAM531IV62dnHqowW60hikyoRm0hvkhkGDSsavMH+bsCTjz9TegUOyX 1Mn96/d2P8238bp68r3AGpZ00A6/JP3av9W5FdE= X-Google-Smtp-Source: ABdhPJx5qBL2b/iLBZXtG8y42VAVxaQJBUF4tU6cLGjFU7fyYHJCxE5zas+j7SHSeo+G2BrdefM3RdYVJVI61wu/Vys= X-Received: by 2002:a92:c5c5:: with SMTP id s5mr18894851ilt.271.1627464656522; Wed, 28 Jul 2021 02:30:56 -0700 (PDT) MIME-Version: 1.0 References: <20210723081222.4176279-1-s.v.naga.harish.k@intel.com> <20210724141036.915356-1-s.v.naga.harish.k@intel.com> In-Reply-To: From: Jerin Jacob Date: Wed, 28 Jul 2021 15:00:30 +0530 Message-ID: To: "Jayatheerthan, Jay" Cc: "Naga Harish K, S V" , "dev@dpdk.org" Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v2] eventdev: fix event port setup in tx adapter X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Jul 28, 2021 at 12:14 PM Jayatheerthan, Jay wrote: > > > -----Original Message----- > > From: Naga Harish K, S V > > Sent: Saturday, July 24, 2021 7:41 PM > > To: Jayatheerthan, Jay ; jerinjacobk@gmail.com > > Cc: dev@dpdk.org > > Subject: [PATCH v2] eventdev: fix event port setup in tx adapter > > > > The event port config set by application in > > rte_event_eth_tx_adapter_create API is modified in > > default configuration callback function. This patch removes > > this hardcode to use application provided event port > > config value. > > > > Fixes: ("eventdev: fix event port config override in tx adapter") > > @Jerin, does this look good to you ? Yes. I will merge this. See below. > > > > > Signed-off-by: Naga Harish K, S V @Naga Harish K, S V Can we remove "," from the Signoff name. Some suggestions for consideration in preferred order. Let me know your preferred Signoff name, I will change it accordingly. Naga Harish or Naga Harish K or Naga Harish K S V > > --- > > lib/eventdev/rte_event_eth_tx_adapter.c | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/lib/eventdev/rte_event_eth_tx_adapter.c b/lib/eventdev/rte_event_eth_tx_adapter.c > > index db260bfb68..18c0359db7 100644 > > --- a/lib/eventdev/rte_event_eth_tx_adapter.c > > +++ b/lib/eventdev/rte_event_eth_tx_adapter.c > > @@ -286,7 +286,6 @@ txa_service_conf_cb(uint8_t __rte_unused id, uint8_t dev_id, > > return ret; > > } > > > > - pc->event_port_cfg = 0; > > ret = rte_event_port_setup(dev_id, port_id, pc); > > if (ret) { > > RTE_EDEV_LOG_ERR("failed to setup event port %u\n", > > -- > > 2.25.1