DPDK patches and discussions
 help / color / mirror / Atom feed
* [PATCH] net/cnxk: fix uninitialized local variable
@ 2022-02-12 12:41 Gowrishankar Muthukrishnan
  2022-02-18  4:56 ` Jerin Jacob
  0 siblings, 1 reply; 2+ messages in thread
From: Gowrishankar Muthukrishnan @ 2022-02-12 12:41 UTC (permalink / raw)
  To: dev
  Cc: Nithin Dabilpuram, Kiran Kumar K, Sunil Kumar Kori, Satha Rao,
	jerinj, Gowrishankar Muthukrishnan

Fix uninitialized local variable as reported by coverity scan.

Fixes: 6af19a9d89b ("net/cnxk: support meter action to flow destroy")
Coverity issue: 373630

Signed-off-by: Gowrishankar Muthukrishnan <gmuthukrishn@marvell.com>
---
 drivers/net/cnxk/cnxk_ethdev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/cnxk/cnxk_ethdev.c b/drivers/net/cnxk/cnxk_ethdev.c
index 945600cdaf..62ffb65cc2 100644
--- a/drivers/net/cnxk/cnxk_ethdev.c
+++ b/drivers/net/cnxk/cnxk_ethdev.c
@@ -177,7 +177,7 @@ nix_meter_fini(struct cnxk_eth_dev *dev)
 	struct roc_nix *nix = &dev->nix;
 	struct roc_nix_rq *rq;
 	uint32_t i;
-	int rc;
+	int rc = 0;
 
 	RTE_TAILQ_FOREACH_SAFE(mtr, fms, next, next_mtr) {
 		for (i = 0; i < mtr->rq_num; i++) {
-- 
2.25.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] net/cnxk: fix uninitialized local variable
  2022-02-12 12:41 [PATCH] net/cnxk: fix uninitialized local variable Gowrishankar Muthukrishnan
@ 2022-02-18  4:56 ` Jerin Jacob
  0 siblings, 0 replies; 2+ messages in thread
From: Jerin Jacob @ 2022-02-18  4:56 UTC (permalink / raw)
  To: Gowrishankar Muthukrishnan, Ferruh Yigit
  Cc: dpdk-dev, Nithin Dabilpuram, Kiran Kumar K, Sunil Kumar Kori,
	Satha Rao, Jerin Jacob

On Sat, Feb 12, 2022 at 6:11 PM Gowrishankar Muthukrishnan
<gmuthukrishn@marvell.com> wrote:
>
> Fix uninitialized local variable as reported by coverity scan.
>
> Fixes: 6af19a9d89b ("net/cnxk: support meter action to flow destroy")
> Coverity issue: 373630
>
> Signed-off-by: Gowrishankar Muthukrishnan <gmuthukrishn@marvell.com>



Acked-by: Jerin Jacob <jerinj@marvell.com>
Applied to dpdk-next-net-mrvl/for-next-net. Thanks

> ---
>  drivers/net/cnxk/cnxk_ethdev.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/cnxk/cnxk_ethdev.c b/drivers/net/cnxk/cnxk_ethdev.c
> index 945600cdaf..62ffb65cc2 100644
> --- a/drivers/net/cnxk/cnxk_ethdev.c
> +++ b/drivers/net/cnxk/cnxk_ethdev.c
> @@ -177,7 +177,7 @@ nix_meter_fini(struct cnxk_eth_dev *dev)
>         struct roc_nix *nix = &dev->nix;
>         struct roc_nix_rq *rq;
>         uint32_t i;
> -       int rc;
> +       int rc = 0;
>
>         RTE_TAILQ_FOREACH_SAFE(mtr, fms, next, next_mtr) {
>                 for (i = 0; i < mtr->rq_num; i++) {
> --
> 2.25.1
>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-02-18  4:56 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-12 12:41 [PATCH] net/cnxk: fix uninitialized local variable Gowrishankar Muthukrishnan
2022-02-18  4:56 ` Jerin Jacob

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).