From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 87187A0032; Fri, 18 Feb 2022 05:56:51 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2CFDF40150; Fri, 18 Feb 2022 05:56:51 +0100 (CET) Received: from mail-il1-f174.google.com (mail-il1-f174.google.com [209.85.166.174]) by mails.dpdk.org (Postfix) with ESMTP id 1578E40140 for ; Fri, 18 Feb 2022 05:56:50 +0100 (CET) Received: by mail-il1-f174.google.com with SMTP id f13so3833742ilq.5 for ; Thu, 17 Feb 2022 20:56:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=dL9zJS/iCSNn8B9ZvqWMkfw0MHYpc8Ci3OV/XG9S1vQ=; b=pZC46My9GPrMtTN3HeYexYz7/xZFv4080hkeASG4+XllzGtPmEChls12UpiXZrqUbA V/CTXtMJ4snIwTL7hfQDSH7aZJlA9ZBEWVCx9hPuWRbZ4wsSfEuroEG1kUUeY/CVK95y v749/pO6ZM7a8gLR/wmuZCUsSyc7OBcSUofLTYt/Qo0k4s22DLr4r5mgndoeDG2nO6ye 27ReNH0IG5sBl2p5qZUIGuRz57Jeh1JvIzEPuElqPM9N1Fij3Swi4cT5KdqfgbExTB1V dOWQS65IDAlw9R5JcQBRmvBhrMdDywIyEtflwDPP+brlSRRrp2ppm//d0quxeQ28UIQE EcMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=dL9zJS/iCSNn8B9ZvqWMkfw0MHYpc8Ci3OV/XG9S1vQ=; b=G+FBJuVqYYA6XQuIn9kMmJ+0wJUpKVMxacjU/qWZy1ECPxGyGp1SXdqGB7e+yVmvxP RE1yEJLaTGzZ4CK3LwAyrf6r0tR9/p9cuVzgJ5RLSS+debHLm1YTHR9G6qtYV//SCNOQ AuV3q+IutvWw/tUECdv5zHyxQveQTGQriAa9Mr+jsst7NaA54DBIvru47oIoHMSJbBtg kO8reS1f82uI64o8SkgkReX20gMDLG8NlnfH3M0VRlPUQ1hZVAZ1nJOTr+du1fxlQr1g xJJv2OqwHwwhtxdP/SBzhQMK0Ik7CUnlCO80/Odrgz9Rn6Dj6IAAtjCuNIrSmVF4plYU p8UA== X-Gm-Message-State: AOAM531E6TS8MJXKpfmb9lwzJ4Eqp6bRAIAYvVYAk5emnabVpO69Nweb BfVxQIUiMZYmhmbznQcmG1/bs2AnFYNjzYvYkxQ= X-Google-Smtp-Source: ABdhPJxa/960YuTeMm0K5eb1q2D7nuJTNeKDh2MyaKqIWQo6vJkEPyKluKIcSK7nplXXH6TAYCRKSSrxKX3UEx+73bI= X-Received: by 2002:a05:6e02:1c22:b0:2b9:dcbb:e810 with SMTP id m2-20020a056e021c2200b002b9dcbbe810mr4029105ilh.262.1645160209398; Thu, 17 Feb 2022 20:56:49 -0800 (PST) MIME-Version: 1.0 References: <20220212124100.3394466-1-gmuthukrishn@marvell.com> In-Reply-To: <20220212124100.3394466-1-gmuthukrishn@marvell.com> From: Jerin Jacob Date: Fri, 18 Feb 2022 10:26:23 +0530 Message-ID: Subject: Re: [PATCH] net/cnxk: fix uninitialized local variable To: Gowrishankar Muthukrishnan , Ferruh Yigit Cc: dpdk-dev , Nithin Dabilpuram , Kiran Kumar K , Sunil Kumar Kori , Satha Rao , Jerin Jacob Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Sat, Feb 12, 2022 at 6:11 PM Gowrishankar Muthukrishnan wrote: > > Fix uninitialized local variable as reported by coverity scan. > > Fixes: 6af19a9d89b ("net/cnxk: support meter action to flow destroy") > Coverity issue: 373630 > > Signed-off-by: Gowrishankar Muthukrishnan Acked-by: Jerin Jacob Applied to dpdk-next-net-mrvl/for-next-net. Thanks > --- > drivers/net/cnxk/cnxk_ethdev.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/cnxk/cnxk_ethdev.c b/drivers/net/cnxk/cnxk_ethdev.c > index 945600cdaf..62ffb65cc2 100644 > --- a/drivers/net/cnxk/cnxk_ethdev.c > +++ b/drivers/net/cnxk/cnxk_ethdev.c > @@ -177,7 +177,7 @@ nix_meter_fini(struct cnxk_eth_dev *dev) > struct roc_nix *nix = &dev->nix; > struct roc_nix_rq *rq; > uint32_t i; > - int rc; > + int rc = 0; > > RTE_TAILQ_FOREACH_SAFE(mtr, fms, next, next_mtr) { > for (i = 0; i < mtr->rq_num; i++) { > -- > 2.25.1 >