From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F0807A0C4D; Mon, 4 Oct 2021 17:47:02 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D60BC4137F; Mon, 4 Oct 2021 17:47:02 +0200 (CEST) Received: from mail-io1-f51.google.com (mail-io1-f51.google.com [209.85.166.51]) by mails.dpdk.org (Postfix) with ESMTP id 79BA24137E for ; Mon, 4 Oct 2021 17:47:01 +0200 (CEST) Received: by mail-io1-f51.google.com with SMTP id 5so8267930iov.9 for ; Mon, 04 Oct 2021 08:47:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=QwCJmD4DSVSbYlNAcFByhBAO2zKsaEcax4cwCV/saeo=; b=gw/LsQijsdDiHK+QWDxCyxPmOEwjws5ejI/307x6b6tIWp6QOZhaPKzTKXzPd6qHon hODW5Lw5+OjRF2Rc4e0u8AU/6v/zhGNFQhDYZb3s7cyEdkgfCEGvJuxoAg+mEIIlMMFx bXrumZWpqf7oYAqc2ftGNmyvUR+O7dP6fFotiX/iJFyEvATO1zWofWRl9RYm3C6YUvqF 1QsktEksiRRk+afrPS94Qophag9jsSYGFVG3HA6/oil9+pUncw3BzvEvFz8M+g2H4nLu FzvExpwEAj4ByjsaquzUw9xd7oys/kEYYq3ODJNl/uUcv4teVJ6m3oys7GtKqQ1C0Yp4 BtLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=QwCJmD4DSVSbYlNAcFByhBAO2zKsaEcax4cwCV/saeo=; b=dfQfCZ1YiMQxoajsKnOQmaX/HsVmmFBnkNJQMBr+kdTLNuNe3cOwIf0LW3cdR0fQJq nQztwUCz3qONoxOtX0Ra/26qDPWUTXQJjG3Ecg7NA9G7Uo2L5l/JdB6k4L8IGTLKr7O7 szT8niFdB/apaVZKOgOSweRgK29AU+1CaTHP0DCqufOovPQP2mLibUVdhoGgkPXOcoON d73Xgpn57bbbeRQRwuEKfIKjftrnY9CdI5WOm+uAkkH9sN8lnnZjNzITAmmGG/SIuHX4 xh3zX12/Hs8+o+azETBZLGad+tSaVeM17R7OTHhw0C1LTQ0EGdke1prYH0Vd0LDekmLf ftBg== X-Gm-Message-State: AOAM530qc7J8OISXzX2nSbcEPjP/CE0R66u+1VAsVkt7vhchK4PvaKhj d+w8MCCzaAxiQswGoGuq5NCKuyddiBvyC8xXO2A= X-Google-Smtp-Source: ABdhPJxqlaVtaYd7N7SWjy7l4kYrC2SFepc8EOjdhfQZaKS2IhgC7fqolTeTD1pzZPjmC0073ZTQ0S2dl3FehbnMn+o= X-Received: by 2002:a5e:de08:: with SMTP id e8mr10389699iok.151.1633362420710; Mon, 04 Oct 2021 08:47:00 -0700 (PDT) MIME-Version: 1.0 References: <20210917043746.3652748-1-psatheesh@marvell.com> In-Reply-To: <20210917043746.3652748-1-psatheesh@marvell.com> From: Jerin Jacob Date: Mon, 4 Oct 2021 21:16:34 +0530 Message-ID: To: Satheesh Paul Cc: Nithin Dabilpuram , Kiran Kumar K , Sunil Kumar Kori , Satha Rao , dpdk-dev Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] common/cnxk: fix incorrect free of MCAM counter X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Sep 17, 2021 at 10:08 AM wrote: > > From: Satheesh Paul > > Upon MCAM allocation failure, free counters only if counters > were allocated earlier for the flow rule. > > Fixes: f9af9080746 ("common/cnxk: add mcam utility API") > > Signed-off-by: Satheesh Paul Acked-by: Jerin Jacob Applied to dpdk-next-net-mrvl/for-next-net. Thanks > --- > drivers/common/cnxk/roc_npc_mcam.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/common/cnxk/roc_npc_mcam.c b/drivers/common/cnxk/roc_npc_mcam.c > index 8ccaaad0af..7d9b0ed3e3 100644 > --- a/drivers/common/cnxk/roc_npc_mcam.c > +++ b/drivers/common/cnxk/roc_npc_mcam.c > @@ -519,7 +519,8 @@ npc_mcam_alloc_and_write(struct npc *npc, struct roc_npc_flow *flow, > > entry = npc_check_preallocated_entry_cache(mbox, flow, npc); > if (entry < 0) { > - npc_mcam_free_counter(npc, ctr); > + if (use_ctr) > + npc_mcam_free_counter(npc, ctr); > return NPC_ERR_MCAM_ALLOC; > } > > -- > 2.25.4 >