DPDK patches and discussions
 help / color / mirror / Atom feed
From: Jerin Jacob <jerinjacobk@gmail.com>
To: Pavan Nikhilesh <pbhagavatula@marvell.com>
Cc: Jerin Jacob <jerinj@marvell.com>,
	Radu Nicolau <radu.nicolau@intel.com>,
	 Akhil Goyal <gakhil@marvell.com>, dpdk-dev <dev@dpdk.org>
Subject: Re: [PATCH 6/6] examples/ipsec-secgw: cleanup worker state before exit
Date: Fri, 13 May 2022 19:11:34 +0530
Message-ID: <CALBAE1PxUOojh+gyvA5e34YMPk1yH6shSu=j4WJ3Yz0RSOLDdw@mail.gmail.com> (raw)
In-Reply-To: <20220426211412.6138-6-pbhagavatula@marvell.com>

On Wed, Apr 27, 2022 at 2:45 AM Pavan Nikhilesh
<pbhagavatula@marvell.com> wrote:
>
> Event ports are configured to implicitly release the scheduler contexts
> currently held in the next call to rte_event_dequeue_burst().
> A worker core might still hold a scheduling context during exit as the
> next call to rte_event_dequeue_burst() is never made.
> This might lead to deadlock based on the worker exit timing and when
> there are very less number of flows.
>
> Add a cleanup function to release any scheduling contexts held by the
> worker by using RTE_EVENT_OP_RELEASE.
>
> Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>

Please fix following check path error in this series

### app/eventdev: simplify signal handling and teardown

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#163: FILE: app/test-eventdev/test_perf_common.c:1112:
+               RTE_ETH_FOREACH_DEV (i) {

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#234: FILE: app/test-eventdev/test_pipeline_common.c:515:
+               RTE_ETH_FOREACH_DEV (i) {

> ---
>  examples/ipsec-secgw/ipsec_worker.c | 40 ++++++++++++++++++++---------
>  1 file changed, 28 insertions(+), 12 deletions(-)
>
> diff --git a/examples/ipsec-secgw/ipsec_worker.c b/examples/ipsec-secgw/ipsec_worker.c
> index 8639426c5c..3df5acf384 100644
> --- a/examples/ipsec-secgw/ipsec_worker.c
> +++ b/examples/ipsec-secgw/ipsec_worker.c
> @@ -749,7 +749,7 @@ ipsec_wrkr_non_burst_int_port_drv_mode(struct eh_event_link_info *links,
>                 uint8_t nb_links)
>  {
>         struct port_drv_mode_data data[RTE_MAX_ETHPORTS];
> -       unsigned int nb_rx = 0;
> +       unsigned int nb_rx = 0, nb_tx;
>         struct rte_mbuf *pkt;
>         struct rte_event ev;
>         uint32_t lcore_id;
> @@ -847,11 +847,19 @@ ipsec_wrkr_non_burst_int_port_drv_mode(struct eh_event_link_info *links,
>                  * directly enqueued to the adapter and it would be
>                  * internally submitted to the eth device.
>                  */
> -               rte_event_eth_tx_adapter_enqueue(links[0].eventdev_id,
> -                               links[0].event_port_id,
> -                               &ev,    /* events */
> -                               1,      /* nb_events */
> -                               0       /* flags */);
> +               nb_tx = rte_event_eth_tx_adapter_enqueue(links[0].eventdev_id,
> +                                                        links[0].event_port_id,
> +                                                        &ev, /* events */
> +                                                        1,   /* nb_events */
> +                                                        0 /* flags */);
> +               if (!nb_tx)
> +                       rte_pktmbuf_free(ev.mbuf);
> +       }
> +
> +       if (ev.u64) {
> +               ev.op = RTE_EVENT_OP_RELEASE;
> +               rte_event_enqueue_burst(links[0].eventdev_id,
> +                                       links[0].event_port_id, &ev, 1);
>         }
>  }
>
> @@ -864,7 +872,7 @@ ipsec_wrkr_non_burst_int_port_app_mode(struct eh_event_link_info *links,
>                 uint8_t nb_links)
>  {
>         struct lcore_conf_ev_tx_int_port_wrkr lconf;
> -       unsigned int nb_rx = 0;
> +       unsigned int nb_rx = 0, nb_tx;
>         struct rte_event ev;
>         uint32_t lcore_id;
>         int32_t socket_id;
> @@ -952,11 +960,19 @@ ipsec_wrkr_non_burst_int_port_app_mode(struct eh_event_link_info *links,
>                  * directly enqueued to the adapter and it would be
>                  * internally submitted to the eth device.
>                  */
> -               rte_event_eth_tx_adapter_enqueue(links[0].eventdev_id,
> -                               links[0].event_port_id,
> -                               &ev,    /* events */
> -                               1,      /* nb_events */
> -                               0       /* flags */);
> +               nb_tx = rte_event_eth_tx_adapter_enqueue(links[0].eventdev_id,
> +                                                        links[0].event_port_id,
> +                                                        &ev, /* events */
> +                                                        1,   /* nb_events */
> +                                                        0 /* flags */);
> +               if (!nb_tx)
> +                       rte_pktmbuf_free(ev.mbuf);
> +       }
> +
> +       if (ev.u64) {
> +               ev.op = RTE_EVENT_OP_RELEASE;
> +               rte_event_enqueue_burst(links[0].eventdev_id,
> +                                       links[0].event_port_id, &ev, 1);
>         }
>  }
>
> --
> 2.25.1
>

  reply	other threads:[~2022-05-13 13:42 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-26 21:14 [PATCH 1/6] app/eventdev: simplify signal handling and teardown Pavan Nikhilesh
2022-04-26 21:14 ` [PATCH 2/6] app/eventdev: clean up worker state before exit Pavan Nikhilesh
2022-05-13 13:40   ` Jerin Jacob
2022-04-26 21:14 ` [PATCH 3/6] examples/eventdev: " Pavan Nikhilesh
2022-04-26 21:14 ` [PATCH 4/6] examples/l3fwd: " Pavan Nikhilesh
2022-04-26 21:14 ` [PATCH 5/6] examples/l2fwd-event: " Pavan Nikhilesh
2022-04-26 21:14 ` [PATCH 6/6] examples/ipsec-secgw: cleanup " Pavan Nikhilesh
2022-05-13 13:41   ` Jerin Jacob [this message]
2022-05-13 11:49 ` [PATCH 1/6] app/eventdev: simplify signal handling and teardown Jerin Jacob
2022-05-13 13:39 ` Jerin Jacob
2022-05-13 16:07 ` [PATCH v2 " pbhagavatula
2022-05-13 16:07   ` [PATCH v2 2/6] app/eventdev: clean up worker state before exit pbhagavatula
2022-05-13 16:07   ` [PATCH v2 3/6] examples/eventdev: " pbhagavatula
2022-05-13 16:07   ` [PATCH v2 4/6] examples/l3fwd: " pbhagavatula
2022-05-13 16:07   ` [PATCH v2 5/6] examples/l2fwd-event: " pbhagavatula
2022-05-13 16:07   ` [PATCH v2 6/6] examples/ipsec-secgw: cleanup " pbhagavatula
2022-05-16 16:46   ` [PATCH v2 1/6] app/eventdev: simplify signal handling and teardown Jerin Jacob

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CALBAE1PxUOojh+gyvA5e34YMPk1yH6shSu=j4WJ3Yz0RSOLDdw@mail.gmail.com' \
    --to=jerinjacobk@gmail.com \
    --cc=dev@dpdk.org \
    --cc=gakhil@marvell.com \
    --cc=jerinj@marvell.com \
    --cc=pbhagavatula@marvell.com \
    --cc=radu.nicolau@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror http://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ http://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git