From: Jerin Jacob <jerinjacobk@gmail.com>
To: Sunil Kumar Kori <skori@marvell.com>,
Ferruh Yigit <ferruh.yigit@intel.com>
Cc: Jerin Jacob <jerinj@marvell.com>,
Nithin Dabilpuram <ndabilpuram@marvell.com>,
Kiran Kumar K <kirankumark@marvell.com>, dpdk-dev <dev@dpdk.org>,
dpdk stable <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] net/octeontx2: error on loopback mode for VFs
Date: Tue, 26 Nov 2019 16:34:22 +0900 [thread overview]
Message-ID: <CALBAE1PxjOFfXmbLwSCee1NvLw1CCvtspZnTiMNY+CtFoTyxzw@mail.gmail.com> (raw)
In-Reply-To: <20191126070358.11322-1-skori@marvell.com>
On Tue, Nov 26, 2019 at 4:04 PM Sunil Kumar Kori <skori@marvell.com> wrote:
>
> loopback mode is not supported for VFs so returning error if
> VF is being configured with loopback mode.
>
> Fixes: 920717e4d8ba ("net/octeontx2: add device start operation")
Cc: stable@dpdk.org
>
> Signed-off-by: Sunil Kumar Kori <skori@marvell.com>
> ---
Changed the subject to: net/octeontx2: fix loopback config return value for VF
Acked-by: Jerin Jacob <jerinj@marvell.com>
Applied to dpdk-next-net-mrvl/master. Thanks
> drivers/net/octeontx2/otx2_ethdev.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/octeontx2/otx2_ethdev.c b/drivers/net/octeontx2/otx2_ethdev.c
> index ddab3aa06..70eebaef1 100644
> --- a/drivers/net/octeontx2/otx2_ethdev.c
> +++ b/drivers/net/octeontx2/otx2_ethdev.c
> @@ -205,7 +205,7 @@ cgx_intlbk_enable(struct otx2_eth_dev *dev, bool en)
> struct otx2_mbox *mbox = dev->mbox;
>
> if (otx2_dev_is_vf_or_sdp(dev))
> - return 0;
> + return -ENOTSUP;
>
> if (en)
> otx2_mbox_alloc_msg_cgx_intlbk_enable(mbox);
> --
> 2.17.1
>
prev parent reply other threads:[~2019-11-26 7:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-26 7:03 Sunil Kumar Kori
2019-11-26 7:34 ` Jerin Jacob [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALBAE1PxjOFfXmbLwSCee1NvLw1CCvtspZnTiMNY+CtFoTyxzw@mail.gmail.com \
--to=jerinjacobk@gmail.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=jerinj@marvell.com \
--cc=kirankumark@marvell.com \
--cc=ndabilpuram@marvell.com \
--cc=skori@marvell.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).