DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] net/octeontx2: error on loopback mode for VFs
@ 2019-11-26  7:03 Sunil Kumar Kori
  2019-11-26  7:34 ` Jerin Jacob
  0 siblings, 1 reply; 2+ messages in thread
From: Sunil Kumar Kori @ 2019-11-26  7:03 UTC (permalink / raw)
  To: Jerin Jacob, Nithin Dabilpuram, Kiran Kumar K
  Cc: dev, stable, Sunil Kumar Kori

loopback mode is not supported for VFs so returning error if
VF is being configured with loopback mode.

Fixes: 920717e4d8ba ("net/octeontx2: add device start operation")

Signed-off-by: Sunil Kumar Kori <skori@marvell.com>
---
 drivers/net/octeontx2/otx2_ethdev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/octeontx2/otx2_ethdev.c b/drivers/net/octeontx2/otx2_ethdev.c
index ddab3aa06..70eebaef1 100644
--- a/drivers/net/octeontx2/otx2_ethdev.c
+++ b/drivers/net/octeontx2/otx2_ethdev.c
@@ -205,7 +205,7 @@ cgx_intlbk_enable(struct otx2_eth_dev *dev, bool en)
 	struct otx2_mbox *mbox = dev->mbox;
 
 	if (otx2_dev_is_vf_or_sdp(dev))
-		return 0;
+		return -ENOTSUP;
 
 	if (en)
 		otx2_mbox_alloc_msg_cgx_intlbk_enable(mbox);
-- 
2.17.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dpdk-dev] [PATCH] net/octeontx2: error on loopback mode for VFs
  2019-11-26  7:03 [dpdk-dev] [PATCH] net/octeontx2: error on loopback mode for VFs Sunil Kumar Kori
@ 2019-11-26  7:34 ` Jerin Jacob
  0 siblings, 0 replies; 2+ messages in thread
From: Jerin Jacob @ 2019-11-26  7:34 UTC (permalink / raw)
  To: Sunil Kumar Kori, Ferruh Yigit
  Cc: Jerin Jacob, Nithin Dabilpuram, Kiran Kumar K, dpdk-dev, dpdk stable

On Tue, Nov 26, 2019 at 4:04 PM Sunil Kumar Kori <skori@marvell.com> wrote:
>
> loopback mode is not supported for VFs so returning error if
> VF is being configured with loopback mode.
>
> Fixes: 920717e4d8ba ("net/octeontx2: add device start operation")

Cc: stable@dpdk.org

>
> Signed-off-by: Sunil Kumar Kori <skori@marvell.com>
> ---

Changed the subject to:  net/octeontx2: fix loopback config return value for VF

Acked-by: Jerin Jacob <jerinj@marvell.com>

Applied to dpdk-next-net-mrvl/master. Thanks


>  drivers/net/octeontx2/otx2_ethdev.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/octeontx2/otx2_ethdev.c b/drivers/net/octeontx2/otx2_ethdev.c
> index ddab3aa06..70eebaef1 100644
> --- a/drivers/net/octeontx2/otx2_ethdev.c
> +++ b/drivers/net/octeontx2/otx2_ethdev.c
> @@ -205,7 +205,7 @@ cgx_intlbk_enable(struct otx2_eth_dev *dev, bool en)
>         struct otx2_mbox *mbox = dev->mbox;
>
>         if (otx2_dev_is_vf_or_sdp(dev))
> -               return 0;
> +               return -ENOTSUP;
>
>         if (en)
>                 otx2_mbox_alloc_msg_cgx_intlbk_enable(mbox);
> --
> 2.17.1
>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-11-26  7:34 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-26  7:03 [dpdk-dev] [PATCH] net/octeontx2: error on loopback mode for VFs Sunil Kumar Kori
2019-11-26  7:34 ` Jerin Jacob

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).