From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 29CB7A0A02; Thu, 25 Mar 2021 13:46:33 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A20F64067B; Thu, 25 Mar 2021 13:46:32 +0100 (CET) Received: from mail-io1-f52.google.com (mail-io1-f52.google.com [209.85.166.52]) by mails.dpdk.org (Postfix) with ESMTP id E18FB40147 for ; Thu, 25 Mar 2021 13:46:30 +0100 (CET) Received: by mail-io1-f52.google.com with SMTP id z3so1752961ioc.8 for ; Thu, 25 Mar 2021 05:46:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Oqsvoe0KB0i1Gp1qvEZphVpcn5g3IC33+Hj0u8sFeE4=; b=RVtftjZhtRHSmI+8KzX+p2I1ndWtHjV1gbkWmbh5wnrYS7K6e19P50ZIyBZYEQONHc miq2BZYT1o/+0/6WRvBFnod+4y/IYWLWmA34F23HsRo2JNQNEGCfeUdQgMUQMWmFKqvh F4QGqtJqG63zLmzPMmAFpjOCfcTvoSa+Q5rNwA/xNEV/FRItXb1EaLfVsZuZHZj5Sfut Bjh3/4OGcwNSenUjyYlVoqR4JeVcm6gKtGTVYuhR1gQprs6dfp81TNqRnliaG1Yy/nrp BrPu92sSz4Qe1FIhqGDwskOsHZLuVcW7l5ZN4wFbt8p5IerGzMVXR/AxwdbdV8K9r5h9 zH8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Oqsvoe0KB0i1Gp1qvEZphVpcn5g3IC33+Hj0u8sFeE4=; b=Ni4GM4Hd/nHXkg/ITFrhXBvyO3asLETBPw5C0JArPbuKuRfiAN18UyVF8uFG986D7k gkWfDGuQt6f/99dyLNi4Gi+TeUn88BQ5EMRe2BLeXEC2B9CxYaQVrX2eiO2HAJt5b/me GxBsh5ytOoIWD7HecTYcsLpXlyWVL6YWLP0uoySs2nMBg+8np9nUIu6kVj/y1D1G3v63 H85izVSqrwuTW8nZ8Y1d4kl0BItZOk/02q1ZulmDO2wAFNxsAfbyzujkNocmbcBmHMaE sjjgUhc4A+gjlJkqfx/M/E5UOTc8WMG+5QiKRSjuv9FDyMKQUm+9XkEx+n+I+AquhTGh 46qQ== X-Gm-Message-State: AOAM531rokR4CVvHy3ezpV4v8d4ImAKpIULi/zh0Y6Zs4J18KUsLaY9T ++CX5eGVfotF/YN3hr10f01/rCSLbcjU0Nj9rpQ= X-Google-Smtp-Source: ABdhPJzMWSOAguADBB3dr5s/V9t9l9+8wi6EXxnm1KOSmMhJCkBU4SGiQufnx+cGyc9/PqsTJOZkebT2TenDGSwJ9pE= X-Received: by 2002:a6b:3bc7:: with SMTP id i190mr6378985ioa.163.1616676390235; Thu, 25 Mar 2021 05:46:30 -0700 (PDT) MIME-Version: 1.0 References: <20210225170238.15581-1-pbhagavatula@marvell.com> <11975004.s7UMkAiPBC@thomas> <5cb9bec3-6d4e-7867-e8d7-9c3d55ec78ef@ashroe.eu> <5442273.ffSK4IfYTI@thomas> In-Reply-To: <5442273.ffSK4IfYTI@thomas> From: Jerin Jacob Date: Thu, 25 Mar 2021 18:16:14 +0530 Message-ID: To: Thomas Monjalon Cc: Pavan Nikhilesh , Jerin Jacob , "Kinsella, Ray" , dpdk-dev , Harman Kalra , Nithin Dabilpuram , David Marchand Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH 1/7] common/octeontx: enable build only on 64bit Linux X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Mar 25, 2021 at 4:33 PM Thomas Monjalon wrote: > > 25/03/2021 11:58, Kinsella, Ray: > > On 25/03/2021 10:46, Thomas Monjalon wrote: > > > 25/03/2021 11:42, Thomas Monjalon: > > >> 24/03/2021 11:55, Jerin Jacob: > > >>> On Thu, Feb 25, 2021 at 10:33 PM wrote: > > >>>> > > >>>> From: Pavan Nikhilesh > > >>>> > > >>>> Due to Linux kernel dependency, only enable build for 64bit Linux. > > >>>> > > >>>> Signed-off-by: Pavan Nikhilesh > > >>> > > >>> Series Acked-by: Jerin Jacob > > >> > > >> I've reorganized the commits per family of drivers, > > >> so it makes more sense than grouping per driver class > > >> with "common/octeontx" for title for all: > > >> > > >> net/thunderx: enable build only on 64-bit Linux > > >> common/octeontx: enable build only on 64-bit Linux > > >> common/octeontx2: enable build only on 64-bit Linux > > >> > > >> and applied. > > > > > > Actually not applied yet. > > > I'm not sure what to do for the ABI check which is broken > > > because some drivers are not compiled anymore in 32-bit build. > > > I've workarounded locally by removing the dump files in the reference build. > > > Should we add an exception in libabigail.abignore? > > > > > In the past we said that depreciating HW support would be considered to be same as an ABI Breakage. > > > > From the policy ... > > "Updates to the minimum hardware requirements, which drop support for hardware which was previously supported, should be treated as an ABI change." > > So the patches should wait 21.11. > Everybody agree? Looks good to me to postpone. @Ray Kinsella @Thomas Monjalon @McDaniel, Timothy @David Marchand @Neil Horman Currently, I merged DLB v1 driver removal patch to next-eventdev. Is this ABI breakge[1]? http://patches.dpdk.org/project/dpdk/patch/20210316210812.15614-1-timothy.mcdaniel@intel.com/ [1] >From the policy ... "Updates to the minimum hardware requirements, which drop support for hardware which was previously supported, should be treated as an ABI change."