From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 31821A00C5; Sun, 26 Apr 2020 20:48:56 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4FC7E1C18F; Sun, 26 Apr 2020 20:48:55 +0200 (CEST) Received: from mail-il1-f194.google.com (mail-il1-f194.google.com [209.85.166.194]) by dpdk.org (Postfix) with ESMTP id 64DE31C18E for ; Sun, 26 Apr 2020 20:48:54 +0200 (CEST) Received: by mail-il1-f194.google.com with SMTP id m5so6390921ilj.10 for ; Sun, 26 Apr 2020 11:48:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=s/jV224TIRTp1ElaEZGmz5CZ20WT1mO68VLS9Eu+iMw=; b=SnqTv+mEa70ME+ipmAItZfC1+P463wG5dncjSvHLUnRGVejWOt+ix+9zMNbToKcCRJ g0uv6Hzo/AWitYDfLXtRbsyrRd2oYVdEV4LuEEaP2DWnTMd6nyO+WYKkeatB6+BdhSgz 8HT4yJavYJpuUJNhQ+2JDkV/2uis3gI7a+uQgZKopXodDgFzOi1eteWqMKCLZX2HZC9c bEmGfKgiJlpPrprQKIvk5G05UZ+ruH0Qe8QICbhfSh+Rk9vdY7pvLRQLjSjYAUIi9gkF NmnkerItZp66oWC8IM1RNiUdGwbmmAp1lTWzBxi75AaTCMyKz0RaQPNP7xt+upq8AB3i 6Vhw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=s/jV224TIRTp1ElaEZGmz5CZ20WT1mO68VLS9Eu+iMw=; b=FTPFxiQFGCSpf8/7WD+fTnFIQs4WQ0tK/DyQhZbVTTcBBQVrp+Cqu8VlFz2YJ3Hlqi KbrYv0IqsGO9U6nPU/CfwFmc00HgaqlOsGubprNFMq7nkdqJLTx7r6cmW7PfBHI3lyUw Eflsdb0EIdkuEdkoRq3NAxwcNPfbUvrXx27uSL+4oDrRhU2EiubS2b8Yep1sXjbhcB9r myK2EmT3QZ4Y3hywWutVYfehgqXWWPrA+NvqU95zqnrbKdpcRHcA3Ti3hx3IC8pyJOkN 15lKWGguciHdLF5PHEIoefxDtI3dDKWn5YKy1UW7bcOAt0AKQ1Hfo09vXlTo0+AqJZAP 6MLQ== X-Gm-Message-State: AGi0PuZso17S3TFbeKud2PmqPr8Gi0+ynEvBymaPn+jIxauyduD0Nq84 c1Ag1qzIWsBvFAnFWyx2pT4Ahx16qlK2DYQd0N0= X-Google-Smtp-Source: APiQypK8WZYJYUG2yum7JsuKxmAEwYWO+HA7xc/42Ec/HG4hCKtETHYw9hLVVTzPnz8Wc7NtP72iMIgqscI3aulPPkw= X-Received: by 2002:a92:9edb:: with SMTP id s88mr18513977ilk.294.1587926933658; Sun, 26 Apr 2020 11:48:53 -0700 (PDT) MIME-Version: 1.0 References: <20200121080021.2835490-1-jerinj@marvell.com> <7318372.iedYuu7f5S@thomas> <4168892.bm5RmrZB5H@thomas> In-Reply-To: <4168892.bm5RmrZB5H@thomas> From: Jerin Jacob Date: Mon, 27 Apr 2020 00:18:38 +0530 Message-ID: To: Thomas Monjalon Cc: Jerin Jacob , dpdk-dev , Olivier Matz Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] bus/pci: set boot-up log prints to absolute minimum X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Sun, Apr 26, 2020 at 11:37 PM Thomas Monjalon wrote: > > 26/04/2020 19:42, Jerin Jacob: > > On Sun, Apr 26, 2020 at 1:42 AM Thomas Monjalon wrote: > > > 06/02/2020 15:36, Jerin Jacob: > > > > On Thu, Feb 6, 2020 at 7:44 PM Thomas Monjalon wrote: > > > > > 21/01/2020 09:00, jerinj@marvell.com: > > > > > > From: Jerin Jacob > > > > > > > > > > > > Some machines may have a lot of PCI devices, logs from PCI probe > > > > > > creates a lot of clutter on boot-up, typically one needs > > > > > > to scroll the screen to find other issues in boot-up. > > > > > > > > > > > > This patch changes the loglevel of PCI probes to `debug` > > > > > > to reduce the clutter on default boot-up logs > > > > > > > > > > I think the PCI probe informations are... informational. > > > > > Maybe you are just not interested in info logs. > > > > > If this is the case, I suggest to change the log level at runtime. > > > > > > > > I am wondering, what would be the right balance, Following is DPDK > > > > startup output from octeontx2[1] > > > > It creates a lot of clutter in the "default" boot up. Why not enable > > > > below prints using log level at runtime? > > > > I believe it comes as a debug category, i.e information required to > > > > debug if something is not working, > > > > dpdk bind script already lists what is bound to DPDK. > > > > > > > > Suggestion to remove clutter? > > > > > > I suggest using dynamic log level in the PCI driver. > > > Unfortunately a lot of old DPDK code is still using the old log macros. > > > Some cleanup work is needed here. > > > > Sent an alternative fix to skip probing the devices with RTE_KDRV_NONE. > > No, a PCI PMD can work without a known kernel driver. > This is the case of mlx4/mlx5. Yes. it can work with UNKNOWN, But It not with NONE. > > > I think that is the source of the problem. > > http://patches.dpdk.org/patch/69351/ > > The source of the problem is just changing log levels dynamically > is not possible currently with PCI driver logs. Assuming if we add, dynamic stuff what would the default log level for RTE_LOG(INFO, EAL, "PCI device "PCI_PRI_FMT" on NUMA socket %i\n", If it is INFO, Still the problem persist in the default bootup. Right? > >