From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C12A8A0093; Tue, 17 May 2022 16:23:23 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7C7F140041; Tue, 17 May 2022 16:23:23 +0200 (CEST) Received: from mail-io1-f43.google.com (mail-io1-f43.google.com [209.85.166.43]) by mails.dpdk.org (Postfix) with ESMTP id 5C4154003C for ; Tue, 17 May 2022 16:23:21 +0200 (CEST) Received: by mail-io1-f43.google.com with SMTP id q203so3576444iod.0 for ; Tue, 17 May 2022 07:23:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=94YP3A/hZaorQpfj8bTCiO/LJ82bTM4BaSaPTUx8RIQ=; b=JGZBoMdjib1zSVvymL2RmPeoOUy5ujPgR6a1F8GPLWu/DsSDeojTnsm8gYJ33dKJLe KIcBzEsVS/qRuJnpiCqbZ2MvyWh8CeNnWK/gnpQghIV1Lk815Us38msake8joaeoY4Xf iHk1eOlqu/Yu8pZiZ+Mup5h0NNHI95mM5FHIy79zwfb2TJQn63oTW8A8RjZbwiblr4Wb 0JmbEjJwRXK6pyjBZv5RVUQkPqqzPlRpM2NU4bsZH1iJsAdi/t8hW6T4tqq5EPrRLorl PN3ODW9Dp8B8mwjYgzuyeDq66doN7brbGApY0NayOOo9agoyqyGEWRrdE0TxVHu9A2AY HcYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=94YP3A/hZaorQpfj8bTCiO/LJ82bTM4BaSaPTUx8RIQ=; b=milP8NJKmGyRqI6HuxrDZMzKtFFfAR2YyL+oS8hkUGKIGn1djzMRoXJTCJf7Kub3Da q7ciknW/OEwtLlAHlXj4u2EbVzoj1l/34y7kPzth9+xbqpDncE9BNCsPvEbxDBYqywkf LOitO3shXrZ+9wDkylNyk+5b+ql2D3ihGNHkPtk7v4rCTn9qJLifBvgRTqcOmmS6dXgy V/I05fupq1dlyU3f4nbukewZig9ozuU+9aei43fyoRfG21+BGFUNmGXpGHf07fEGABq+ mdWTdnFXP1uAa9n9YFtEshWrtXCxty7SwrAeb4mZnKwM7mBVzxcSdwPigJH1/fU+9dbD q4xQ== X-Gm-Message-State: AOAM531xiYrUY0xsuPrKOCYpMtSWZnwrkKQSogZmS3khZfAEnj6SyfWT VficBhZP4weuymx/a0fY8QYYawzkilmpxMVEkEsV14AHfj8= X-Google-Smtp-Source: ABdhPJxjomJFZz7XT5wIGKCUSJKX8iQ9Fhy8DzImRrgbRkfcIQl5WTzpj2Gge0cixWOQ9kEbrTOJ7g04u/Gkn0YFtco= X-Received: by 2002:a05:6638:468e:b0:32b:fe24:906a with SMTP id bq14-20020a056638468e00b0032bfe24906amr11800711jab.123.1652797400606; Tue, 17 May 2022 07:23:20 -0700 (PDT) MIME-Version: 1.0 References: <0bdc8e88eacf7b41e27691b564350853577363e9.1652610489.git.sthotton@marvell.com> In-Reply-To: From: Jerin Jacob Date: Tue, 17 May 2022 19:52:54 +0530 Message-ID: Subject: Re: [PATCH v2] event/cnxk: flush event queues over multiple pass To: Shijith Thotton Cc: dpdk-dev , Jerin Jacob , Pavan Nikhilesh Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, May 16, 2022 at 9:52 PM Shijith Thotton wrote: > > If an event queue flush does not complete after a fixed number of tries, > remaining queues are flushed before retrying the one with incomplete > flush. > > Signed-off-by: Shijith Thotton Applied to dpdk-next-net-eventdev/for-main. Thanks > --- > drivers/event/cnxk/cn10k_eventdev.c | 10 +++++++++- > drivers/event/cnxk/cn9k_eventdev.c | 10 +++++++++- > drivers/event/cnxk/cnxk_eventdev.c | 31 ++++++++++++++++++++++------- > drivers/event/cnxk/cnxk_eventdev.h | 5 +++-- > 4 files changed, 45 insertions(+), 11 deletions(-) > > diff --git a/drivers/event/cnxk/cn10k_eventdev.c b/drivers/event/cnxk/cn10k_eventdev.c > index 94829e789c..f70c4c58ce 100644 > --- a/drivers/event/cnxk/cn10k_eventdev.c > +++ b/drivers/event/cnxk/cn10k_eventdev.c > @@ -108,10 +108,11 @@ cn10k_sso_hws_release(void *arg, void *hws) > memset(ws, 0, sizeof(*ws)); > } > > -static void > +static int > cn10k_sso_hws_flush_events(void *hws, uint8_t queue_id, uintptr_t base, > cnxk_handle_event_t fn, void *arg) > { > + uint64_t retry = CNXK_SSO_FLUSH_RETRY_MAX; > struct cn10k_sso_hws *ws = hws; > uint64_t cq_ds_cnt = 1; > uint64_t aq_cnt = 1; > @@ -141,6 +142,8 @@ cn10k_sso_hws_flush_events(void *hws, uint8_t queue_id, uintptr_t base, > fn(arg, ev); > if (ev.sched_type != SSO_TT_EMPTY) > cnxk_sso_hws_swtag_flush(ws->base); > + else if (retry-- == 0) > + break; > do { > val = plt_read64(ws->base + SSOW_LF_GWS_PENDSTATE); > } while (val & BIT_ULL(56)); > @@ -151,8 +154,13 @@ cn10k_sso_hws_flush_events(void *hws, uint8_t queue_id, uintptr_t base, > cq_ds_cnt &= 0x3FFF3FFF0000; > } > > + if (aq_cnt || cq_ds_cnt || ds_cnt) > + return -EAGAIN; > + > plt_write64(0, ws->base + SSOW_LF_GWS_OP_GWC_INVAL); > rte_mb(); > + > + return 0; > } > > static void > diff --git a/drivers/event/cnxk/cn9k_eventdev.c b/drivers/event/cnxk/cn9k_eventdev.c > index 987888d3db..dce975bba2 100644 > --- a/drivers/event/cnxk/cn9k_eventdev.c > +++ b/drivers/event/cnxk/cn9k_eventdev.c > @@ -117,11 +117,12 @@ cn9k_sso_hws_release(void *arg, void *hws) > } > } > > -static void > +static int > cn9k_sso_hws_flush_events(void *hws, uint8_t queue_id, uintptr_t base, > cnxk_handle_event_t fn, void *arg) > { > struct cnxk_sso_evdev *dev = cnxk_sso_pmd_priv(arg); > + uint64_t retry = CNXK_SSO_FLUSH_RETRY_MAX; > struct cnxk_timesync_info *tstamp; > struct cn9k_sso_hws_dual *dws; > struct cn9k_sso_hws *ws; > @@ -164,6 +165,8 @@ cn9k_sso_hws_flush_events(void *hws, uint8_t queue_id, uintptr_t base, > fn(arg, ev); > if (ev.sched_type != SSO_TT_EMPTY) > cnxk_sso_hws_swtag_flush(ws_base); > + else if (retry-- == 0) > + break; > do { > val = plt_read64(ws_base + SSOW_LF_GWS_PENDSTATE); > } while (val & BIT_ULL(56)); > @@ -174,7 +177,12 @@ cn9k_sso_hws_flush_events(void *hws, uint8_t queue_id, uintptr_t base, > cq_ds_cnt &= 0x3FFF3FFF0000; > } > > + if (aq_cnt || cq_ds_cnt || ds_cnt) > + return -EAGAIN; > + > plt_write64(0, ws_base + SSOW_LF_GWS_OP_GWC_INVAL); > + > + return 0; > } > > static void > diff --git a/drivers/event/cnxk/cnxk_eventdev.c b/drivers/event/cnxk/cnxk_eventdev.c > index be021d86c9..91235ed9f3 100644 > --- a/drivers/event/cnxk/cnxk_eventdev.c > +++ b/drivers/event/cnxk/cnxk_eventdev.c > @@ -385,9 +385,10 @@ static void > cnxk_sso_cleanup(struct rte_eventdev *event_dev, cnxk_sso_hws_reset_t reset_fn, > cnxk_sso_hws_flush_t flush_fn, uint8_t enable) > { > + uint8_t pend_list[RTE_EVENT_MAX_QUEUES_PER_DEV], pend_cnt, new_pcnt; > struct cnxk_sso_evdev *dev = cnxk_sso_pmd_priv(event_dev); > uintptr_t hwgrp_base; > - uint16_t i; > + uint8_t queue_id, i; > void *ws; > > for (i = 0; i < dev->nb_event_ports; i++) { > @@ -396,14 +397,30 @@ cnxk_sso_cleanup(struct rte_eventdev *event_dev, cnxk_sso_hws_reset_t reset_fn, > } > > rte_mb(); > + > + /* Consume all the events through HWS0 */ > ws = event_dev->data->ports[0]; > > - for (i = 0; i < dev->nb_event_queues; i++) { > - /* Consume all the events through HWS0 */ > - hwgrp_base = roc_sso_hwgrp_base_get(&dev->sso, i); > - flush_fn(ws, i, hwgrp_base, cnxk_handle_event, event_dev); > - /* Enable/Disable SSO GGRP */ > - plt_write64(enable, hwgrp_base + SSO_LF_GGRP_QCTL); > + /* Starting list of queues to flush */ > + pend_cnt = dev->nb_event_queues; > + for (i = 0; i < dev->nb_event_queues; i++) > + pend_list[i] = i; > + > + while (pend_cnt) { > + new_pcnt = 0; > + for (i = 0; i < pend_cnt; i++) { > + queue_id = pend_list[i]; > + hwgrp_base = > + roc_sso_hwgrp_base_get(&dev->sso, queue_id); > + if (flush_fn(ws, queue_id, hwgrp_base, > + cnxk_handle_event, event_dev)) { > + pend_list[new_pcnt++] = queue_id; > + continue; > + } > + /* Enable/Disable SSO GGRP */ > + plt_write64(enable, hwgrp_base + SSO_LF_GGRP_QCTL); > + } > + pend_cnt = new_pcnt; > } > } > > diff --git a/drivers/event/cnxk/cnxk_eventdev.h b/drivers/event/cnxk/cnxk_eventdev.h > index 5564746e6d..a490829a8a 100644 > --- a/drivers/event/cnxk/cnxk_eventdev.h > +++ b/drivers/event/cnxk/cnxk_eventdev.h > @@ -54,6 +54,7 @@ > #define CN10K_GW_MODE_PREF 1 > #define CN10K_GW_MODE_PREF_WFE 2 > > +#define CNXK_SSO_FLUSH_RETRY_MAX 0xfff > #define CNXK_VALID_DEV_OR_ERR_RET(dev, drv_name) \ > do { \ > if (strncmp(dev->driver->name, drv_name, strlen(drv_name))) \ > @@ -69,8 +70,8 @@ typedef int (*cnxk_sso_unlink_t)(void *dev, void *ws, uint16_t *map, > uint16_t nb_link); > typedef void (*cnxk_handle_event_t)(void *arg, struct rte_event ev); > typedef void (*cnxk_sso_hws_reset_t)(void *arg, void *ws); > -typedef void (*cnxk_sso_hws_flush_t)(void *ws, uint8_t queue_id, uintptr_t base, > - cnxk_handle_event_t fn, void *arg); > +typedef int (*cnxk_sso_hws_flush_t)(void *ws, uint8_t queue_id, uintptr_t base, > + cnxk_handle_event_t fn, void *arg); > > struct cnxk_sso_qos { > uint16_t queue; > -- > 2.25.1 >