From: Jerin Jacob <jerinjacobk@gmail.com>
To: David Marchand <david.marchand@redhat.com>
Cc: David Christensen <drc@linux.vnet.ibm.com>, dev <dev@dpdk.org>,
David Wilder <wilder@us.ibm.com>,
"Burakov, Anatoly" <anatoly.burakov@intel.com>,
Jerin Jacob Kollanukkaran <jerinj@marvell.com>
Subject: Re: [dpdk-dev] [PATCH] pci: fix unneeded includes in public header file
Date: Fri, 20 Mar 2020 18:55:47 +0530 [thread overview]
Message-ID: <CALBAE1PyYQMyD1amMXnN8ypSq2=UotniydQvvSwMPeer9qyChg@mail.gmail.com> (raw)
In-Reply-To: <CAJFAV8zw-5Svs6MnrHiMey3fOa9MpPAOtwLeqZRniAWk--NrYw@mail.gmail.com>
On Thu, Mar 19, 2020 at 1:41 PM David Marchand
<david.marchand@redhat.com> wrote:
>
> On Mon, Mar 16, 2020 at 8:08 PM David Christensen
> <drc@linux.vnet.ibm.com> wrote:
> > On 3/16/20 10:49 AM, David Christensen wrote:
> > >
> > >> The rte_pci.h file includes more header files than are actually needed,
> > >> which means that all users of it also include those headers. This patch
> > >> removes the unneeded headers - adding them elsewhere where other
> > >> components
> > >> were requiring them but not including them directly.
> > >>
> > >> Fixes: c752998b5e2e ("pci: introduce library and driver")
> > >> Cc: gaetan.rivet@6wind.com
> > >> Cc: stable@dpdk.org
> > >>
> > >> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> > >
> > > Patch is generating build errors with meson on my POWER system, though I
> > > don't see how they're POWER specific:
> >
> > There's a pending patch to enable Travis for POWER systems:
> >
> > http://patches.dpdk.org/patch/65986/
> >
> > Any reason it hasn't been accepted yet? Looks like it would have caught
> > this problem.
>
> The reason is that this series has a change in the IOVA detection code.
> I have a lot of things to look at, so any help in reviews is appreciated.
Reviewed...
>
>
> --
> David Marchand
>
prev parent reply other threads:[~2020-03-20 13:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-16 11:29 Bruce Richardson
2020-03-16 14:30 ` Thomas Monjalon
2020-03-16 17:49 ` David Christensen
2020-03-16 19:07 ` David Christensen
2020-03-19 8:10 ` David Marchand
2020-03-20 13:25 ` Jerin Jacob [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALBAE1PyYQMyD1amMXnN8ypSq2=UotniydQvvSwMPeer9qyChg@mail.gmail.com' \
--to=jerinjacobk@gmail.com \
--cc=anatoly.burakov@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=drc@linux.vnet.ibm.com \
--cc=jerinj@marvell.com \
--cc=wilder@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).