From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 382ADA0583; Fri, 20 Mar 2020 14:26:06 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 102412BB9; Fri, 20 Mar 2020 14:26:06 +0100 (CET) Received: from mail-io1-f65.google.com (mail-io1-f65.google.com [209.85.166.65]) by dpdk.org (Postfix) with ESMTP id 84661F94 for ; Fri, 20 Mar 2020 14:26:04 +0100 (CET) Received: by mail-io1-f65.google.com with SMTP id h18so5890226ioh.7 for ; Fri, 20 Mar 2020 06:26:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=gFzvwW1RyALzky4f/mU7Q8CnggZs9StWcwJCc8ObIv4=; b=WwG6wvbZ4l4X0SOAVwGnATNN8g5VK6bj8IOvC7E1ueT55cNSJzW/+SezeayA1JMozA ZT/B7HQxL3tSLyXapr6ZG5H2bo7c8DTnNOtt2r0gL0AVhcr2Ojt9DPWTWU0d5tnNK4FH UcAbGKX/LH7TEzdDDf3YCNOBmya1U5nabd1CoiF75EvkWH6oCC/8rva4zPuNg3pTZ/TA VuIiHvF+j8YAYWr5YoIjmC0Q04hvsy63Y+a9yBJiXOAM+8a3G2AbEom5n2wIz6cj7eg3 kbnYF+1bN5lWkz1HytKKOgPNJX3IveZSH1iTrQqYwUaEyC348b9HUDfY7m98bAeZKAoH z3hg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=gFzvwW1RyALzky4f/mU7Q8CnggZs9StWcwJCc8ObIv4=; b=kE0rw5En07O1ptAn86ddR2Dw3oMJg1L9j0ss8wJ0A4Yr5pzgKeQaJMGzZ1Wo1DGQsM L/XA3EYQwEcm7IVaj7togQEbCRBuX7Mcfpbs89TyEVQMR0NCZq/A1WeLycmHzKLku9xB KL2Trp2zEAMo6cCMeevmhjVm8D/qB7lEX0kZxIwhsfJWst+LFOziV1cUeOzCNuwq3XIP EHrrYIJR8VDg5qJgqfpofL70U6Ok4qRj8pKD8wQXNIN+Uya9uyyn5/EkX1s8cUKjKHGo sZ5MRQtmDx4P3j7I/93GrgAQe3PDHl6L1otzvXmsZ23cYAsGvNgZntNCEs50lgl23Pqj im1Q== X-Gm-Message-State: ANhLgQ0j1/eBAcKxLph4GFsinhQCATk1TLj0bj+dC+h6lZNAFKHN+s9i u1nx4j1wQwVYWFuSSW9bY4p8Vy+ENA94HelnKgM97aKYDY4= X-Google-Smtp-Source: ADFU+vv/DYmsQNnv0pbDXgIziHIcsa9IeqgPG0W4BqEIZtTsPwI1B2SN7dVY/jXrcsiFvA69tccPU16RuXRYDlfb1VE= X-Received: by 2002:a6b:ef02:: with SMTP id k2mr2159065ioh.59.1584710763778; Fri, 20 Mar 2020 06:26:03 -0700 (PDT) MIME-Version: 1.0 References: <20200316112951.35428-1-bruce.richardson@intel.com> <7bb3246f-2331-0cd0-d589-19324787fb16@linux.vnet.ibm.com> In-Reply-To: From: Jerin Jacob Date: Fri, 20 Mar 2020 18:55:47 +0530 Message-ID: To: David Marchand Cc: David Christensen , dev , David Wilder , "Burakov, Anatoly" , Jerin Jacob Kollanukkaran Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] pci: fix unneeded includes in public header file X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Mar 19, 2020 at 1:41 PM David Marchand wrote: > > On Mon, Mar 16, 2020 at 8:08 PM David Christensen > wrote: > > On 3/16/20 10:49 AM, David Christensen wrote: > > > > > >> The rte_pci.h file includes more header files than are actually needed, > > >> which means that all users of it also include those headers. This patch > > >> removes the unneeded headers - adding them elsewhere where other > > >> components > > >> were requiring them but not including them directly. > > >> > > >> Fixes: c752998b5e2e ("pci: introduce library and driver") > > >> Cc: gaetan.rivet@6wind.com > > >> Cc: stable@dpdk.org > > >> > > >> Signed-off-by: Bruce Richardson > > > > > > Patch is generating build errors with meson on my POWER system, though I > > > don't see how they're POWER specific: > > > > There's a pending patch to enable Travis for POWER systems: > > > > http://patches.dpdk.org/patch/65986/ > > > > Any reason it hasn't been accepted yet? Looks like it would have caught > > this problem. > > The reason is that this series has a change in the IOVA detection code. > I have a lot of things to look at, so any help in reviews is appreciated. Reviewed... > > > -- > David Marchand >