From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6903AA04DD; Fri, 20 Nov 2020 13:27:14 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 49C55C8DC; Fri, 20 Nov 2020 13:27:13 +0100 (CET) Received: from mail-io1-f66.google.com (mail-io1-f66.google.com [209.85.166.66]) by dpdk.org (Postfix) with ESMTP id 720FDC8B6 for ; Fri, 20 Nov 2020 13:27:10 +0100 (CET) Received: by mail-io1-f66.google.com with SMTP id o11so9689319ioo.11 for ; Fri, 20 Nov 2020 04:27:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=F/P+vF8c/nRhklfRmulA4BGzLTq4Aej4tkaAFZKHWs4=; b=LJ9m+iRzutp2FElHdBuvx4IrRtr2s8KY8pklnkIwUW9BNbdylM/vdn8Exxo9+9pQ8X Tu0Nl+3AA/YP5i6EBjkRkXbDBiwzhqRNiaUBA/G6RhqPfQmoQ0IAQV7PMGoHfYAZZmCW ReulOMdBfLFygSKGBwsuMOvzE9JPUfqsbMywZXmPVazHO7Rt5XMg86fgCqkxveFinCna hy0m5ExsWqIYM2a8oYuiD2GGVChoqcJ+kWNQNY0OaheOWtsyuUbtGAS33ehf6RMXgz1t NALMAZEAUcLh3Dz8vfkgjamsgLzpLhK3IvOC9vgT3fo8OdeiYE+yVe4H4cuzKszmSNGq lTUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=F/P+vF8c/nRhklfRmulA4BGzLTq4Aej4tkaAFZKHWs4=; b=P05ZkbjyvLDcsuTIx0thuf+giSsnIxslthTt9XDz3B//9b19frUPM+xz6gc006jKO9 tJAR7L/dwR28wSw8ceXstxVvDnL1365VV2SdnrFdZoCjXa4X1ENOtBRxW2tIZLadigTF eGYAAHvIzDklYy2T/fHplra9BwPBbpV7b484KLiux7Dz8mHbbzrnqwGXnP2bIk7qbUtS ZvsCnjG13Zo1t+RXBiaaOxz/7oAF/4qAD37B14jbpWYQ9uGqeyG0dOWRJr1IEOyEQF6I nMgIi0D24qp7ajZTE8i50qMZ1loHmNdinUehhpjm5D4la6FV1T7rnrs+0q2xHRcKgFJh Misw== X-Gm-Message-State: AOAM532TFhtBpCZ1XL5AXhlM0cLvzk4PBv/2cEpPkdHz0cprS2egN4gQ tUr62cGeBy7D7L8OuSOMR2TjoF8AdfyOlkNR7hM= X-Google-Smtp-Source: ABdhPJy3MI3IgJ/Zp7Hlo4KILrg9OmTyS2ChJIfRK+7mHASJfoTldobHOW28cvDn/Q5Bg0Rqa5xPu0GNpVDcTkqjluo= X-Received: by 2002:a02:ac09:: with SMTP id a9mr19267746jao.60.1605875228857; Fri, 20 Nov 2020 04:27:08 -0800 (PST) MIME-Version: 1.0 References: <20201119122336.5079-1-pbhagavatula@marvell.com> <20201119135736.4085-1-pbhagavatula@marvell.com> <20201119135736.4085-2-pbhagavatula@marvell.com> In-Reply-To: <20201119135736.4085-2-pbhagavatula@marvell.com> From: Jerin Jacob Date: Fri, 20 Nov 2020 17:56:52 +0530 Message-ID: To: Pavan Nikhilesh Cc: Jerin Jacob , dpdk-dev Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v2 2/2] event/octeontx: remove selftest from dev args X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Nov 19, 2020 at 7:28 PM wrote: > > From: Pavan Nikhilesh > > Since selftest now depends on dynamic mbuf fields it is not > feasible to run selftest on device probe. > > Signed-off-by: Pavan Nikhilesh Series applied to dpdk-next-eventdev/for-main. Thanks. > --- > doc/guides/eventdevs/octeontx.rst | 12 ------------ > drivers/event/octeontx/ssovf_evdev.c | 22 ++++------------------ > drivers/event/octeontx/ssovf_evdev.h | 2 -- > 3 files changed, 4 insertions(+), 32 deletions(-) > > diff --git a/doc/guides/eventdevs/octeontx.rst b/doc/guides/eventdevs/octeontx.rst > index 79cae9f7d..435e1e953 100644 > --- a/doc/guides/eventdevs/octeontx.rst > +++ b/doc/guides/eventdevs/octeontx.rst > @@ -63,18 +63,6 @@ Example: > ./your_eventdev_application --vdev="event_octeontx" > > > -Selftest > --------- > - > -The functionality of OCTEON TX eventdev can be verified using this option, > -various unit and functional tests are run to verify the sanity. > -The tests are run once the vdev creation is successfully complete. > - > -.. code-block:: console > - > - --vdev="event_octeontx,selftest=1" > - > - > Enable TIMvf stats > ------------------ > TIMvf stats can be enabled by using this option, by default the stats are > diff --git a/drivers/event/octeontx/ssovf_evdev.c b/drivers/event/octeontx/ssovf_evdev.c > index 6f242aac1..e60a7dc69 100644 > --- a/drivers/event/octeontx/ssovf_evdev.c > +++ b/drivers/event/octeontx/ssovf_evdev.c > @@ -710,8 +710,7 @@ ssovf_close(struct rte_eventdev *dev) > } > > static int > -ssovf_selftest(const char *key __rte_unused, const char *value, > - void *opaque) > +ssovf_parsekv(const char *key __rte_unused, const char *value, void *opaque) > { > int *flag = opaque; > *flag = !!atoi(value); > @@ -775,10 +774,8 @@ ssovf_vdev_probe(struct rte_vdev_device *vdev) > const char *name; > const char *params; > int ret; > - int selftest = 0; > > static const char *const args[] = { > - SSOVF_SELFTEST_ARG, > TIMVF_ENABLE_STATS_ARG, > NULL > }; > @@ -799,18 +796,9 @@ ssovf_vdev_probe(struct rte_vdev_device *vdev) > "Ignoring unsupported params supplied '%s'", > name); > } else { > - int ret = rte_kvargs_process(kvlist, > - SSOVF_SELFTEST_ARG, > - ssovf_selftest, &selftest); > - if (ret != 0) { > - ssovf_log_err("%s: Error in selftest", name); > - rte_kvargs_free(kvlist); > - return ret; > - } > - > - ret = rte_kvargs_process(kvlist, > - TIMVF_ENABLE_STATS_ARG, > - ssovf_selftest, &timvf_enable_stats); > + ret = rte_kvargs_process(kvlist, TIMVF_ENABLE_STATS_ARG, > + ssovf_parsekv, > + &timvf_enable_stats); > if (ret != 0) { > ssovf_log_err("%s: Error in timvf stats", name); > rte_kvargs_free(kvlist); > @@ -877,8 +865,6 @@ ssovf_vdev_probe(struct rte_vdev_device *vdev) > edev->max_event_ports); > > ssovf_init_once = 1; > - if (selftest) > - test_eventdev_octeontx(); > return 0; > > error: > diff --git a/drivers/event/octeontx/ssovf_evdev.h b/drivers/event/octeontx/ssovf_evdev.h > index 90d760a54..10163151c 100644 > --- a/drivers/event/octeontx/ssovf_evdev.h > +++ b/drivers/event/octeontx/ssovf_evdev.h > @@ -86,8 +86,6 @@ > #define SSO_GRP_GET_PRIORITY 0x7 > #define SSO_GRP_SET_PRIORITY 0x8 > > -#define SSOVF_SELFTEST_ARG ("selftest") > - > /* > * In Cavium OCTEON TX SoC, all accesses to the device registers are > * implictly strongly ordered. So, The relaxed version of IO operation is > -- > 2.17.1 >