From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 39D62A3160 for ; Fri, 11 Oct 2019 13:45:51 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D765B1EA5D; Fri, 11 Oct 2019 13:45:49 +0200 (CEST) Received: from mail-io1-f68.google.com (mail-io1-f68.google.com [209.85.166.68]) by dpdk.org (Postfix) with ESMTP id 997781E9DE for ; Fri, 11 Oct 2019 13:45:48 +0200 (CEST) Received: by mail-io1-f68.google.com with SMTP id u8so20826054iom.5 for ; Fri, 11 Oct 2019 04:45:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=OxUjlRqcBWzmOt24J8T27IP2CwjPJm0gjuLR+Clqxs0=; b=liBSYpG9xOoDpzXHstnyABHcBUfxdE4fXVUQtqH9cXOf33CI0+iB/I/ivHO00fT4O6 Db3kzk7v79Tqnp/lSEJf/ObA3gNc9qzElpVpOoGz4oCrb0pd+hegrmjnjtmw0GXRCpMi 6vPfSaOIoawuiYHd7hVbbZRvnsn8CZtvE+JxVeWIar3NzEbD9rtnTGqlqre0cUhxc7OG h6Q8XJDT4h9MIA2QkALFJjadbtH3viRc6VzamLFqtPUXHBbGTrwV7DihscN3GVsijIS+ ifTGkNvsUVlakWa/kNKqFyqXnTWk7O7EFlH1/fohISO8iN7ukdEAbwA1wR2teQRf7OuY XzhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=OxUjlRqcBWzmOt24J8T27IP2CwjPJm0gjuLR+Clqxs0=; b=kc7i6tIwf6ewRlCY1b6/Jo9qscOyJp18Ec/mIjjdrqKxnvmo0e3vBLJtWULY3+yxWW sEeErPBYzG0GRjBYy8Eh++ODEkktvtnaKDRYbIAa2WdF6/FqaUXWCcjl6VJinuxwyowt HmLVBWL+MeX4UOBiDPaGZAgCjy5FvooNUTSKZ43TF0RW6pQTv0oWBPSVCUPZFpZa1Ozb imdynxs0o8ZzGPCjMaQJ9MApf9f0YHW6Z51e9RLnXbEudTMFNoDd74ZwsX/VxfCVMEF7 1YG4DAGLlDgEFFQKDpDZ7kCxfZG516Go93xZECTWqAOCLLvoeMx3oT/bLi9qxW3dkQNB 8VEA== X-Gm-Message-State: APjAAAUDPameF6n8lGrg10UbqEe3C0xJrqY0oM7I9r1e9YIMr+adNf0F WH6aOTJyYQY+jYqzrbqZFiGaGMPB0LlMpLyHyCM= X-Google-Smtp-Source: APXvYqyQ7JnjvWtY31LCjXXYZ/cku2kV5MMy3cqla8AV4TW7XHeAFIPIkKlOsZ76o6ZKkpFOeJPmyvpdIz22D6H8zZc= X-Received: by 2002:a05:6638:a1b:: with SMTP id 27mr13524108jan.102.1570794347536; Fri, 11 Oct 2019 04:45:47 -0700 (PDT) MIME-Version: 1.0 References: <20190916034242.593-1-jerryhao@os.amperecomputing.com> <1570589086-25430-1-git-send-email-gavin.hu@arm.com> In-Reply-To: <1570589086-25430-1-git-send-email-gavin.hu@arm.com> From: Jerin Jacob Date: Fri, 11 Oct 2019 17:15:36 +0530 Message-ID: To: Gavin Hu Cc: dpdk-dev , nd , Jerry Hao OS , Thomas Monjalon , Honnappa Nagarahalli Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v3] build: add emag(arm64) platform and default config X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Oct 9, 2019 at 8:15 AM Gavin Hu wrote: > > From: Jerry Hao OS > I think the subject can be changed to "build: add emag target " > config: add emag configuration > mk/machine: add emag machine configurations The above lines are not a sentence. Please make it as a sentence in the git commit. > > eMAG is Ampere Computing 64-bit ARM processor > with 32 Arm v8 64-bit CPU cores. > For more information, refer to: > https://amperecomputing.com/product/ > > Signed-off-by: Jerry Hao OS > Signed-off-by: Gavin Hu With the above changes: Acked-by: Jerin Jacob > --- > V3: > - add "mtune=emag" to generate optimized code for emag > V2: > - add meson build support > > config/arm/arm64_emag_linux_gcc | 15 +++++++++++++++ > config/arm/meson.build | 11 ++++++++++- > config/defconfig_arm64-emag-linux-gcc | 1 + > config/defconfig_arm64-emag-linuxapp-gcc | 11 +++++++++++ > mk/machine/emag/rte.vars.mk | 32 ++++++++++++++++++++++++++++++++ > 5 files changed, 69 insertions(+), 1 deletion(-) > create mode 100644 config/arm/arm64_emag_linux_gcc > create mode 120000 config/defconfig_arm64-emag-linux-gcc > create mode 100644 config/defconfig_arm64-emag-linuxapp-gcc > create mode 100644 mk/machine/emag/rte.vars.mk > > diff --git a/config/arm/arm64_emag_linux_gcc b/config/arm/arm64_emag_linux_gcc > new file mode 100644 > index 0000000..bcb147a > --- /dev/null > +++ b/config/arm/arm64_emag_linux_gcc > @@ -0,0 +1,15 @@ > +[binaries] > +c = 'aarch64-linux-gnu-gcc' > +cpp = 'aarch64-linux-gnu-cpp' > +ar = 'aarch64-linux-gnu-gcc-ar' > +strip = 'aarch64-linux-gnu-strip' > +pcap-config = '' > + > +[host_machine] > +system = 'linux' > +cpu_family = 'aarch64' > +cpu = 'armv8-a' > +endian = 'little' > + > +[properties] > +implementor_id = '0x50' > diff --git a/config/arm/meson.build b/config/arm/meson.build > index 979018e..aa73e1d 100644 > --- a/config/arm/meson.build > +++ b/config/arm/meson.build > @@ -61,6 +61,11 @@ flags_armada = [ > ['RTE_CACHE_LINE_SIZE', 64], > ['RTE_MAX_NUMA_NODES', 1], > ['RTE_MAX_LCORE', 16]] > +flags_emag = [ > + ['RTE_MACHINE', '"emag"'], > + ['RTE_CACHE_LINE_SIZE', 64], > + ['RTE_MAX_NUMA_NODES', 1], > + ['RTE_MAX_LCORE', 32]] > > flags_default_extra = [] > flags_thunderx_extra = [ > @@ -98,6 +103,10 @@ machine_args_cavium = [ > ['0xaf', ['-march=armv8.1-a+crc+crypto','-mcpu=thunderx2t99'], flags_thunderx2_extra], > ['0xb2', ['-mcpu=octeontx2'], flags_octeontx2_extra]] > > +machine_args_emag = [ > + ['default', ['-march=armv8-a+crc+crypto', '-mtune=emag']], > + ['native', ['-march=native']]] > + > ## Arm implementer ID (ARM DDI 0487C.a, Section G7.2.106, Page G7-5321) > impl_generic = ['Generic armv8', flags_generic, machine_args_generic] > impl_0x41 = ['Arm', flags_arm, machine_args_generic] > @@ -107,7 +116,7 @@ impl_0x44 = ['DEC', flags_generic, machine_args_generic] > impl_0x49 = ['Infineon', flags_generic, machine_args_generic] > impl_0x4d = ['Motorola', flags_generic, machine_args_generic] > impl_0x4e = ['NVIDIA', flags_generic, machine_args_generic] > -impl_0x50 = ['AppliedMicro', flags_generic, machine_args_generic] > +impl_0x50 = ['Ampere Computing', flags_emag, machine_args_emag] > impl_0x51 = ['Qualcomm', flags_generic, machine_args_generic] > impl_0x53 = ['Samsung', flags_generic, machine_args_generic] > impl_0x56 = ['Marvell ARMADA', flags_armada, machine_args_generic] > diff --git a/config/defconfig_arm64-emag-linux-gcc b/config/defconfig_arm64-emag-linux-gcc > new file mode 120000 > index 0000000..21894a3 > --- /dev/null > +++ b/config/defconfig_arm64-emag-linux-gcc > @@ -0,0 +1 @@ > +defconfig_arm64-emag-linuxapp-gcc > \ No newline at end of file > diff --git a/config/defconfig_arm64-emag-linuxapp-gcc b/config/defconfig_arm64-emag-linuxapp-gcc > new file mode 100644 > index 0000000..1db654c > --- /dev/null > +++ b/config/defconfig_arm64-emag-linuxapp-gcc > @@ -0,0 +1,11 @@ > +# SPDX-License-Identifier: BSD-3-Clause > +# Copyright(c) 2019 Ampere Computing > +# > + > +#include "defconfig_arm64-armv8a-linux-gcc" > + > +CONFIG_RTE_MACHINE="emag" > + > +CONFIG_RTE_CACHE_LINE_SIZE=64 > +CONFIG_RTE_MAX_NUMA_NODES=1 > +CONFIG_RTE_MAX_LCORE=32 > diff --git a/mk/machine/emag/rte.vars.mk b/mk/machine/emag/rte.vars.mk > new file mode 100644 > index 0000000..50342df > --- /dev/null > +++ b/mk/machine/emag/rte.vars.mk > @@ -0,0 +1,32 @@ > +# SPDX-License-Identifier: BSD-3-Clause > +# Copyright(c) 2019 Ampere Computing > +# > + > +# > +# machine: > +# > +# - can define ARCH variable (overridden by cmdline value) > +# - can define CROSS variable (overridden by cmdline value) > +# - define MACHINE_CFLAGS variable (overridden by cmdline value) > +# - define MACHINE_LDFLAGS variable (overridden by cmdline value) > +# - define MACHINE_ASFLAGS variable (overridden by cmdline value) > +# - can define CPU_CFLAGS variable (overridden by cmdline value) that > +# overrides the one defined in arch. > +# - can define CPU_LDFLAGS variable (overridden by cmdline value) that > +# overrides the one defined in arch. > +# - can define CPU_ASFLAGS variable (overridden by cmdline value) that > +# overrides the one defined in arch. > +# - may override any previously defined variable > +# > + > +# ARCH = > +# CROSS = > +# MACHINE_CFLAGS = > +# MACHINE_LDFLAGS = > +# MACHINE_ASFLAGS = > +# CPU_CFLAGS = > +# CPU_LDFLAGS = > +# CPU_ASFLAGS = > + > +MACHINE_CFLAGS += -march=armv8-a+crc+crypto > +MACHINE_CFLAGS += $(call rte_cc_has_argument, -mtune=emag) > -- > 2.7.4 >