From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A6D234317F; Mon, 16 Oct 2023 17:48:27 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4875D402DA; Mon, 16 Oct 2023 17:48:27 +0200 (CEST) Received: from mail-vk1-f174.google.com (mail-vk1-f174.google.com [209.85.221.174]) by mails.dpdk.org (Postfix) with ESMTP id 7726840269 for ; Mon, 16 Oct 2023 17:48:25 +0200 (CEST) Received: by mail-vk1-f174.google.com with SMTP id 71dfb90a1353d-4a06fb5331bso1852388e0c.0 for ; Mon, 16 Oct 2023 08:48:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697471304; x=1698076104; darn=dpdk.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Bz84UjdZEwLq7Ak6wQpYsd9NWbonqXNJdl7weF+MArs=; b=gOW72z7vfTNMdUzOchWz6B7R3PkuTDfx3ZqJgcEP+bBZVcMDSPXLe0x6VuE4OUmoiD DSwH7A/Uw1WJmPSWEwNWEJo3uV4ei0tsAmZIp8vdKz3S7HAS0aDUjuu63PJnFnESGl/n pWDbOyP2H41b8+Z1oFv01ukf3GPkI2CFX0VCeT2UYFnZ7C3005q3p4tcT5RUT9BRRtjf iYh/OSf8u5TWbii64YWQiBDBmHcs7lPFk7kUOp6WGVWS0U1alXBQrS7scfUooCCQu9uJ F2ZhLtCw9D4HkjyGKJZb7qdvjYkqPG765AiLZGho7zYYzEJrrlGeBcGJjlBO0SlsbipH PwHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697471304; x=1698076104; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Bz84UjdZEwLq7Ak6wQpYsd9NWbonqXNJdl7weF+MArs=; b=PxKkCt+5Zi+1BQl1HX+v4Dc+SvS2RrfquTIp9iArvkTuT6RowdYsGqlOiNhKzqkRWa J5U0uxw2Zgyk9D+cBhCpdlFPPxCL3XUdrUHaOsR0znom9eMhDWjGnKXXMyvtCBbTr27/ /W7OxtaPSYMT8p0PgVuGE48GOritns+4JeVs1BahR1EShclFYhqwxO28JHceehL9+FY6 QKebxfqkRlDbbWjyB3mueCcNDmw10fa81WHKNpQKpj/ojYX0hZJkoSNb1Cf+g8Fl1HdI uFXBzI9+w5rjGi8+qvXteGZfQFJ9Qpa0AzdGqM8LsPAtlyQWBySNKdV2f/ZN5+nqQ8h6 FRWA== X-Gm-Message-State: AOJu0YyZ6m2K5Gl8vA+1TADVTphd5C/NNnp7LuQ1ZA/Kx9bsv6GRd87W cQ9dAwGmoyVBZB3GePp3IpX+qO4YqCjZyi5i8JQ= X-Google-Smtp-Source: AGHT+IHB7rRD8Bb5xFwxjAKLzXCdzithlxnTViXyGXmHhj5JQLtObif1eKSLgHX0iHl+9LvFD2PrRzar81BlyOoR9bo= X-Received: by 2002:a1f:ddc2:0:b0:49a:36e4:5565 with SMTP id u185-20020a1fddc2000000b0049a36e45565mr26876812vkg.16.1697471304163; Mon, 16 Oct 2023 08:48:24 -0700 (PDT) MIME-Version: 1.0 References: <20230927115412.55018-13-skori@marvell.com> <20230929095814.692890-1-skori@marvell.com> <20230929095814.692890-7-skori@marvell.com> In-Reply-To: <20230929095814.692890-7-skori@marvell.com> From: Jerin Jacob Date: Mon, 16 Oct 2023 21:17:57 +0530 Message-ID: Subject: Re: [PATCH v8 06/12] app/graph: add ipv4_lookup command line interfaces To: skori@marvell.com Cc: Rakesh Kudurumalla , dev@dpdk.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Sep 29, 2023 at 8:16=E2=80=AFPM wrote: > > From: Sunil Kumar Kori > > It adds ipv4_lookup module to configure LPM table. This LPM table > will be used for IPv4 lookup and forwarding. > > Following commands are exposed: > - ipv4_lookup route add ipv4 netmask via > - help ipv4_lookup > > Signed-off-by: Sunil Kumar Kori > Signed-off-by: Rakesh Kudurumalla > --- > app/graph/cli.c | 2 + > app/graph/ethdev.c | 2 +- > app/graph/ip4_route.c | 221 +++++++++++++++++++++++++++++++++++++ > app/graph/meson.build | 1 + > app/graph/module_api.h | 1 + > app/graph/route.h | 26 +++++ > app/graph/route_priv.h | 44 ++++++++ > doc/guides/tools/graph.rst | 9 ++ > 8 files changed, 305 insertions(+), 1 deletion(-) > create mode 100644 app/graph/ip4_route.c > create mode 100644 app/graph/route.h > create mode 100644 app/graph/route_priv.h > > diff --git a/app/graph/cli.c b/app/graph/cli.c > index c4b5cf3ce1..430750db6e 100644 > --- a/app/graph/cli.c > +++ b/app/graph/cli.c > @@ -30,6 +30,8 @@ cmdline_parse_ctx_t modules_ctx[] =3D { > (cmdline_parse_inst_t *)ðdev_ip6_cmd_ctx, > (cmdline_parse_inst_t *)ðdev_cmd_ctx, > (cmdline_parse_inst_t *)ðdev_help_cmd_ctx, > + (cmdline_parse_inst_t *)&ipv4_lookup_cmd_ctx, > + (cmdline_parse_inst_t *)&ipv4_lookup_help_cmd_ctx, > NULL, > }; > > diff --git a/app/graph/ethdev.c b/app/graph/ethdev.c > index 74e80679d9..4d2bc73e7c 100644 > --- a/app/graph/ethdev.c > +++ b/app/graph/ethdev.c > @@ -160,7 +160,7 @@ ethdev_stop(void) > } > > ethdev_list_clean(); > - rte_eal_cleanup(); Looks like by mistake it is removed in this patch. > + route_ip4_list_clean(); > printf("Bye...\n"); > }