From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C2D7AA04FF; Tue, 17 May 2022 12:05:22 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 64BCB40042; Tue, 17 May 2022 12:05:22 +0200 (CEST) Received: from mail-io1-f45.google.com (mail-io1-f45.google.com [209.85.166.45]) by mails.dpdk.org (Postfix) with ESMTP id 44ADB40041 for ; Tue, 17 May 2022 12:05:21 +0200 (CEST) Received: by mail-io1-f45.google.com with SMTP id m6so18710914iob.4 for ; Tue, 17 May 2022 03:05:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=WQmRrPF+ClQGAyb6GWUOfLYdTdPlMg3Ln0Y11/oeL9Y=; b=jCjKn0FnoWyp3cD96+4+1moejuRKg8Di4B5aW3PhdSRs5ddY93AwJeGUyB6lIvvWbJ MYiMwOAG1Vu9oPIxwko33bAnix1dPOBeF0c9yWTzW5YU95RNlNZlVAde7bqd6z+rEd4f BJLQLju4pn0kwZ9lBp0QkchFH66DnI5SSwZS6AhI0bzSW3CfVJSN01XfLHG8u7/t4yqS qTSc0xE2VckVncyZng0Em4/GdvA35nQp/+tKN4VJMMJUtH5mycoRJqcK+XTvxWowSJ4Y odhmK3xrj5WvjGCu+lcT4/WmR1DaGd4abxtmZnL7uNca5j+szgzRI2sbLWJqEGJIZJYz sSUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=WQmRrPF+ClQGAyb6GWUOfLYdTdPlMg3Ln0Y11/oeL9Y=; b=aIOPclavvzuYh7XYZsQFYv+F7KKZdBQe8Av4SauhNJLKQxHjrQBlfwiwTlbBY50ill 9n0MImLx+Fd/sA099SAO8W3l0RR/krt+V3gksSJUu9Iw+Rv2kwBBr3KTFMbZM5cLbFLd 3VEQNanHpZhfwJNmogvodPszaZx+lhlmO6a8CkM+BcuwGhbPQh+skCOjZ7SJZ5Zkp2sN Qho4efI2dKeEif84wFX5qlvGTGgYwp/Pii4ScOwO4ndEXEuS98SXlzRqCNuj0JncoAdJ EvmDpRyH57IAbYa2o3wjtZSIjSAIWBbHLgHKDumMtmyhZcSXeU8MRJpy/Ic/TvbvW+Hh xl3Q== X-Gm-Message-State: AOAM532QBj/BT3CAGzIOkyPyPvoHsltowURlZM2mwACQOUGkWHnEc1Jo uMktvvXdhUMGp4YfVjPm5m+phtPth9Zdw41MoAc= X-Google-Smtp-Source: ABdhPJzgPFAeG7nF6h4Is8gIRSTV78y3NCUCskV9a3cat9U+xjMPvcA1nHab6j7X+VqLd+EpRbTjCluxYVvHwCGCFTg= X-Received: by 2002:a02:c898:0:b0:32e:120b:cdf9 with SMTP id m24-20020a02c898000000b0032e120bcdf9mr7870770jao.158.1652781920489; Tue, 17 May 2022 03:05:20 -0700 (PDT) MIME-Version: 1.0 References: <20220427113715.15509-1-pbhagavatula@marvell.com> <20220513175841.11853-1-pbhagavatula@marvell.com> In-Reply-To: <20220513175841.11853-1-pbhagavatula@marvell.com> From: Jerin Jacob Date: Tue, 17 May 2022 15:34:54 +0530 Message-ID: Subject: Re: [PATCH v3 1/3] eventdev: add function to quiesce an event port To: Pavan Nikhilesh Cc: Jerin Jacob , Ray Kinsella , dpdk-dev , "Jayatheerthan, Jay" , Erik Gabriel Carrillo , "Gujjar, Abhinandan S" , "McDaniel, Timothy" , Shijith Thotton , Hemant Agrawal , Nipun Gupta , "Van Haaren, Harry" , =?UTF-8?Q?Mattias_R=C3=B6nnblom?= , Liang Ma , Peter Mccarthy Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, May 13, 2022 at 11:31 PM wrote: > > From: Pavan Nikhilesh > > Add function to quiesce any core specific resources consumed by > the event port. > > When the application decides to migrate the event port to another lcore > or teardown the current lcore it may to call `rte_event_port_quiesce` > to make sure that all the data associated with the event port are released > from the lcore, this might also include any prefetched events. > > While releasing the event port from the lcore, this function calls the > user-provided flush callback once per event. > > Signed-off-by: Pavan Nikhilesh > --- > v3 Changes: > - Add `rte_` prefix to callback function. > - Fix API documentation issues. > - Update eventdev documentation. > > v2 Changes: > - Remove internal Change-Id tag from commit messages. Changed git commit message heading as "eventdev: support to quiesce an event port" Also updated release notes and improved the documentation[1] Series-Acked-by: Jerin Jacob Series applied to dpdk-next-net-eventdev/for-main. Thanks [1] [for-main]dell[dpdk-next-eventdev] $ git diff diff --git a/doc/guides/prog_guide/eventdev.rst b/doc/guides/prog_guide/eventdev.rst index 973c9838ae..7a053de132 100644 --- a/doc/guides/prog_guide/eventdev.rst +++ b/doc/guides/prog_guide/eventdev.rst @@ -428,8 +428,7 @@ A flush callback can be passed to the function to handle any outstanding events. .. Note:: - The event port specific config shall not be reset when this API is - invoked. + Invocation of this API does not affect the existing port configuration. Summary ------- diff --git a/doc/guides/rel_notes/release_22_07.rst b/doc/guides/rel_notes/release_22_07.rst index 88d6e96cc1..7eae0b04f9 100644 --- a/doc/guides/rel_notes/release_22_07.rst +++ b/doc/guides/rel_notes/release_22_07.rst @@ -55,6 +55,12 @@ New Features Also, make sure to start the actual text at the margin. ======================================================= +* **Added API to quiesce an event port.** + + * Added ``rte_event_port_quiesce()`` to quiesce any lcore specific + resources consumed by the event port, when the lcore no more + associated with event port. + * **Updated Intel iavf driver.** * Added Tx QoS queue rate limitation support. diff --git a/lib/eventdev/rte_eventdev.h b/lib/eventdev/rte_eventdev.h index 1a46d289a9..80bfbf4293 100644 --- a/lib/eventdev/rte_eventdev.h +++ b/lib/eventdev/rte_eventdev.h @@ -849,8 +849,7 @@ typedef void (*rte_eventdev_port_flush_t)(uint8_t dev_id, * While releasing the event port from the lcore, this function calls the * user-provided flush callback once per event. * - * @note The event port specific config shall not be reset when this API is - * called. + * @note Invocation of this API does not affect the existing port configuration. * * @param dev_id * The identifier of the device.