From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AA92CA0C57; Sat, 14 Aug 2021 17:38:33 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 285C640696; Sat, 14 Aug 2021 17:38:33 +0200 (CEST) Received: from mail-lf1-f49.google.com (mail-lf1-f49.google.com [209.85.167.49]) by mails.dpdk.org (Postfix) with ESMTP id C40814068F for ; Sat, 14 Aug 2021 17:38:31 +0200 (CEST) Received: by mail-lf1-f49.google.com with SMTP id w20so25795842lfu.7 for ; Sat, 14 Aug 2021 08:38:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=1lqPJtyww+KzuYB0wqx00c/LKmXTE0kzfo0lK+oL/KA=; b=MEe/uiFPD25QGr2USEfYiDeVmYAN6Jc2sKSd0Lk9QdqmAL/O+BWU8B0YmJ+EqrtBQR YPf0CywrVGbutrjbsr/LFMVCvyNzPQPGhb5YBghVMOaZt9fPmUQ3A6MsbqUkh0WMypV5 v0nF1tQXOp+ZZDyPg3TaVWOE8KsYsSQWxNzvHYHf93Zb8LG4ICoMlb+CytNjDaf30/0h V3pPzasu5NPTbY22CIzfDeqo5+wt2AZvcdiPgdmMgKFdZ8EVaBBDIBuZVuohuD66I8yC wgHOYeEpzXbp5GA+woiLhuFQVH5QzFulOf4J/bPrsm038K6/l7Yfs7T5ncQ0ittKqd9h KIxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=1lqPJtyww+KzuYB0wqx00c/LKmXTE0kzfo0lK+oL/KA=; b=W7hfJkSQVGj7UE2m+d7gzMrM00inBDzWRHF/hMSim5ZG7fjPPt2Ee1t97ziucdMC6u VOmG4WiZRfNaEQMDbT9rQH7cpOYgdwL7BPdiHNReEwWG/6cBXFdM2+JAnk7W0A834V9Z 4sLtJ9aJ/7TCYGOITGbgR0kay9AfTeE9okFbL9X6UsfyhDTn1oXyuUu+3SWRNiYM9hzY NrnWmDIefEusYRzaXIod78VXkM2hzHRv/L7YHrraHFll8vmVc04svFBbJZZ4NIr0JMnT QKJE6kKkrP3wrQ5mdftdrDMvkNneyzLiAyTt685ZNTEBU2i3l5sq27ZT383f2bx7l5Lv mmzw== X-Gm-Message-State: AOAM530p5/s6gla7t7CuiWCB4+gIl5vl2S0ZuC1lQunaj25d184Xx3yt Duk6Ids2Gpfezf70SK1K4mhQmXyMj/dRLtbSQCk= X-Google-Smtp-Source: ABdhPJy+NNAKcXZr0Qm7/xtPpL+fFjCJoKKEvJ1Oz4oYLfdUtO02UDXNpMbFJPLe7hOeilpZPyx6HyWlkBo0TKdGkeE= X-Received: by 2002:ac2:5ddb:: with SMTP id x27mr5491050lfq.258.1628955511306; Sat, 14 Aug 2021 08:38:31 -0700 (PDT) MIME-Version: 1.0 References: <20210814033609.58553-1-u9012063@gmail.com> <20210814143108.128803ef@sovereign> In-Reply-To: <20210814143108.128803ef@sovereign> From: William Tu Date: Sat, 14 Aug 2021 08:37:55 -0700 Message-ID: To: Dmitry Kozlyuk Cc: dpdk-dev , Igor Chauskin , Evgeny Schemeilin , Shai Brandes , Michal Krawczyk , Marcin Wojtas , Narcisa Ana Maria Vasile Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH RFC] net/ena: Add Windows support. X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Sat, Aug 14, 2021 at 4:31 AM Dmitry Kozlyuk wrote: > > Hi William, > > 2021-08-14 03:36 (UTC+0000), William Tu: > > I don't have a physical Windows testbed so I want to see if I can > > get virtual nic working, in this case ENA driver on AWS. > > The patch passes build on Windows, but I haven't tested loading > > the ena driver. > > I want to know if this is the right direction, > > or whether I also need to change other places in ENA driver? > > Cc'ing maintainers. > > > I copy some of the pthread code from > > https://nachtimwald.com/2019/04/05/cross-platform-thread-wrapper/ > > We don't want to add more pthread shims, pthread.h in DPDK will go away. > Condition variable support should be added to the new threading API: > > http://inbox.dpdk.org/dev/1628017291-3756-1-git-send-email-navasile@linux.microsoft.com > > I suppose it can be done independently of the new threading API series. yes, I think so. > When copying code to DPDK from elsewhere, please adapt its style to DPDK > conventions (e.g. `RTE_UNUSED(foo)` instead if `(void)foo`) and mind the > license if big pieces are copied verbatim (this is not the case here). > > > https://stackoverflow.com/questions/10905892/equivalent-of-gettimeday-for-windows > > POSIX gettimeofday() should be replaced with standard C timespec_get(). > > > Thanks. > > > > Signed-off-by: William Tu > > --- > > drivers/net/ena/base/ena_com.c | 4 +- > > drivers/net/ena/base/ena_plat.h | 2 +- > > drivers/net/ena/base/ena_plat_dpdk.h | 14 +++- > > drivers/net/ena/meson.build | 5 -- > > lib/eal/version.map | 2 +- > > lib/eal/windows/include/pthread.h | 105 ++++++++++++++++++++++++++ > > lib/eal/windows/include/rte_windows.h | 1 + > > 7 files changed, 120 insertions(+), 13 deletions(-) > > This should be a series of two patches: > 1) adding condition variable wrappers to EAL; > 2) supporting net/ena for Windows. > Thanks Dmitry! Will work on v2. William William