From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B7383A0C43; Wed, 11 Aug 2021 17:19:01 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6C82C410EC; Wed, 11 Aug 2021 17:19:01 +0200 (CEST) Received: from mail-lf1-f54.google.com (mail-lf1-f54.google.com [209.85.167.54]) by mails.dpdk.org (Postfix) with ESMTP id 054CD40C35 for ; Wed, 11 Aug 2021 17:19:00 +0200 (CEST) Received: by mail-lf1-f54.google.com with SMTP id d4so6453342lfk.9 for ; Wed, 11 Aug 2021 08:18:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=+giKvHlX9GAR/9wkqcThvawaj3KdaGnIoE67FtCgiX4=; b=Idt+kt0PnY9688n9+lZcFR1PkzZa5euMhhoug55Q4U/AGTcZxvXZbrhED51Or4AFPi 1Ke1g2wh4vHThtgA1ldrwH2i1bF4S7nrLyvGUAbr9G0jqVVxnPXUtWFfyuxRC0UOH3O9 y8ralfbogrU/1IXzdPtVjM8gpWd3AUgLjx0Y8hKIxxvH2856N89w1oZF2zzZU70w3Yce FUoRWsE7Lw+6bxqqmt74sb0joWFVym5YqLezOhq/yYzpTB4zioHjxgZPKw/60V4mrQw7 oTfSTKLl46UV2w+/47eNUYkaWugPiEMcvooFmQiK1LOA010jXgXQqeEtwKfPYVzvrPTN q6/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=+giKvHlX9GAR/9wkqcThvawaj3KdaGnIoE67FtCgiX4=; b=pMy1K1moVT61fLN0hzgnk8vYR9AF/vcBHhvyJtL0kTkK7QUnRovmk5oRl3okNIIzoV h5jT2zy8ZiuOmAmXV+AVpIolAVqP1zOilUH+rirEbqLK/2kkhHYCI6y0blQknU+rNWWX p5GkcByclg9vdaDiCHzgsY+7TlrNPWHz/iF0CePWtV0rd3aKgCJSGMpEsCLTDDGkj4/0 h7moY3fl5/MWU4FPN6GY+yRl8Z1aK1Tbqmi7pgBKhBWi0B80Esr1d0k0myEvMHtcimIf P5rYPPiIOiOUZODA1xh4lTQ8CoGbrpM4ux0l4jiuc79XCUIKUeLChC/MEKbXilp9xC0T FtEQ== X-Gm-Message-State: AOAM530CoXurIkJyvUYELUkS1Dbvn+/6JFUkGwb+sF9GZfwxTo6gCMNF fftZ5j7eBClNxXbiEy01tuwA++HlzQ/YkmMSNUE= X-Google-Smtp-Source: ABdhPJxUFZ9YA6KtzjZb5kszpqbVmm12H1RZxrWxmNp0xwSa3dv9z/JJP5koCF7daaTAx17ZIwW1bWHDA1ncJPfQieE= X-Received: by 2002:a05:6512:1584:: with SMTP id bp4mr25061755lfb.504.1628695139535; Wed, 11 Aug 2021 08:18:59 -0700 (PDT) MIME-Version: 1.0 References: <20210805173345.1085-1-u9012063@gmail.com> <20210811013325.34c36220@sovereign> <8ffc3108-49e5-4763-ec46-029b6e39c5cd@mayadata.io> In-Reply-To: <8ffc3108-49e5-4763-ec46-029b6e39c5cd@mayadata.io> From: William Tu Date: Wed, 11 Aug 2021 08:18:23 -0700 Message-ID: To: Nick Connolly Cc: Dmitry Kozlyuk , dpdk-dev , Sergey Madaminov Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] eal/windows: add sys/queue.h. X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Aug 11, 2021 at 1:34 AM Nick Connolly wrote: > > > > What we can do: > > > > 1. Introduce `rte_queue.h` (name can be better) that is env-specific: > > > > 1.1. For Linux and FreeBSD it just includes > > and renames a few macros that are used in headers to RTE_xxx. > > 1.2. For Windows it defines the same RTE_xxx macros in a way > > compatible with the version used to build DPDK. > > > > 2. Add #include in : > > Linux and FreeBSD will include a system header, > > Windows will use the bundled one. > > > > This way application are not exposed to non-RTE symbols, > > at the same time RTE_xxx are binary-compatible with what DPDK > > implementation expects (and outside of Windows there is no change in fact). > > +1 > Nick Hi Nick and Dmitry, Thanks for such a detailed explanation! I sent the v2 patch, hopefully I understand you guys correctly. William