From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 77FB5A0C56; Wed, 1 Sep 2021 19:21:57 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5FE2F41173; Wed, 1 Sep 2021 19:21:57 +0200 (CEST) Received: from mail-lj1-f173.google.com (mail-lj1-f173.google.com [209.85.208.173]) by mails.dpdk.org (Postfix) with ESMTP id 58AAC4116C for ; Wed, 1 Sep 2021 19:21:56 +0200 (CEST) Received: by mail-lj1-f173.google.com with SMTP id h1so248869ljl.9 for ; Wed, 01 Sep 2021 10:21:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=tn7iwj4Svf/ZyaxS1w9vP+GZu/N08HL3NuA1DJjM9Ck=; b=d4XfecABTTJj0Nvhc20b6gzdRjNudGQxkEao0DmjJ/d6siUHSo8SiuywDFPRfQmTx/ MpzICY6CPkV5lUWN8AfK5h9wiHpihY7nPy+iY4VmCwVQPzkX6mJ+eW2Wi0IN9eFlukWg 9QLZ8PklVOqM9d9sHGB5bSjJlRffJRa4nnj+PHPQm81wtM5IGmlRbv8y13it8Hidx0Mw jM6QXwChL8/gheaI3Dpc9OY9jaxBu0dtHM7ngzwN3wPcuXolefGL24Dk+al9O3a48sSg YjNK6v9sRKT0YYVN6Rsk7PGrkyAohj7g+FKX8Ta07O6TBTA/67gdsMukb3O6wXLjNb/D j7Pg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=tn7iwj4Svf/ZyaxS1w9vP+GZu/N08HL3NuA1DJjM9Ck=; b=G++htoMWddn51UefHeocuHU3e8P9LIravvOXQbHwjTLkMuivItjTD1+YsV6DuCbVLz HeBaTo5xBSZECuLnVZSN8Q+kNKQzqpsrx1YVPdvLfIR0PME/7IfvyBbfCvGbg1ypc4qu 0kncgWpfyMHcFn/CqqpnPk8iotsSR+JUdQiuDnZtisv6mP7wedQtv4qrU8YS1OlHGQAV e5NOtiR0tRHfRK6i91DpemNAfCBoP6FmQxHM0JbQ5Qx3H5uqYF+xANcWe46+xJz2YTjE hpCyXaWgcpPkvyi/zsWwhGLG2AzY8AXYpaA8gYRhl2S+K+1UCCcVOTEvocAe3LnL+hry ATVw== X-Gm-Message-State: AOAM5314MwmyRRfhCS1OrHaxewTro/X20sc6CntXtG/SGEaGTS/UGTdM olIgX6STRBtttmO6dVa6S5kM4pRzsxLhw/l6akZhvG7MitDN/w== X-Google-Smtp-Source: ABdhPJzKI7k5l/8mhZJ0clNqMrkSZKTmlNAlIkTZf28J81oXs6kRK9YYYrF483+Yo0a6qtnMcNCKUZLvTwm3fa5TbFI= X-Received: by 2002:a2e:a224:: with SMTP id i4mr638355ljm.168.1630516916005; Wed, 01 Sep 2021 10:21:56 -0700 (PDT) MIME-Version: 1.0 References: <20210829021602.290466-1-dmitry.kozliuk@gmail.com> <20210829021602.290466-3-dmitry.kozliuk@gmail.com> In-Reply-To: <20210829021602.290466-3-dmitry.kozliuk@gmail.com> From: William Tu Date: Wed, 1 Sep 2021 10:21:19 -0700 Message-ID: To: Dmitry Kozlyuk Cc: dpdk-dev , Pallavi Kadam , jizh@linux.microsoft.com, "Richardson, Bruce" , Ray Kinsella , Ranjit Menon , Tal Shnaiderman Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH 2/2] eal/windows: fix export list X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Sat, Aug 28, 2021 at 7:16 PM Dmitry Kozlyuk wrote: > > * Version and randomness API were not added to .def file by mistake, > which is why they were later excluded from the export list. > * Device API stubs were added to EAL but not exported. > > Fixes: edd66d57d55c ("eal/windows: add random function") > Fixes: 3d2fcb0e0aec ("eal/windows: add device event stubs") > Fixes: 5b637a848195 ("eal: fix querying DPDK version at runtime") > Cc: pallavi.kadam@intel.com > Cc: jizh@linux.microsoft.com > Cc: bruce.richardson@intel.com > > Signed-off-by: Dmitry Kozlyuk > --- LGTM, thanks. Acked-by: William Tu