From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 04D6DA0C41; Sun, 10 Oct 2021 03:28:51 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 83EE540042; Sun, 10 Oct 2021 03:28:51 +0200 (CEST) Received: from mail-lf1-f51.google.com (mail-lf1-f51.google.com [209.85.167.51]) by mails.dpdk.org (Postfix) with ESMTP id AD6EE40040 for ; Sun, 10 Oct 2021 03:28:50 +0200 (CEST) Received: by mail-lf1-f51.google.com with SMTP id c16so1372660lfb.3 for ; Sat, 09 Oct 2021 18:28:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Czx6JhofMvaE9Ng5kLaPB+YN9QrUjCFGo8f1ZMzJ8xc=; b=gjMnDv31tUO/lH6pnpnXr2yWNqLVZAkC0P+AdOitH+IRG118OjR7ZWKPWmk2PA7wAy GfQyknrwgr0LaOkYgZ3UHVTpURrS6VhHY5fk0IB9RLBl7pIodIuhVSMAiB24Lom/ezmJ zVxOEDOfXhIW/ZPB37eoBucPSKMHPtpsvrXcG9npbfUUluHyncBqU1RdiULtfjox2Sht +F2V5UsrZ0KypVM8q98M7hH9vdcxMcjKoi6qCYDFAhxqcIgVZWUgu2hdqcqxQJNbHNwY 7LZzNZOGbXnW0xoJLbBRNK4gLA4x7s41dTFGTJCUSmakEYv8WQVaJeSGF+Wlxdo7Pp/F qAig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Czx6JhofMvaE9Ng5kLaPB+YN9QrUjCFGo8f1ZMzJ8xc=; b=Wv0AjE7KfSY6v3mbKImQ69KtKxYjSQf5In6mXsFQ0DWdBGcrqUj76SY3eHqi9CL9Cm djqGmcEUahL1/XyonTVtDw2UWYPm+0rZvhLFgHH2dwX0WT4JMILb105ZnEafDjvt8GV+ EhRq+dY0uMfFT+wfllk33+fB6ssHXXkrOlqzhxB71j0gEvBOBb/n2PkkYXO57Az/iQkx CXBI5XOk8g53AscjHZRLlC9asMoZLZ/yNQTJSx3A2O6KeDDuHfwHiUPHf0OqSCgGg1Js In9/baxxU4aMTLn4dYOmqci5a27apxFjW8WZjSkuI7Oi7XQOGXusTzFXvbojuybP2zwP zrqA== X-Gm-Message-State: AOAM5329wBheJvj7HVgvlBMJAdVufjZJ7YRfWjMKR8sePsQ8PVILdrAl DfvkZmI7ssS2MWKhIlqkrlyXM5h5T17nGMUwsYs= X-Google-Smtp-Source: ABdhPJzBlsNxM6qFaPCg0uPf0fTxCEkeOYxD/M7W5Pr74A1yv4odhb/AFxPdDEuU7eiyppoDj5bLm2MX5jHoyP6ZfXg= X-Received: by 2002:a2e:2d01:: with SMTP id t1mr12524271ljt.450.1633829330093; Sat, 09 Oct 2021 18:28:50 -0700 (PDT) MIME-Version: 1.0 References: <20211008211154.349793-1-dmitry.kozliuk@gmail.com> <7d8f6e0f-5a5a-54c8-22aa-151493dcd316@intel.com> <20211009232016.49f62460@sovereign> In-Reply-To: <20211009232016.49f62460@sovereign> From: William Tu Date: Sat, 9 Oct 2021 18:28:14 -0700 Message-ID: To: Dmitry Kozlyuk Cc: "Kadam, Pallavi" , dpdk-dev , Narcisa Ana Maria Vasile , Dmitry Malloy Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] doc/windows_gsg: update section on driver installation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Sat, Oct 9, 2021 at 1:20 PM Dmitry Kozlyuk wrote: snip > > > +Access to physical addresses is provided by a kernel-mode driver, virt2phys. > > > +It is mandatory for allocating physically-contiguous memory which is required > > > +by hardware PMDs. > > > > Should we add specific link to virt2phys README in this section as well? > > > > https://git.dpdk.org/dpdk-kmods/tree/windows/README.rst > > This link is given above and I consider it general information for all > drivers. However, reading it carefully, I think docs in dpdk-kmods could be > restructured as well: > * Keep windows/README.rst unchanged, except for Device Manager steps, > which are actually specific to virt2phys. > * Create windows/virt2phys/README.rst with instructions above. > * Change windows/netuio/README.rst: remove the bulk of its content, as it > repeats generic instructions, keep netuio-specific Device Manager part. > Then a specific link for virt2phys here would make sense > and there will be even less duplication in dpdk-kmods. > If no one objects, I'll do this in v2. Looks good to me! Thanks William