From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8ED68A0032; Fri, 1 Oct 2021 15:45:20 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 772B04067A; Fri, 1 Oct 2021 15:45:20 +0200 (CEST) Received: from mail-lf1-f50.google.com (mail-lf1-f50.google.com [209.85.167.50]) by mails.dpdk.org (Postfix) with ESMTP id C1D7040040 for ; Fri, 1 Oct 2021 15:45:18 +0200 (CEST) Received: by mail-lf1-f50.google.com with SMTP id m3so38538814lfu.2 for ; Fri, 01 Oct 2021 06:45:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=d0FUSmS2FoJPeUo5iL96SN/km+7eHDktklidoEinPiA=; b=UvE4Ccsvf2dviZxoUKDGRFs1dXmevx0CPHDr9yqInfPLwv9bdc4Ni0A6cQluudYSrS 7rnUFSQUF7ZPOXCt8vK/ZrKyuxmjHo7nXa9Hp7uEY5J8zxVgDVoskgd/YVlHJCN0FGL7 br8v4m78ueG4YNsAC7e/3Zee+07WWWvUTL6sBrX1nDBk+M5FENw1M5BqnSkeAr8C6ALM 0N6JXQJvqP8NWaSuE/UF22ek891SyT7u0UjOrpy/GApLBmpW+8qfrTi3yT8F150Ix13h 3Pk5+Dfw5jCF5uxzcpJ3m4XJJKypB0H7onjQRpahtLJ8yNOKHrdeom0YrWVRUVZs4loG Bzmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=d0FUSmS2FoJPeUo5iL96SN/km+7eHDktklidoEinPiA=; b=xILE6f7RdmIHzZji7cxpp+araezb96QPlgM43p5QjXhBPqr/aPdcYDO7xrIYzxVFGu t7+AcA4xb2JLQUdgK6rJBcMg54c1ATq8wqMcPOiVSFKUwQSEoxzbtTPyw41CJ0osTdG4 raB6PVE9nYQCyjALTJ/TiW6+EATYYXQA6prn2ddwsrH4S03t1UUzDEhsAhQZluAFC2Q8 6mS4+Iz0yCwSXLCo/bztWeneIewTEpfI+TuAWvyN0teDJONBKIlR05C2ve4uYmkRfrGD YvdAo9IOHn1jNPJkFquHZifE1ndYgHNlbTtfCO8uklRGWZrOoWYDxNXtUCRhLRMZ53AD ALeg== X-Gm-Message-State: AOAM531WbVBfKjajMUvvIgJ4+ticRf785iNvB9rcgOlnL5rEXK0J+aW3 h1qxfEFN8MUbnzyhooI1T1C4Gk5kVM/O+ZwVBn0= X-Google-Smtp-Source: ABdhPJzJGy0sVFSEn6+yoV/vBPUejWAVNXSAKNEMwVAfz3EG8PN2iUa6lagRnDfmAVYHpQYfNGd4h8G8GrQsgEdK5Ic= X-Received: by 2002:a19:48d8:: with SMTP id v207mr5481489lfa.678.1633095918290; Fri, 01 Oct 2021 06:45:18 -0700 (PDT) MIME-Version: 1.0 References: <20210915162603.16652-1-talshn@nvidia.com> <20210915162603.16652-2-talshn@nvidia.com> <7dae292c-f431-1fea-ce6f-9d1a83c05d2e@intel.com> In-Reply-To: <7dae292c-f431-1fea-ce6f-9d1a83c05d2e@intel.com> From: William Tu Date: Fri, 1 Oct 2021 06:44:41 -0700 Message-ID: To: "Kadam, Pallavi" Cc: Tal Shnaiderman , dpdk-dev , Thomas Monjalon , Dmitry Kozliuk , Narcisa Ana Maria Vasile , "Dmitry Malloy (MESHCHANINOV)" , gakhil@marvell.com, declan.doherty@intel.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH 2/2] security: build on Windows X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Sep 29, 2021 at 12:55 PM Kadam, Pallavi wrote: > > > On 9/15/2021 9:26 AM, Tal Shnaiderman wrote: > > Build the security library on Windows. > > > > Remove unneeded export from version file. > > > > Signed-off-by: Tal Shnaiderman > > --- > > Depends-on: patch-98796 ("cryptodev: build on Windows") > > --- > > lib/meson.build | 1 + > > lib/security/version.map | 1 - > > 2 files changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/lib/meson.build b/lib/meson.build > > index 5f3b1cf365..e5f0094a82 100644 > > --- a/lib/meson.build > > +++ b/lib/meson.build > > @@ -86,6 +86,7 @@ if is_windows > > 'gso', > > 'latencystats', > > 'pdump', > > + 'security', > > ] # only supported libraries for windows > > endif > > > > diff --git a/lib/security/version.map b/lib/security/version.map > > index c44c7f5f60..6067051552 100644 > > --- a/lib/security/version.map > > +++ b/lib/security/version.map > > @@ -1,7 +1,6 @@ > > DPDK_22 { > > global: > > > > - rte_security_attach_session; > > rte_security_capabilities_get; > > rte_security_capability_get; > > rte_security_session_create; > > Getting linking errors using clang for 'rte_security_get_userdata' and > 'rte_security_set_pkt_metadata' as below: > > FAILED: lib/rte_security-22.dll > "clang" -Wl,/MACHINE:X64 -Wl,/OUT:lib/rte_security-22.dll > lib/librte_security.a.p/security_rte_security.c.obj "-Wl,/nologo" > "-Wl,/release" "-Wl,/nologo" "-Wl,/OPT:REF" "-Wl,/DLL" > "-Wl,/IMPLIB:lib\rte_security.lib" "lib\rte_eal.lib" > "lib\rte_kvargs.lib" "lib\rte_mempool.lib" "lib\rte_ring.lib" > "lib\rte_cryptodev.lib" "lib\rte_mbuf.lib" "lib\rte_rcu.lib" > "lib\rte_net.lib" > "-Wl,/def:C:\dpdk\ixgbe\dpdk\build\lib\rte_security_exports.def" > "-ldbghelp" "-lsetupapi" "-lws2_32" "-lmincore" "-lkernel32" "-luser32" > "-lgdi32" "-lwinspool" "-lshell32" "-lole32" "-loleaut32" "-luuid" > "-lcomdlg32" "-ladvapi32" > rte_security_exports.def : error LNK2001: unresolved external symbol > rte_security_get_userdata > rte_security_exports.def : error LNK2001: unresolved external symbol > rte_security_set_pkt_metadata > lib\rte_security.lib : fatal error LNK1120: 2 unresolved externals > clang: error: linker command failed with exit code 1120 (use -v to see > invocation) > > Should it be removed from version file? > Previously it works ok, now on the latest main branch also hit the same issue. And yes, we should remove it from the version file. I will prepare the patch. William