From: William Tu <u9012063@gmail.com>
To: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
Cc: dpdk-dev <dev@dpdk.org>, Thomas Monjalon <thomas@monjalon.net>,
Ray Kinsella <mdr@ashroe.eu>,
David Marchand <david.marchand@redhat.com>
Subject: Re: [dpdk-dev] [PATCH 1/2] eal: remove Windows-specific list of common files
Date: Wed, 1 Sep 2021 10:20:45 -0700 [thread overview]
Message-ID: <CALDO+SZ_Wjp39eJVdrESF-Fe5oR3zpVVXcWgtMK19yxrNH-PNQ@mail.gmail.com> (raw)
In-Reply-To: <20210829021602.290466-2-dmitry.kozliuk@gmail.com>
On Sat, Aug 28, 2021 at 7:16 PM Dmitry Kozlyuk <dmitry.kozliuk@gmail.com> wrote:
>
> The majority of common EAL sources that are built for all platforms were
> listed separately for Windows and for other OS. It seems that developers
> adding modules to EAL perceived this as if Windows supported
> only a limited subset of modules and only added new ones into another.
> Factor the truly common modules into a shared list,
> then extend it with modules supported by different platforms.
>
> When the two lists were created, UUID API implementation was removed
> from Windows build (apparently by mistake), then excluded from the
> export list for no reason other than not being built. Restore it.
>
> Fixes: df3ff6be2b33 ("eal: simplify meson build of common directory")
> Cc: thomas@monjalon.net
>
> Signed-off-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
> ---
LGTM, thanks.
Acked-by: William Tu <u9012063@gmail.com>
next prev parent reply other threads:[~2021-09-01 17:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-29 2:16 [dpdk-dev] [PATCH 0/2] eal/windows: restore mistakenly hidden API Dmitry Kozlyuk
2021-08-29 2:16 ` [dpdk-dev] [PATCH 1/2] eal: remove Windows-specific list of common files Dmitry Kozlyuk
2021-09-01 17:20 ` William Tu [this message]
2021-08-29 2:16 ` [dpdk-dev] [PATCH 2/2] eal/windows: fix export list Dmitry Kozlyuk
2021-09-01 17:21 ` William Tu
2021-09-01 19:35 ` [dpdk-dev] [PATCH 0/2] eal/windows: restore mistakenly hidden API Menon, Ranjit
2021-09-30 20:48 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALDO+SZ_Wjp39eJVdrESF-Fe5oR3zpVVXcWgtMK19yxrNH-PNQ@mail.gmail.com \
--to=u9012063@gmail.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=dmitry.kozliuk@gmail.com \
--cc=mdr@ashroe.eu \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).