From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F3F3BA0C41; Wed, 15 Sep 2021 22:23:31 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7BF144003F; Wed, 15 Sep 2021 22:23:31 +0200 (CEST) Received: from mail-lf1-f53.google.com (mail-lf1-f53.google.com [209.85.167.53]) by mails.dpdk.org (Postfix) with ESMTP id 1872C4003C for ; Wed, 15 Sep 2021 22:23:30 +0200 (CEST) Received: by mail-lf1-f53.google.com with SMTP id bq5so9165820lfb.9 for ; Wed, 15 Sep 2021 13:23:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=OsTQI3o2xLT1bsP24cg8gex/Vw5RD28fQ2WN6FYmfoo=; b=B3d8GEka3J7TWSg5rc5zEnEHDCGpMIfYLz3Iz77VbwRbaU+mv66HWHjct0yo0C+9XB H3Eix77bSC9sjcd9U/CY1TgO5iqevfdUG0A5qK5XF6MEt0nykvcA5Oc5c257wtnbB10s tI05aYzqSAXULCbyFoyJBR4EI9aFmLODD8TgC7XAZ2h5Nnrzl6o6wDhSJyZSaC2CTHE2 qqO1CdgOhT4PJS6N81TVtfZrI2cU8/NfVgM0pcuu7Z/B7RlKkmX8YBIvejzt+iuDN9Cv yZXiQA0wCB++WnFsvDsEef1XNzaPg3b375Ny9sg1KDMYi8+El+r3GgyAE80h9WHYDpaD oVhw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=OsTQI3o2xLT1bsP24cg8gex/Vw5RD28fQ2WN6FYmfoo=; b=JwBJzBlRhyo2yjrPjL+BX0YqYiIFK3T+KDSXYPgXRfB3QrWsceMwS/ti36NLONhXrT lBtqDxvJFaj1ANAb0MF1y0wzijoSZD28L99UNbJV0d/aV45IwQEl65alP5uQi6Qv9wNV B0j1023Xl1wiiDvyRNPu231ibNMucXuLh2lLODyRhLMdM7Q/jucArS1odxCJD2atWw5A DnNccuI12g/pQYQXMlJa1AJ3pdsE2hroyVa+SPlasslxYY4N2iGY5PlGM9cMb80Bsh+t hbRSokJzsXF3bxWTo1kHy3h759GI1H55YtQC17OApomnY3Oht1IozjFszakIx5gJQ/C0 uMiQ== X-Gm-Message-State: AOAM530j6YR9FV4cRFH2mcHq1hMh2tMgACEwLlmzh26KP4GNYgBDT+TH XHH5n3iopqeVhoNXhThVwREY+m2j/4zLC/lEarI= X-Google-Smtp-Source: ABdhPJz9v65b0XG13zTbX2mcbluuficjGhhloWXMsXMYsXzCxRahkA7TL6vOzMzSoDki2RkofM+XXXZlV2HQH6uk08A= X-Received: by 2002:a05:6512:2353:: with SMTP id p19mr1295433lfu.681.1631737409534; Wed, 15 Sep 2021 13:23:29 -0700 (PDT) MIME-Version: 1.0 References: <20210915184448.92751-1-u9012063@gmail.com> <20210915220517.656c8167@sovereign> In-Reply-To: <20210915220517.656c8167@sovereign> From: William Tu Date: Wed, 15 Sep 2021 13:22:53 -0700 Message-ID: To: Dmitry Kozlyuk Cc: dpdk-dev , Pallavi Kadam , Ranjit Menon Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v1] net/ixgbe: Add support for Windows X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Sep 15, 2021 at 12:05 PM Dmitry Kozlyuk wrote: > > 2021-09-15 18:44 (UTC+0000), William Tu: > > This patch enables building the ixgbe driver for Windows. > > It also enables its dependencies on security and cryptodev. > > Tal Shnaiderman posted patches for cryptodev and security today, > so I won't comment on that part. IMO your patch should depend on them > (https://doc.dpdk.org/guides/contributing/patches.html#patch-dependencies). > > [...] > > diff --git a/drivers/net/ixgbe/base/ixgbe_osdep.h b/drivers/net/ixgbe/base/ixgbe_osdep.h > > index cacf724198..fe28029ef7 100644 > > --- a/drivers/net/ixgbe/base/ixgbe_osdep.h > > +++ b/drivers/net/ixgbe/base/ixgbe_osdep.h > > @@ -17,6 +17,12 @@ > > #include > > #include > > > > +#ifndef RTE_EXEC_ENV_WINDOWS > > +#include > > +#else > > +#include > > +#endif > > + > > #include instead. Hi Dmitry, Thanks for your feedback. I will send v2. William