DPDK patches and discussions
 help / color / mirror / Atom feed
From: William Tu <u9012063@gmail.com>
To: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
Cc: dpdk-dev <dev@dpdk.org>, Pallavi Kadam <pallavi.kadam@intel.com>,
	 David Marchand <david.marchand@redhat.com>,
	Haiyue Wang <haiyue.wang@intel.com>
Subject: Re: [dpdk-dev] [PATCH v2] net/e1000: build on Windows
Date: Fri, 8 Oct 2021 14:41:48 -0700	[thread overview]
Message-ID: <CALDO+Sa4ZPaHKjYLS69X_i5_8zML+oBNWrdNAuPqEC-zAr8XfQ@mail.gmail.com> (raw)
In-Reply-To: <20211008233535.5e872404@sovereign>

On Fri, Oct 8, 2021 at 1:35 PM Dmitry Kozlyuk <dmitry.kozliuk@gmail.com> wrote:
>
> 2021-10-08 06:53 (UTC-0700), William Tu:
> > This patch enables building the e1000 driver for Windows.
> > I tested using two Windows VM on top of VMware Fusion,
> > creating two e1000 devices with device ID 0x10D3,
> > verifying rx/tx works correctly using dpdk-testpmd.exe
> > rxonly and txonly mode.
> >
> > Signed-off-by: William Tu <u9012063@gmail.com>
> > Cc: Haiyue Wang <haiyue.wang@intel.com>
>
> Will there be an accompanying kmods patch to add the device ID to .inf?
>
> With device ID added to netuio, in QEMU with -device e1000e,
> Tested-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
>
> > diff --git a/doc/guides/nics/e1000em.rst b/doc/guides/nics/e1000em.rst
> > index 041c9a09a3a5..03ae23838bfa 100644
> > --- a/doc/guides/nics/e1000em.rst
> > +++ b/doc/guides/nics/e1000em.rst
> > @@ -1,6 +1,8 @@
> >  ..  SPDX-License-Identifier: BSD-3-Clause
> >      Copyright(c) 2010-2014 Intel Corporation.
> >
> > +.. include:: <isonum.txt>
> > +
> >  Driver for VM Emulated Devices
> >  ==============================
> >
> > @@ -153,3 +155,14 @@ The following are known limitations:
> >  #.  Qemu e1000 only supports one interrupt source, so link and Rx interrupt should be exclusive.
> >
> >  #.  Qemu e1000 does not support interrupt auto-clear, application should disable interrupt immediately when woken up.
> > +
> > +Windows Configuration
> > +---------------------
> > +
> > +- Follow the :doc:`guide for Windows <../windows_gsg/run_apps>`
> > +  to setup the basic DPDK environment.
> > +
> > +- Identify the Intel\ |reg| Ethernet adapter.
> > +
> > +- To load NetUIO driver, follow the steps mentioned in `dpdk-kmods repository
> > +  <https://git.dpdk.org/dpdk-kmods/tree/windows/netuio/README.rst>`_.
>
> There is nothing special about setting up this device on Windows.
> I think we don't need this part.

Thank you. I will add the Device ID to netuio.inf file
and remove the above part.
Will wait for Pallavi's test and resend the patch.

Thanks
William

  reply	other threads:[~2021-10-08 21:42 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-07 20:24 [dpdk-dev] [PATCH] " William Tu
2021-10-08  6:54 ` David Marchand
2021-10-08  6:55   ` David Marchand
2021-10-08 12:20   ` William Tu
2021-10-08 12:24     ` David Marchand
2021-10-08 13:53 ` [dpdk-dev] [PATCH v2] " William Tu
2021-10-08 16:08   ` Wang, Haiyue
2021-10-08 21:12     ` Kadam, Pallavi
2021-10-08 20:35   ` Dmitry Kozlyuk
2021-10-08 21:41     ` William Tu [this message]
2021-10-09 16:37     ` William Tu
2021-10-09  0:02   ` Kadam, Pallavi
2021-10-09  0:14     ` William Tu
2021-10-09 18:40       ` Kadam, Pallavi
2021-10-09 16:31   ` [dpdk-dev] [PATCH v3] " William Tu
2021-10-09 17:28     ` Dmitry Kozlyuk
2021-10-10 10:56       ` Wang, Haiyue
2021-10-19 19:05     ` William Tu
2021-10-19 19:12       ` Thomas Monjalon
2021-10-20  3:47     ` [dpdk-dev] [PATCH v4] " William Tu
2021-10-21  2:56       ` Zhang, Qi Z

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CALDO+Sa4ZPaHKjYLS69X_i5_8zML+oBNWrdNAuPqEC-zAr8XfQ@mail.gmail.com \
    --to=u9012063@gmail.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=dmitry.kozliuk@gmail.com \
    --cc=haiyue.wang@intel.com \
    --cc=pallavi.kadam@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).