* [dpdk-dev] [PATCH] cryptodev: build on Windows
@ 2021-09-13 17:16 Tal Shnaiderman
2021-09-19 14:03 ` William Tu
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Tal Shnaiderman @ 2021-09-13 17:16 UTC (permalink / raw)
To: dev
Cc: thomas, pallavi.kadam, dmitry.kozliuk, navasile, dmitrym, gakhil,
declan.doherty
Build the cryptography device library on Windows OS
by removing unneeded include and exports blocking the
compilation.
Signed-off-by: Tal Shnaiderman <talshn@nvidia.com>
---
lib/cryptodev/rte_cryptodev.c | 1 -
lib/cryptodev/version.map | 2 --
lib/meson.build | 1 +
3 files changed, 1 insertion(+), 3 deletions(-)
diff --git a/lib/cryptodev/rte_cryptodev.c b/lib/cryptodev/rte_cryptodev.c
index 9fa3aff1d3..b913c434c5 100644
--- a/lib/cryptodev/rte_cryptodev.c
+++ b/lib/cryptodev/rte_cryptodev.c
@@ -12,7 +12,6 @@
#include <errno.h>
#include <stdint.h>
#include <inttypes.h>
-#include <netinet/in.h>
#include <rte_byteorder.h>
#include <rte_log.h>
diff --git a/lib/cryptodev/version.map b/lib/cryptodev/version.map
index 8294c9f64f..43cf937e40 100644
--- a/lib/cryptodev/version.map
+++ b/lib/cryptodev/version.map
@@ -93,10 +93,8 @@ EXPERIMENTAL {
# added in 20.11
rte_cryptodev_configure_raw_dp_ctx;
rte_cryptodev_get_raw_dp_ctx_size;
- rte_cryptodev_raw_dequeue;
rte_cryptodev_raw_dequeue_burst;
rte_cryptodev_raw_dequeue_done;
- rte_cryptodev_raw_enqueue;
rte_cryptodev_raw_enqueue_burst;
rte_cryptodev_raw_enqueue_done;
diff --git a/lib/meson.build b/lib/meson.build
index 1673ca4323..5f3b1cf365 100644
--- a/lib/meson.build
+++ b/lib/meson.build
@@ -80,6 +80,7 @@ if is_windows
'hash',
'timer',
'bitratestats',
+ 'cryptodev',
'cfgfile',
'gro',
'gso',
--
2.16.1.windows.4
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH] cryptodev: build on Windows
2021-09-13 17:16 [dpdk-dev] [PATCH] cryptodev: build on Windows Tal Shnaiderman
@ 2021-09-19 14:03 ` William Tu
2021-09-23 18:07 ` Kadam, Pallavi
2021-10-05 10:39 ` [dpdk-dev] [EXT] " Akhil Goyal
2 siblings, 0 replies; 6+ messages in thread
From: William Tu @ 2021-09-19 14:03 UTC (permalink / raw)
To: Tal Shnaiderman
Cc: dpdk-dev, Thomas Monjalon, Pallavi Kadam, Dmitry Kozliuk,
Narcisa Ana Maria Vasile, Dmitry Malloy (MESHCHANINOV),
gakhil, declan.doherty
On Mon, Sep 13, 2021 at 10:19 AM Tal Shnaiderman <talshn@nvidia.com> wrote:
>
> Build the cryptography device library on Windows OS
> by removing unneeded include and exports blocking the
> compilation.
>
> Signed-off-by: Tal Shnaiderman <talshn@nvidia.com>
Acked-by: William Tu <u9012063@gmail.com>
I sent similar patch to enable ixgbe support for windows.
http://inbox.dpdk.org/dev/CALDO+SY_YkdV+Dx-dUJx8cyqafL6HdL=09DrOGCUBeonH2bPrA@mail.gmail.com/T/#t
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH] cryptodev: build on Windows
2021-09-13 17:16 [dpdk-dev] [PATCH] cryptodev: build on Windows Tal Shnaiderman
2021-09-19 14:03 ` William Tu
@ 2021-09-23 18:07 ` Kadam, Pallavi
2021-10-05 10:39 ` [dpdk-dev] [EXT] " Akhil Goyal
2 siblings, 0 replies; 6+ messages in thread
From: Kadam, Pallavi @ 2021-09-23 18:07 UTC (permalink / raw)
To: Tal Shnaiderman, dev
Cc: thomas, dmitry.kozliuk, navasile, dmitrym, gakhil, declan.doherty
On 9/13/2021 10:16 AM, Tal Shnaiderman wrote:
> Build the cryptography device library on Windows OS
> by removing unneeded include and exports blocking the
> compilation.
>
> Signed-off-by: Tal Shnaiderman <talshn@nvidia.com>
> ---
Acked-by: Pallavi Kadam <pallavi.kadam@intel.com>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [EXT] [PATCH] cryptodev: build on Windows
2021-09-13 17:16 [dpdk-dev] [PATCH] cryptodev: build on Windows Tal Shnaiderman
2021-09-19 14:03 ` William Tu
2021-09-23 18:07 ` Kadam, Pallavi
@ 2021-10-05 10:39 ` Akhil Goyal
2021-10-05 10:50 ` Akhil Goyal
2 siblings, 1 reply; 6+ messages in thread
From: Akhil Goyal @ 2021-10-05 10:39 UTC (permalink / raw)
To: Tal Shnaiderman, dev
Cc: thomas, pallavi.kadam, dmitry.kozliuk, navasile, dmitrym, declan.doherty
> Build the cryptography device library on Windows OS
> by removing unneeded include and exports blocking the
> compilation.
>
> Signed-off-by: Tal Shnaiderman <talshn@nvidia.com>
> ---
Acked-by: Akhil Goyal <gakhil@marvell.com>
Applied to dpdk-next-crypto
Thanks.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [EXT] [PATCH] cryptodev: build on Windows
2021-10-05 10:39 ` [dpdk-dev] [EXT] " Akhil Goyal
@ 2021-10-05 10:50 ` Akhil Goyal
2021-10-05 12:12 ` Tal Shnaiderman
0 siblings, 1 reply; 6+ messages in thread
From: Akhil Goyal @ 2021-10-05 10:50 UTC (permalink / raw)
To: Akhil Goyal, Tal Shnaiderman, dev, thomas
Cc: pallavi.kadam, dmitry.kozliuk, navasile, dmitrym, declan.doherty
> > Build the cryptography device library on Windows OS
> > by removing unneeded include and exports blocking the
> > compilation.
> >
> > Signed-off-by: Tal Shnaiderman <talshn@nvidia.com>
> > ---
> Acked-by: Akhil Goyal <gakhil@marvell.com>
>
> Applied to dpdk-next-crypto
Removing this patch from dpdk-next-crypto as the patch is superseded
With another series delegated to Thomas.
http://patches.dpdk.org/project/dpdk/cover/20211002003344.594-1-u9012063@gmail.com/
Please ensure previous versions are marked superseded or else it will create
Unnecessary issues while merging.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [EXT] [PATCH] cryptodev: build on Windows
2021-10-05 10:50 ` Akhil Goyal
@ 2021-10-05 12:12 ` Tal Shnaiderman
0 siblings, 0 replies; 6+ messages in thread
From: Tal Shnaiderman @ 2021-10-05 12:12 UTC (permalink / raw)
To: Akhil Goyal, dev, NBU-Contact-Thomas Monjalon
Cc: pallavi.kadam, dmitry.kozliuk, navasile, dmitrym, declan.doherty
> Subject: RE: [EXT] [PATCH] cryptodev: build on Windows
>
> External email: Use caution opening links or attachments
>
>
> > > Build the cryptography device library on Windows OS by removing
> > > unneeded include and exports blocking the compilation.
> > >
> > > Signed-off-by: Tal Shnaiderman <talshn@nvidia.com>
> > > ---
> > Acked-by: Akhil Goyal <gakhil@marvell.com>
> >
> > Applied to dpdk-next-crypto
> Removing this patch from dpdk-next-crypto as the patch is superseded With
> another series delegated to Thomas.
> http://patches.dpdk.org/project/dpdk/cover/20211002003344.594-1-
> u9012063@gmail.com/
>
> Please ensure previous versions are marked superseded or else it will create
> Unnecessary issues while merging.
>
>
Thanks, you're right, I superseded the security patches but didn't notice a v3 for crypto was also sent.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-10-05 12:12 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-13 17:16 [dpdk-dev] [PATCH] cryptodev: build on Windows Tal Shnaiderman
2021-09-19 14:03 ` William Tu
2021-09-23 18:07 ` Kadam, Pallavi
2021-10-05 10:39 ` [dpdk-dev] [EXT] " Akhil Goyal
2021-10-05 10:50 ` Akhil Goyal
2021-10-05 12:12 ` Tal Shnaiderman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).