From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0E427A0C53; Sun, 15 Aug 2021 16:28:57 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9FC2E40683; Sun, 15 Aug 2021 16:28:56 +0200 (CEST) Received: from mail-lj1-f174.google.com (mail-lj1-f174.google.com [209.85.208.174]) by mails.dpdk.org (Postfix) with ESMTP id 8CE2140395 for ; Sun, 15 Aug 2021 16:28:55 +0200 (CEST) Received: by mail-lj1-f174.google.com with SMTP id f2so1525699ljn.1 for ; Sun, 15 Aug 2021 07:28:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=1fwe3GDdUZPCmyQ3vmV7/i3WOJ3sp0ckoVKC9YWlVUI=; b=RtQpI/fmetnIRL4mkf6nKx04SXIIVaFLEDLaP01J0fAFnB06h32aPD3GeUkKFTOklV dM+F/+vIXZYeiR8ZTe9oQu44ST9DC1widfm3DKWmzsqB7zef+mjle0/ZyS6sh7MUKaMh ZHUpx2HB/GDRav30AYfBBR46aaNUttUHi19rpZPzEnTEjps0mEtW9I+UrEDS2t4Yklh+ FDhdrrWQZy7G51KOHEGCFiba8zBSe7naeXkF89hrAv2TFjT3pnkY+Lq8bQyNhsj3PG7E nNMkgFhoqqFTIluep+LKoVINn5Xdpp9HHtOqJTFUMPUlt9l+2DKKD17KxyeHDt+wVjcw 2Cvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=1fwe3GDdUZPCmyQ3vmV7/i3WOJ3sp0ckoVKC9YWlVUI=; b=JSXC905HZ+TKIxdd5Va5TAOpe654tIq6MPYIiCiHcGxA7j0a6kcbkzdPNOD/ESPe5Y 6ri0JvMln1pDHi/fusk5A+ruDwCGv3KS3cbQvddiIKbVQcHK8UxZOChYxNe4CzgXQQLZ i8M+EclAIM/sbeBuaMv5IVb2WI6MrSWMem6BS178pvYuuc30fKUctoeYO0rStdq1w3la DsSC+aXC9H/i54VtDJsvvVI4EEe17cyU2Ci2i1aI0YyaTL1rlbxP7PNLmJzXbEOMSVHs 1gDShF9CWCfRbrFOZMbEqSlIEIHF0f5xdwLwQC560Dfqo+1MgHMRR3rBENIY59tEovQz AM7w== X-Gm-Message-State: AOAM5314PCXp+7B6VJ7IdN+Idytbk3pZEFL7w1bKtWG1gd88VPRXJ3k2 c9aTBHEGbSt4zzNZXPINJW3T+wL37imeNvQvWfk= X-Google-Smtp-Source: ABdhPJyQSgKrBfsLZYNMEIhZFhQhHCN+GXxcRIhwIQaOiWFWAoSyyLgcsmYYahl8/ov0JTYuRfN3M5lLta8+Qf0of5c= X-Received: by 2002:a2e:a224:: with SMTP id i4mr5561960ljm.168.1629037735150; Sun, 15 Aug 2021 07:28:55 -0700 (PDT) MIME-Version: 1.0 References: <20200227071126.75162e92@Sovereign> <20200228060727.192491-1-dmitry.kozliuk@gmail.com> <20200228060727.192491-6-dmitry.kozliuk@gmail.com> <20210814200057.35207d86@sovereign> In-Reply-To: <20210814200057.35207d86@sovereign> From: William Tu Date: Sun, 15 Aug 2021 07:28:18 -0700 Message-ID: To: Dmitry Kozlyuk Cc: dpdk-dev Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [RFC PATCH 5/5] mk/windows: add virtio-net PMD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Sat, Aug 14, 2021 at 10:01 AM Dmitry Kozlyuk wrote: > > 2021-08-14 08:55 (UTC-0700), William Tu: > > Hi Dmitry, > > > > I'm looking at this patch and have some questions. > > > > On Thu, Feb 27, 2020 at 10:08 PM Dmitry Kozlyuk > > wrote: > > > > > > Signed-off-by: Dmitry Kozlyuk > > > --- > > > drivers/net/virtio/virtio_ethdev.c | 4 + > > > kernel/windows/netuio/netuio.inf | 6 + > > > lib/librte_eal/windows/eal/eal.c | 4 + > > > > Why do we need these change below? > > 1. At the time of the patch there was no dpdk-kmods repo. > > 2. The patch is for dpdk-draft-windows repo, > which was using Vistual Studio projects instead of meson. > > > I thought to add a new Windows driver support, we only need to > > compile the drivers/net/xxx, and add the device ID to netuio.inf, > > at the dpdk-kmod repo? > > Yes. > Particularly for virtio it would also be required to support reading PCI > config space in bus/pci/windows (netuio already provides the support). > Now I understand, thanks. William