From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CEDC2A0C4C; Sun, 26 Sep 2021 05:23:30 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 374984003D; Sun, 26 Sep 2021 05:23:30 +0200 (CEST) Received: from mail-lf1-f52.google.com (mail-lf1-f52.google.com [209.85.167.52]) by mails.dpdk.org (Postfix) with ESMTP id 6B6844003C for ; Sun, 26 Sep 2021 05:23:29 +0200 (CEST) Received: by mail-lf1-f52.google.com with SMTP id m3so59518518lfu.2 for ; Sat, 25 Sep 2021 20:23:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=C7eXT7bc7hMUp740umQavBABxL8a4s+wR0FVUPcpWO4=; b=Hie5gr8zFY40jVyrD70ZVzqCjyEtXd1P799zpoCdsfic7lwZWeifk38TbttvLGdpfZ NNr2HiywENT1SwFMSn2ZjgnwNWW6Uf/bynskGgc7+ZiM8RaremuANNbUDi1EUKHk3BNz WEXHtzLaWAV2AdFWbF/lM1cn31HyGnDcTxTuxzlhaQEX/30l2ByU0BTgS2FLIySAl5tq gr55LC0vOXtNCi7Ea4EBROGuDCzUD+NHi3/KDZLbejZiFBI36k509Ktfn9rosar+q9T8 sYVvqs8sV0A0PaybpCQvCzKIlM6QGToudaEiEeaeL/tVGARLCxk7ZGg6dGF86/REn4uH yXdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=C7eXT7bc7hMUp740umQavBABxL8a4s+wR0FVUPcpWO4=; b=mtKOPdh4H8uUpZxl1i6AKAbzOOvBWakk1YQhnTpJoHSgV5VdM9u+2h3DFrrc9CC3XJ 0f6OndideAXZNznVhlGbXdkEnFuHFqJruu5DtHE1JqBJhopuiQBNMvD+mojZGf2iyvQf ALsIITG4xh4VaIhE2pfqGzkZyHIUm6ecf26POBPfkjTCvCi9OOgY71hXnnHm1N1/MV5c XsBuouEx152vgJ6zmjtO7MLnCkfwg0FqQcskTJcJn6SlT7KK86HBodz6w1mU6oGYTYcL Un8YgWnhIi2khy+vyTPwZUVQLIVXXZTaTpyeQE4W20ys8b9o3LgGf9retDBBejc1Y/XA Q+zA== X-Gm-Message-State: AOAM530Y7JJ1/Qf5QeawOwDs0kvPQJ0J1AdneqK+nOumMuW/yxKUFyAh XiEhii5FwKwqhdgHaoLoKnpK2rpI9rIv+Kx6/pc= X-Google-Smtp-Source: ABdhPJzceMAdFTTUOLMmMPbAfhucms7Jasbzj0sj8X736Bnm14/CS58OxHof206W29vUSnnNFrlZ2jifT//YAsYg5VE= X-Received: by 2002:a2e:b5d3:: with SMTP id g19mr17841407ljn.205.1632626608814; Sat, 25 Sep 2021 20:23:28 -0700 (PDT) MIME-Version: 1.0 References: <20210924180816.150-1-u9012063@gmail.com> <20210925192205.2419fdce@sovereign> In-Reply-To: <20210925192205.2419fdce@sovereign> From: William Tu Date: Sat, 25 Sep 2021 20:22:52 -0700 Message-ID: To: Dmitry Kozlyuk Cc: dpdk-dev , "Richardson, Bruce" Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v1] build/pkg-config: Fix warning for Windows X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Sat, Sep 25, 2021 at 9:22 AM Dmitry Kozlyuk wrote: > > 2021-09-24 18:08 (UTC+0000), William Tu: > > Windows does not support linker option '/-no-whole-archive' > > or '/whole-archive'. The patch removes them under Windows build. > > > > Signed-off-by: William Tu > > --- > > buildtools/pkg-config/meson.build | 10 +++++++--- > > 1 file changed, 7 insertions(+), 3 deletions(-) > > Hi William, > > We need to tell the linker to use whole archive somehow; > you write [1] that /WHOLEARCHIVE was required in the end. > There's no "Windows linker", there are clang and GCC linkers, > the latter supports --whole-archive, but the former needs it translated. > Argument translation between compilers is handled by meson. > I've filed a bug: https://github.com/mesonbuild/meson/issues/9296 > > [1]: > http://inbox.dpdk.org/dev/CALDO+SZ-FLPYNQbUJ-Ctwtph+M4_X_=zYAOKgkp5_un4QFq_eg@mail.gmail.com/ Hi Dmitry, Thank you! One more thing, when I added /WHOLEARCHIVE, I hit some errors due to macro definitions. ex: ws2_32.lib(WS2_32.dll) : error LNK2005: WS2_32_NULL_THUNK_DATA already defined in mincore.lib(WS2_32.dll) Shlwapi.lib(SHLWAPI.dll) : error LNK2005: __NULL_IMPORT_DESCRIPTOR already defined in mincore.lib(api-ms-win-core -com-l1-1-0.dll) Iphlpapi.lib(IPHLPAPI.DLL) : error LNK2005: __IMPORT_DESCRIPTOR_IPHLPAPI already defined in mincore.lib(IPHLPAPI. see: https://github.com/smadaminov/ovs-dpdk-meson-issues/issues/65 In the end, I have to add also: -Wl,/FORCE:MULTIPLE Thanks William