Re: [dpdk-dev] [PATCH v3 0/7] MinGW-w64 support

[William Tu <u9012063@gmail.com>]

On Mon, Feb 17, 2020 at 4:02 PM Dmitry Kozlyuk <dmitry.kozliuk@gmail.com> wrote:
>
> This patch series add support for building DPDK using MinGW-w64.
>
> MinGW-w64 provides GNU toolchain and independent platform SDK on
> Windows. It also supports cross-compilation to Windows from POSIX
> systems by providing cross tollchains and libraries [0]. It does NOT
> emulate a full POSIX environment, like Cygwin or MSYS do.
>
> There are advantages in using MinGW-w64 in addition to Clang:
>
> 1. Cross-compilation out-of-the-box. MinGW-w64 is provides a pthread
>    implementation, GNU getopt, and Windows platform SDK.
>
> 2. Easier porting of POSIX applications using DPDK to Windows, because
>    application code can use the same benefits as mentioned above.
>
> 3. Having both primary compilers enabled on Windows provides more
>    diagnostics and generally prevents non-portable code.
>
> [0]: http://mingw-w64.org
>
> v3 Changes:
>
>     Rebase onto the latest Windows EAL.
>     Prevent format attribute conflict with upcoming v20.05 patches.
>     Remove redundant CFLAGS from Meson.
>     Remove links to Meson bugtracker from docs (PR merged into upstream).
>     Fix Clang warnings using about GNU options.
>
> v2 Changes:
>
>     Add patch to use lowercase system header filenames.
>     Move Meson cross-file for x86 to arch directory.
>     Change wording in comments.
>     Add Meson version warning in documentation.
>
> ---

I have to apply below diff to make it work:

diff --git a/lib/librte_eal/windows/eal/include/pthread.h
b/lib/librte_eal/windows/eal/include/pthread.h
index 4ac24de0aa27..b9dd18e56815 100644
--- a/lib/librte_eal/windows/eal/include/pthread.h
+++ b/lib/librte_eal/windows/eal/include/pthread.h
@@ -14,7 +14,7 @@
 extern "C" {
 #endif

-#include <Windows.h>
+#include <windows.h>

 #define PTHREAD_BARRIER_SERIAL_THREAD TRUE


Otherwise, the series look good to me.
Acked-by: William Tu <u9012063@gmail.com>

Thanks
William