From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C31E0A0C47; Thu, 7 Oct 2021 14:05:08 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 894E4411A6; Thu, 7 Oct 2021 14:05:08 +0200 (CEST) Received: from mail-lf1-f48.google.com (mail-lf1-f48.google.com [209.85.167.48]) by mails.dpdk.org (Postfix) with ESMTP id D758A407FF for ; Thu, 7 Oct 2021 14:05:06 +0200 (CEST) Received: by mail-lf1-f48.google.com with SMTP id z11so15788383lfj.4 for ; Thu, 07 Oct 2021 05:05:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=hWCsbTliyhdhBcVYfkWfKGUwTW5Fs7pJgd0CGxm184g=; b=m0Etq+HyAtSUJxnrtiCLI0/qHwxGsCHnieP/2UJN12tJJ/2jxE6Q3djH2fhsfMoR0X wTrvUx7OLFZpReajxm/+TJQGk4CdmKgdq43JGzMx2rgQLrWfNwj2QwjQYhScvDJT1cnr Oj2z9WOsrMGfU/H7ZORglOO4y1Ws/2C5BnbXCVLkzpk/gV7gcdfxq7k1gJyPFKg6YcY7 uj0EawrkWulsPkKfKblFAO9Nh81O5LByw7EQy1pnHJkNDucSIFRD/944Za39NBi/Svhv ib4M+d0CDe9JEPqj1jrLemg5cUn00Ba7PiD9pZ5XexS6q2vSFODUqKX4A7S8PWKfZmi5 PZBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=hWCsbTliyhdhBcVYfkWfKGUwTW5Fs7pJgd0CGxm184g=; b=HEySTAAGySKDlCgk+wL1SIa3gyTWV0GRzg/QdLir6N3h1pFkYhfbBcDKTZ/vr7ywFl GGdK360ZgDLvoH9ZfXpNTbM267WV8GB8KCqpc7Elgqq8ClGb7tXp9xMQ/+nerxPoWnS9 /edhXIfcyr72MZowoDBmvWY4StbCuWTSpEfre7nxUyY5EtUbQEcG7KZuVp9L5ncWOTn4 X0eccxo35XhTBWCaYBUYdZpb+VGPgP7KXGD4lPP6tSeL9Dft2Wx8nKlMGSs0J/UKi6Tc tbWsNxNp53tGSn/9JqROaGBM3W4T4R0ZTzXqNQFRtIuMFSITAL63HL4bp0GX3ugcwHNL PR3A== X-Gm-Message-State: AOAM530v8ef4h0SRf+wKCwNyn4UZ8XJTkalTfoHLfrv4n42Bqw8Eds+c m2O4e7cymQG0mPeSbpUIaq8zV83Yce9il7Rmms4= X-Google-Smtp-Source: ABdhPJxSwoY4849CFKhTKtfJwdi9p96r7yJ3PgyAlHTd8aiazxJpDuTb2Tz13Xx6yt70FX5x9tisosjBmXdcEnGHziM= X-Received: by 2002:a05:651c:3c3:: with SMTP id f3mr4262184ljp.222.1633608304420; Thu, 07 Oct 2021 05:05:04 -0700 (PDT) MIME-Version: 1.0 References: <20210924180816.150-1-u9012063@gmail.com> <20210925192205.2419fdce@sovereign> <7394122.RNkyZvFM6L@thomas> In-Reply-To: <7394122.RNkyZvFM6L@thomas> From: William Tu Date: Thu, 7 Oct 2021 05:04:27 -0700 Message-ID: To: Thomas Monjalon Cc: Dmitry Kozlyuk , dpdk-dev , "Richardson, Bruce" Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v1] build/pkg-config: Fix warning for Windows X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Please don't apply this patch. I think we're waiting for meson to fix it. https://github.com/mesonbuild/meson/issues/9296 In the meantime, at OVS's meson build script, I'm adding /WHOLEARCHIVE and /FORCE:MULTIPLE when linking dpdk. So no need to fix it here. Thanks William On Thu, Oct 7, 2021 at 4:58 AM Thomas Monjalon wrote: > > Hi, > > What is the conclusion for this patch? > > 26/09/2021 05:22, William Tu: > > On Sat, Sep 25, 2021 at 9:22 AM Dmitry Kozlyuk wrote: > > > > > > 2021-09-24 18:08 (UTC+0000), William Tu: > > > > Windows does not support linker option '/-no-whole-archive' > > > > or '/whole-archive'. The patch removes them under Windows build. > > > > > > > > Signed-off-by: William Tu > > > > --- > > > > buildtools/pkg-config/meson.build | 10 +++++++--- > > > > 1 file changed, 7 insertions(+), 3 deletions(-) > > > > > > Hi William, > > > > > > We need to tell the linker to use whole archive somehow; > > > you write [1] that /WHOLEARCHIVE was required in the end. > > > There's no "Windows linker", there are clang and GCC linkers, > > > the latter supports --whole-archive, but the former needs it translated. > > > Argument translation between compilers is handled by meson. > > > I've filed a bug: https://github.com/mesonbuild/meson/issues/9296 > > > > > > [1]: > > > http://inbox.dpdk.org/dev/CALDO+SZ-FLPYNQbUJ-Ctwtph+M4_X_=zYAOKgkp5_un4QFq_eg@mail.gmail.com/ > > > > Hi Dmitry, > > > > Thank you! > > One more thing, when I added /WHOLEARCHIVE, I hit some errors due to > > macro definitions. > > ex: > > ws2_32.lib(WS2_32.dll) : error LNK2005: WS2_32_NULL_THUNK_DATA already > > defined in mincore.lib(WS2_32.dll) > > Shlwapi.lib(SHLWAPI.dll) : error LNK2005: __NULL_IMPORT_DESCRIPTOR > > already defined in mincore.lib(api-ms-win-core > > -com-l1-1-0.dll) > > Iphlpapi.lib(IPHLPAPI.DLL) : error LNK2005: > > __IMPORT_DESCRIPTOR_IPHLPAPI already defined in mincore.lib(IPHLPAPI. > > see: > > https://github.com/smadaminov/ovs-dpdk-meson-issues/issues/65 > > > > In the end, I have to add also: > > -Wl,/FORCE:MULTIPLE > > > > Thanks > > William > > > >