From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 58322A0569; Wed, 11 Mar 2020 18:23:36 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 494031BF7F; Wed, 11 Mar 2020 18:23:35 +0100 (CET) Received: from mail-qv1-f68.google.com (mail-qv1-f68.google.com [209.85.219.68]) by dpdk.org (Postfix) with ESMTP id B27B1FEB for <dev@dpdk.org>; Wed, 11 Mar 2020 18:23:34 +0100 (CET) Received: by mail-qv1-f68.google.com with SMTP id du17so1223781qvb.12 for <dev@dpdk.org>; Wed, 11 Mar 2020 10:23:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=x5KS2z9yJ0cDB1MdBlY9IVbtvBhVo6pX2Mu3k11YUzg=; b=qj2GSt41gVD9cavMSq5+jndebn0STKKV1OEqUyVTsV1f1OKesO9CCSa3e7edKNYNOQ 3njtdkVz+o+ufGDb9CRgDZAWppDlKiXMh/6SqxffGYBi5eBu6YTcQtwI0MEVMEXv5aXN NyC12PngQ6Fi36zKkUi3g/4AQSi9Fata5wfCzU0RU1b+XgypskzOpHzj0Ofk3O9wOosD qdReaT9ku+z+MrV2mKcInVxUVAC5rAG+cE1C5Y9/MPVICM4cFrrc5/KNv96KacZy7bAJ 43LbJE1TJetr39/U8RXdZycaC040Mi0Pd18zDab+033MdBBu7M0nEfwBdD4Qa48y8Hk0 zW4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=x5KS2z9yJ0cDB1MdBlY9IVbtvBhVo6pX2Mu3k11YUzg=; b=KRhUyzUupRBMmLft2Cb6v5yFuUFCzOr1BNYpGLf/ETDonsWPnhiT46NkZOZZf5HDnK HQKqYT3hGpqesSpAGBiWaboYZdIGBUL/FKutV/IjBmR4KMlRk3carHNleLSeEOnafhsZ 0uWh2x1WGH5tYp2QOfPuG4l6Dl2sxOQXb59uPZ8DxlB2T3Dq1JzZxi8FGRzMorzs5l1J z+34KOJxGBIoJZn+AEV45I5HRg2ZVOi1ivdEF5Abc4fcKtjTytukvMg4VRhlaHZGOqWf vuX+vBOqQ/pFrjXe8XuNKIcg1CiohQNH4Zd91VHpdjtCNUCu9caF4I41vf0I869ngvKD NlCw== X-Gm-Message-State: ANhLgQ1WrXJm5EVpbra17aP9ZsbDZh2Uq2ISPLjjAShhyaIvPvKrMM9Q uB9SFCxSnkDqu9XoNQfF0vEsf+NWOy2RaDAdqFU= X-Google-Smtp-Source: ADFU+vtvxFvLm44Ci2aCLO+NhJhGWOEIM+vvneHmRZJQPVc0434ZXOeC4OIGihTDF71Tfsu8Ettu5F7u6hf4T12CoGM= X-Received: by 2002:a0c:e902:: with SMTP id a2mr3756660qvo.20.1583947413817; Wed, 11 Mar 2020 10:23:33 -0700 (PDT) MIME-Version: 1.0 References: <20200218000229.86621-1-dmitry.kozliuk@gmail.com> <20200227042537.187459-1-dmitry.kozliuk@gmail.com> In-Reply-To: <20200227042537.187459-1-dmitry.kozliuk@gmail.com> From: William Tu <u9012063@gmail.com> Date: Wed, 11 Mar 2020 10:22:56 -0700 Message-ID: <CALDO+SbHm_RABFDzok+WgVv+xMx16XixW+6YGEP-owmzeySN_w@mail.gmail.com> To: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com> Cc: dev@dpdk.org, Bruce Richardson <bruce.richardson@intel.com>, Thomas Monjalon <thomas@monjalon.net>, Olivier Matz <olivier.matz@6wind.com>, Harini Ramakrishnan <harini.ramakrishnan@microsoft.com>, Omar Cardona <ocardona@microsoft.com>, Pallavi Kadam <pallavi.kadam@intel.com>, Ranjit Menon <ranjit.menon@intel.com>, John McNamara <john.mcnamara@intel.com>, Marko Kovacevic <marko.kovacevic@intel.com> Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v4 0/7] MinGW-w64 support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> On Wed, Feb 26, 2020 at 8:25 PM Dmitry Kozlyuk <dmitry.kozliuk@gmail.com> wrote: > > This patch series add support for building DPDK using MinGW-w64. > > MinGW-w64 provides GNU toolchain and independent platform SDK on > Windows. It also supports cross-compilation to Windows from POSIX > systems by providing cross tollchains and libraries [0]. It does NOT > emulate a full POSIX environment, like Cygwin or MSYS do. > > There are advantages in using MinGW-w64 in addition to Clang: > > 1. Cross-compilation out-of-the-box. MinGW-w64 is provides a pthread > implementation, GNU getopt, and Windows platform SDK. > > 2. Easier porting of POSIX applications using DPDK to Windows, because > application code can use the same benefits as mentioned above. > > 3. Having both primary compilers enabled on Windows provides more > diagnostics and generally prevents non-portable code. > > [0]: http://mingw-w64.org > > v4 Changes: > > Fix Windows headers include case. > Recommend the latest Meson in docs (build fixed with 0.53.2). > > v3 Changes: > > Rebase onto the latest Windows EAL. > Prevent format attribute conflict with upcoming v20.05 patches. > Remove redundant CFLAGS from Meson. > Remove links to Meson bugtracker from docs (PR merged into upstream). > Fix Clang warnings using about GNU options. > > v2 Changes: > > Add patch to use lowercase system header filenames. > Move Meson cross-file for x86 to arch directory. > Change wording in comments. > Add Meson version warning in documentation. > > Dmitry Kozlyuk (7): > eal: introduce portable format attribute > eal/windows: use lowercase filenames for system headers > eal/windows: support builing with MinGW-w64 > build: MinGW-w64 support for Meson > build: add cross-file for MinGW-w64 > doc: guide for Windows build using MinGW-w64 > build: fix linker warnings with Clang on Windows > > config/meson.build | 26 ++++++-- > config/x86/meson_mingw.txt | 13 ++++ > doc/guides/windows_gsg/build_dpdk.rst | 62 +++++++++++++++++--- > lib/librte_cmdline/cmdline.h | 4 +- > lib/librte_eal/common/include/rte_common.h | 17 +++++- > lib/librte_eal/common/include/rte_debug.h | 2 +- > lib/librte_eal/common/include/rte_devargs.h | 2 +- > lib/librte_eal/common/include/rte_log.h | 4 +- > lib/librte_eal/meson.build | 3 + > lib/librte_eal/windows/eal/eal.c | 6 +- > lib/librte_eal/windows/eal/include/getopt.h | 4 ++ > lib/librte_eal/windows/eal/include/pthread.h | 2 +- > lib/librte_eal/windows/eal/include/rte_os.h | 6 +- > lib/meson.build | 8 ++- > 14 files changed, 133 insertions(+), 26 deletions(-) > create mode 100644 config/x86/meson_mingw.txt > I reviewed and tested the v4 series and everything works ok. Tested-by: William Tu <u9012063@gmail.com> Thanks