From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 26C53A0C43; Fri, 1 Oct 2021 00:17:12 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A220E4067E; Fri, 1 Oct 2021 00:17:11 +0200 (CEST) Received: from mail-lf1-f47.google.com (mail-lf1-f47.google.com [209.85.167.47]) by mails.dpdk.org (Postfix) with ESMTP id BA9274067A for ; Fri, 1 Oct 2021 00:17:10 +0200 (CEST) Received: by mail-lf1-f47.google.com with SMTP id b20so31498850lfv.3 for ; Thu, 30 Sep 2021 15:17:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=mpGC62ZN2euVsdlqdRpUuwgWmjx3qV/cX4kW9o+VK/g=; b=no6Vn01vCL7Vt8QeThDHNsHAa/bddkAdYUhCOvGJlFugrqEb1DeCJd8eof7lEulada XwhjVLyF3QTKUy32p8UjJNtbX/g7mzoSkinBCFLZa2/Vx+0XY2PmFF617RhI8fJwzDmY BI+XYS47NvudsMxaSbEOnImCIbH13Y45dsQcU6YpvVrsFafKZqWF0mBr/Ea8hYWCBZXy 05sIu5Wmaza/Kpl8yGauw+rrpU/5J27JO8iaHGbcWpSvUrxV10nEWMJZtpZpGKAUpInv Y9ydTgN7PH2aPdsbarjum3mBqP9/KG6t/oVZiAiCa2yG4372MS1vOX6L7Et8WcrWR6jN H9bQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=mpGC62ZN2euVsdlqdRpUuwgWmjx3qV/cX4kW9o+VK/g=; b=4HTiIzzy9oWFZPzS8oV2WRxdWCQnon8NFyN5IXDxJOE2tnouiJ9e/ayD+4WxMI8yA1 WhF5espCfyvVOntBmZPR383802lJZTvwnem6YhTKl6HHXrltuthDeM3CKe1ttQsU9Hsb rDInBjMdJBhCVdJfVelNyvYFDapKisZSegA7pjPYifKByUScGA6oAbLQWdx1xQQMbtcO EPysHk24KJJ2hPuTN3aMq46z6qQRBGsbOoRPtox+sqtU17lnUclhY+At8jtcUkL1PxB8 pe2AHc15gOWUTr8Wu188q0z0WJzjtbiEoejk2DE29VshgRUdz3i2TyF3o1qFrOlpc6+w ziWg== X-Gm-Message-State: AOAM530PkoIKOG17f1fLFLQJ4Cqrf7s45HyluoBZfN6VhLklfOGK2qP/ AcUic/LY8/FBPn7SaokKn9sFPctrwaztaPhxovg= X-Google-Smtp-Source: ABdhPJzWdyx2rTgy2ZNXHXRI23ZtNCqQAsVde7cVaHWNOVdvCBFJzCTH03VNKmwE+xS8+RkRx9oW+4SREirbMvGJzhI= X-Received: by 2002:a2e:a791:: with SMTP id c17mr8061046ljf.509.1633040230125; Thu, 30 Sep 2021 15:17:10 -0700 (PDT) MIME-Version: 1.0 References: <20210823130343.87247-1-u9012063@gmail.com> <20210824162103.32783-1-u9012063@gmail.com> <20210920201111.GA7448@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> In-Reply-To: <20210920201111.GA7448@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> From: William Tu Date: Thu, 30 Sep 2021 15:16:33 -0700 Message-ID: To: Narcisa Ana Maria Vasile , Thomas Monjalon Cc: dpdk-dev , Dmitry Kozliuk , Nick Connolly , Omar Cardona , Pallavi Kadam Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v9] eal: remove sys/queue.h from public headers X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Sep 20, 2021 at 1:11 PM Narcisa Ana Maria Vasile wrote: > > On Tue, Aug 24, 2021 at 04:21:03PM +0000, William Tu wrote: > > Currently there are some public headers that include 'sys/queue.h', which > > is not POSIX, but usually provided by the Linux/BSD system library. > > (Not in POSIX.1, POSIX.1-2001, or POSIX.1-2008. Present on the BSDs.) > > The file is missing on Windows. During the Windows build, DPDK uses a > > bundled copy, so building a DPDK library works fine. But when OVS or other > > applications use DPDK as a library, because some DPDK public headers > > include 'sys/queue.h', on Windows, it triggers an error due to no such > > file. > > > > One solution is to install the 'lib/eal/windows/include/sys/queue.h' into > > Windows environment, such as [1]. However, this means DPDK exports the > > functionalities of 'sys/queue.h' into the environment, which might cause > > symbols, macros, headers clashing with other applications. > > > > The patch fixes it by removing the "#include " from > > DPDK public headers, so programs including DPDK headers don't depend > > on the system to provide 'sys/queue.h'. When these public headers use > > macros such as TAILQ_xxx, we replace it by the ones with RTE_ prefix. > > For Windows, we copy the definitions from to rte_os.h > > in Windows EAL. Note that these RTE_ macros are compatible with > > , both at the level of API (to use with > > macros in C files) and ABI (to avoid breaking it). > > > > Additionally, the TAILQ_FOREACH_SAFE is not part of , > > the patch replaces it with RTE_TAILQ_FOREACH_SAFE. > > > > [1] http://mails.dpdk.org/archives/dev/2021-August/216304.html > > > > Suggested-by: Nick Connolly > > Suggested-by: Dmitry Kozliuk > > Acked-by: Dmitry Kozliuk > > Signed-off-by: William Tu > > --- > Acked-by: Narcisa Vasile Hi Thomas, Ping to see if the patch can be applied? Thanks William