From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 29F55A052A; Fri, 10 Jul 2020 21:24:00 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id F1FFF1DE91; Fri, 10 Jul 2020 21:23:59 +0200 (CEST) Received: from mail-ot1-f66.google.com (mail-ot1-f66.google.com [209.85.210.66]) by dpdk.org (Postfix) with ESMTP id E2A331DE7C for ; Fri, 10 Jul 2020 21:23:58 +0200 (CEST) Received: by mail-ot1-f66.google.com with SMTP id w17so5006022otl.4 for ; Fri, 10 Jul 2020 12:23:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=radio-canada-ca.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=bF7+bDXkRcxp6WJaqehZrhaMQLdWNIp+pI3Aj4gprnI=; b=wU7iGYKHFSsAMwf6o9wAkwqUUXKseXgefDnjBzLgrTM2o/3JHaK5Rf6sfXYrlbRtUN yOAvXBeX9C7z0+WD5vlmU9N9I/sKQkZ7ykkNYt6EJCfSrS3Zrwl0dI5YgSZCu5mdMGG8 +FDmzMNmLknhmhUfoGKpzpZoak9PtXcGGSNg0dYZYmKBG1+ABukrup3z+F4uQ86o9F1j huOVoye5zD/WZJjpXmwGnt16qGeEWYK3OE9L+HeWxaF1LivCWKCUxs5FCuPHGjJ7hW9S JwaLrd4eb2uBMW6L36yLCi/Vw3SukOQqBMkm3BC6vDe1ZeZXsDQ6LT7XqRueZX19toit 23IQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=bF7+bDXkRcxp6WJaqehZrhaMQLdWNIp+pI3Aj4gprnI=; b=eD2WtlTKQclisxyX2w+s4iVaLIhzrHjcdnXKZpgCsuTBwVj522k8b36d6Nmj7QdLnG +TY5Kb3MtFMsYg1gJKXwCdcNTMDT2RxjeeN57pBpOOxk5ZaRUFY/GuFdc/t0PqHXW90W kklLlhDGO//H4ynEaDNQdH91uGFM09LB/t7OQCYcCpNdn+5ibL7AHvbO6uuqucVK3Uph E5bg+ORmCr9CHWViG2Rh1anIveFWP1RSv8/FKbUEB3mIUritJ2uPShDSlAp4nGCKZItm bLQtLVoXVfEFUHXznAekBltNBQJ05YjrRkZ87LwBSuM2vyMbAjRdtmzMc12aGkckg6n/ mYwQ== X-Gm-Message-State: AOAM530HBpgWVn2JwJZ0RfmPl6uyUYXId9x2FKnqIgg+JenKW6yeHt5/ 5qv5aD6qYZt5Qjuc3EyaBcnHcXWA0gBhcMRQMFZD3g== X-Google-Smtp-Source: ABdhPJw1S8iJ8eqi5uPsl2e5C6INFLLPlQRjV9ElQZoORYUa5MloccevCwSdeCpGfrVuZ7AyTvxHolCHF5mrSMWDfd4= X-Received: by 2002:a05:6830:2405:: with SMTP id j5mr17565532ots.340.1594409038200; Fri, 10 Jul 2020 12:23:58 -0700 (PDT) MIME-Version: 1.0 References: <20200625190119.265739-1-vivien.didelot@gmail.com> <20200625190119.265739-4-vivien.didelot@gmail.com> <20200626064817.GW12564@platinum> <20200707144729.GK5869@platinum> In-Reply-To: <20200707144729.GK5869@platinum> From: PATRICK KEROULAS Date: Fri, 10 Jul 2020 15:23:46 -0400 Message-ID: To: Olivier Matz Cc: Vivien Didelot , dev@dpdk.org, Ferruh Yigit , Slava Ovsiienko Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [RFC PATCH 3/3] net/pcap: support hardware Tx timestamps X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hello Olivier and Slava, On Tue, Jul 7, 2020 at 10:47 AM Olivier Matz wrote: > For the pmd pcap part, the dynamic Tx timestamp flag that is being > introduced by Slava [1] may fit your needs: ie. when the flag is set, it > uses the provided timestamp which should be in nanosecs. > > [1] https://patchwork.dpdk.org/patch/73427/ > > For the conversion from hardware Rx timestamp into Tx timestamp (in > nanosec), could it be done by your application? Early in the Rx path, if > a packet has a Rx timestamp flag, do the conversion to nsecs, and set > the timestamp field and the Tx timestamp flag. Just to be clear, we use testpmd and dpdk-pdump rather than developing our own app. The application I mentioned earlier is a pcap analyzer and has nothing to do with dpdk. Could you help me identify a location where to set this dyn Tx field and flag? My current Rx data path includes drivers/net/mlx5/mlx5_rxtx_vec_sse.h Is it a good candidate? For the unit conversion, I finally followed the recommendations of using start_time & clock_freq rather than libibverbs. The time accuracy looks similarly good, based on pcap analysis. The conversion is performed in rte_pdump, is that acceptable? Thanks, PK