From: "Stanisław Kardach" <kda@semihalf.com>
To: David Marchand <david.marchand@redhat.com>
Cc: dev@dpdk.org, Stephen Hemminger <stephen@networkplumber.org>,
Bruce Richardson <bruce.richardson@intel.com>,
Zhangfei Gao <zhangfei.gao@linaro.org>,
Ruifeng Wang <ruifeng.wang@arm.com>,
Ajit Khaparde <ajit.khaparde@broadcom.com>,
Raveendra Padasalagi <raveendra.padasalagi@broadcom.com>,
Vikas Gupta <vikas.gupta@broadcom.com>,
Elena Agostini <eagostini@nvidia.com>,
Min Zhou <zhoumin@loongson.cn>,
Shepard Siegel <shepard.siegel@atomicrules.com>,
Ed Czeck <ed.czeck@atomicrules.com>,
John Miller <john.miller@atomicrules.com>,
Zyta Szpak <zr@semihalf.com>, Liron Himi <lironh@marvell.com>,
Nithin Dabilpuram <ndabilpuram@marvell.com>,
Kiran Kumar K <kirankumark@marvell.com>,
Sunil Kumar Kori <skori@marvell.com>,
Satha Rao <skoteshwar@marvell.com>,
David Hunt <david.hunt@intel.com>,
Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>,
Narcisa Ana Maria Vasile <navasile@linux.microsoft.com>,
Dmitry Malloy <dmitrym@microsoft.com>,
Pallavi Kadam <pallavi.kadam@intel.com>
Subject: Re: [PATCH v2] doc: avoid meson deprecation in setup
Date: Tue, 22 Nov 2022 13:00:19 +0100 [thread overview]
Message-ID: <CALVGJW+FTz-SS8vJV_ZhAazBH3w8gWCwMYfehfCP8Jore3-RNQ@mail.gmail.com> (raw)
In-Reply-To: <20221122113739.2486678-1-david.marchand@redhat.com>
On Tue, Nov 22, 2022 at 12:38 PM David Marchand
<david.marchand@redhat.com> wrote:
>
> From: Stephen Hemminger <stephen@networkplumber.org>
>
> The command "meson build" causes a deprecation warning with meson 0.64.0.
>
> WARNING: Running the setup command as `meson [options]` instead of
> `meson setup [options]` is ambiguous and deprecated.
>
> Therefore fix the examples in the documentation.
>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>
> Acked-by: Zhangfei Gao <zhangfei.gao@linaro.org>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
> Changes since v1:
> - fixed commitlog,
> - dropped unrelated changes (and sometimes broken),
> - fixed all (I am probably too optimistic) other occurences in the doc,
>
> ---
> doc/guides/cryptodevs/armv8.rst | 2 +-
> doc/guides/cryptodevs/bcmfs.rst | 2 +-
> doc/guides/cryptodevs/uadk.rst | 2 +-
> doc/guides/freebsd_gsg/build_dpdk.rst | 2 +-
> doc/guides/gpus/cuda.rst | 6 +--
> doc/guides/howto/openwrt.rst | 2 +-
> doc/guides/linux_gsg/build_dpdk.rst | 8 ++--
> .../linux_gsg/cross_build_dpdk_for_arm64.rst | 12 +++---
> .../cross_build_dpdk_for_loongarch.rst | 2 +-
> .../linux_gsg/cross_build_dpdk_for_riscv.rst | 4 +-
> doc/guides/nics/ark.rst | 2 +-
> doc/guides/nics/mvneta.rst | 2 +-
> doc/guides/nics/mvpp2.rst | 2 +-
> doc/guides/platform/bluefield.rst | 4 +-
> doc/guides/platform/cnxk.rst | 8 ++--
> doc/guides/platform/octeontx.rst | 8 ++--
> doc/guides/prog_guide/build-sdk-meson.rst | 39 +++++++++++--------
> doc/guides/prog_guide/lto.rst | 2 +-
> doc/guides/prog_guide/profile_app.rst | 4 +-
> .../sample_app_ug/vm_power_management.rst | 4 +-
> doc/guides/windows_gsg/build_dpdk.rst | 4 +-
> 21 files changed, 63 insertions(+), 58 deletions(-)
>
> diff --git a/doc/guides/cryptodevs/armv8.rst b/doc/guides/cryptodevs/armv8.rst
> index 8963f66a20..1a006754cb 100644
> --- a/doc/guides/cryptodevs/armv8.rst
> +++ b/doc/guides/cryptodevs/armv8.rst
> @@ -47,7 +47,7 @@ To build DPDK with this virtual crypto PMD, the user is required to:
>
> .. code-block:: console
>
> - meson build
> + meson setup build
> ninja -C build
>
> The corresponding device can be created only if the following features
> diff --git a/doc/guides/cryptodevs/bcmfs.rst b/doc/guides/cryptodevs/bcmfs.rst
> index f5dcd59c87..d18a253913 100644
> --- a/doc/guides/cryptodevs/bcmfs.rst
> +++ b/doc/guides/cryptodevs/bcmfs.rst
> @@ -70,7 +70,7 @@ for cross compiling on x86 platform.
> .. code-block:: console
>
> cd <DPDK-source-directory>
> - meson <dest-dir> --cross-file config/arm/arm64_stingray_linux_gcc
> + meson setup <dest-dir> --cross-file config/arm/arm64_stingray_linux_gcc
> cd <dest-dir>
> ninja
>
> diff --git a/doc/guides/cryptodevs/uadk.rst b/doc/guides/cryptodevs/uadk.rst
> index 1325eaca3f..9af6b88a5a 100644
> --- a/doc/guides/cryptodevs/uadk.rst
> +++ b/doc/guides/cryptodevs/uadk.rst
> @@ -87,7 +87,7 @@ Test steps
>
> cd dpdk
> mkdir build
> - meson build (--reconfigure)
> + meson setup build (--reconfigure)
> cd build
> ninja
> sudo ninja install
> diff --git a/doc/guides/freebsd_gsg/build_dpdk.rst b/doc/guides/freebsd_gsg/build_dpdk.rst
> index d335b97cfc..514d18c870 100644
> --- a/doc/guides/freebsd_gsg/build_dpdk.rst
> +++ b/doc/guides/freebsd_gsg/build_dpdk.rst
> @@ -44,7 +44,7 @@ Building DPDK
> The following commands can be used to build and install DPDK on a system.
> The final, install, step generally needs to be run as root::
>
> - meson build
> + meson setup build
> cd build
> ninja
> ninja install
> diff --git a/doc/guides/gpus/cuda.rst b/doc/guides/gpus/cuda.rst
> index 55fc7d1e86..114e3bc8cb 100644
> --- a/doc/guides/gpus/cuda.rst
> +++ b/doc/guides/gpus/cuda.rst
> @@ -24,8 +24,8 @@ You need to indicate to meson where CUDA headers files are through the CFLAGS va
> Three ways:
>
> - Set ``export CFLAGS=-I/usr/local/cuda/include`` before building
> -- Add CFLAGS in the meson command line ``CFLAGS=-I/usr/local/cuda/include meson build``
> -- Add the ``-Dc_args`` in meson command line ``meson build -Dc_args=-I/usr/local/cuda/include``
> +- Add CFLAGS in the meson command line ``CFLAGS=-I/usr/local/cuda/include meson setup build``
> +- Add the ``-Dc_args`` in meson command line ``meson setup build -Dc_args=-I/usr/local/cuda/include``
>
> If headers are not found, the CUDA GPU driver library is not built.
>
> @@ -51,7 +51,7 @@ An example would be:
>
> .. code-block:: console
>
> - $ meson build -Dc_args="-I/usr/local/cuda/include -I/path/to/gdrcopy/include"
> + $ meson setup build -Dc_args="-I/usr/local/cuda/include -I/path/to/gdrcopy/include"
>
> If headers are not found, the CUDA GPU driver library is built without the CPU map capability
> and will return error if the application invokes the gpudev ``rte_gpu_mem_cpu_map`` function.
> diff --git a/doc/guides/howto/openwrt.rst b/doc/guides/howto/openwrt.rst
> index e1d7db2a90..be902c505f 100644
> --- a/doc/guides/howto/openwrt.rst
> +++ b/doc/guides/howto/openwrt.rst
> @@ -100,7 +100,7 @@ first.
> ar = 'x86_64-openwrt-linux-ar'
> strip = 'x86_64-openwrt-linux-strip'
>
> - meson builddir --cross-file openwrt-cross
> + meson setup builddir --cross-file openwrt-cross
> ninja -C builddir
>
> Running DPDK application on OpenWrt
> diff --git a/doc/guides/linux_gsg/build_dpdk.rst b/doc/guides/linux_gsg/build_dpdk.rst
> index 4f2def15ed..bbd2efc9d8 100644
> --- a/doc/guides/linux_gsg/build_dpdk.rst
> +++ b/doc/guides/linux_gsg/build_dpdk.rst
> @@ -53,7 +53,7 @@ To configure a DPDK build use:
>
> .. code-block:: console
>
> - meson <options> build
> + meson setup <options> build
>
> where "build" is the desired output build directory, and "<options>" can be
> empty or one of a number of meson or DPDK-specific build options, described
> @@ -140,7 +140,7 @@ automatically built as part of a meson build too.
> To do so, pass a comma-separated list of the examples to build to the
> `-Dexamples` meson option as below::
>
> - meson -Dexamples=l2fwd,l3fwd build
> + meson setup -Dexamples=l2fwd,l3fwd build
>
> As with other meson options, this can also be set post-initial-config using `meson configure` in the build directory.
> There is also a special value "all" to request that all example applications whose
> @@ -166,12 +166,12 @@ The following meson command can be used on RHEL/Fedora systems to configure a 32
> assuming the relevant 32-bit development packages, such as a 32-bit libc, are installed::
>
> PKG_CONFIG_LIBDIR=/usr/lib/pkgconfig \
> - meson -Dc_args='-m32' -Dc_link_args='-m32' build
> + meson setup -Dc_args='-m32' -Dc_link_args='-m32' build
>
> For Debian/Ubuntu systems, the equivalent command is::
>
> PKG_CONFIG_LIBDIR=/usr/lib/i386-linux-gnu/pkgconfig \
> - meson -Dc_args='-m32' -Dc_link_args='-m32' build
> + meson setup -Dc_args='-m32' -Dc_link_args='-m32' build
>
> Once the build directory has been configured,
> DPDK can be compiled using ``ninja`` as described above.
> diff --git a/doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst b/doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst
> index cbe9d171f8..e4de5c8d18 100644
> --- a/doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst
> +++ b/doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst
> @@ -167,19 +167,19 @@ Cross Compiling DPDK with GNU toolchain using Meson
> To cross-compile DPDK on a desired target machine we can use the following
> command::
>
> - meson cross-build --cross-file <target_machine_configuration>
> + meson setup cross-build --cross-file <target_machine_configuration>
> ninja -C cross-build
>
> For example if the target machine is aarch64 we can use the following
> command, provided the cross file has been modified accordingly::
>
> - meson aarch64-build-gcc --cross-file config/arm/arm64_armv8_linux_gcc
> + meson setup aarch64-build-gcc --cross-file config/arm/arm64_armv8_linux_gcc
> ninja -C aarch64-build-gcc
>
> If the target machine is aarch32 we can use the following command,
> provided the cross file has been modified accordingly::
>
> - meson aarch32-build --cross-file config/arm/arm32_armv8_linux_gcc
> + meson setup aarch32-build --cross-file config/arm/arm32_armv8_linux_gcc
> ninja -C aarch32-build
>
> LLVM/Clang toolchain
> @@ -230,7 +230,7 @@ Assuming the file with augmented ``c_args`` and ``c_link_args``
> is named ``arm64_armv8_linux_clang``,
> use the following command to cross-compile DPDK for the target machine::
>
> - meson aarch64-build-clang --cross-file config/arm/arm64_armv8_linux_clang
> + meson setup aarch64-build-clang --cross-file config/arm/arm64_armv8_linux_clang
> ninja -C aarch64-build-clang
>
> Cross Compiling DPDK with LLVM/Clang toolchain using Meson on Ubuntu 18.04
> @@ -247,7 +247,7 @@ On Ubuntu 18.04, these packages are needed:
>
> Use the following command to cross-compile DPDK for the target machine::
>
> - meson aarch64-build-clang --cross-file config/arm/arm64_armv8_linux_clang_ubuntu1804
> + meson setup aarch64-build-clang --cross-file config/arm/arm64_armv8_linux_clang_ubuntu1804
> ninja -C aarch64-build-clang
>
> Building for an aarch64 SoC on an aarch64 build machine
> @@ -258,7 +258,7 @@ you don't need a separate cross toolchain, just a different set of
> configuration options. To build for an aarch64 SoC, use the -Dplatform meson
> option::
>
> - meson soc_build -Dplatform=<target_soc>
> + meson setup soc_build -Dplatform=<target_soc>
>
> Substitute <target_soc> with one of the supported SoCs
>
> diff --git a/doc/guides/linux_gsg/cross_build_dpdk_for_loongarch.rst b/doc/guides/linux_gsg/cross_build_dpdk_for_loongarch.rst
> index 1549cc86d5..7f75960e9e 100644
> --- a/doc/guides/linux_gsg/cross_build_dpdk_for_loongarch.rst
> +++ b/doc/guides/linux_gsg/cross_build_dpdk_for_loongarch.rst
> @@ -81,7 +81,7 @@ To cross-compile DPDK for generic LoongArch we can use the following command:
>
> .. code-block:: console
>
> - meson cross-build --cross-file config/loongarch/loongarch_loongarch64_linux_gcc
> + meson setup cross-build --cross-file config/loongarch/loongarch_loongarch64_linux_gcc
> ninja -C cross-build
>
> Supported cross-compilation targets
> diff --git a/doc/guides/linux_gsg/cross_build_dpdk_for_riscv.rst b/doc/guides/linux_gsg/cross_build_dpdk_for_riscv.rst
> index 9e121645a8..7d7f7ac72b 100644
> --- a/doc/guides/linux_gsg/cross_build_dpdk_for_riscv.rst
> +++ b/doc/guides/linux_gsg/cross_build_dpdk_for_riscv.rst
> @@ -68,13 +68,13 @@ Cross Compiling DPDK with GNU toolchain using Meson
>
> To cross-compile DPDK for a desired target machine use the following command::
>
> - meson cross-build --cross-file <target_machine_configuration>
> + meson setup cross-build --cross-file <target_machine_configuration>
> ninja -C cross-build
>
> For example if the target machine is a generic rv64gc RISC-V, use the following
> command::
>
> - meson riscv64-build-gcc --cross-file config/riscv/riscv64_linux_gcc
> + meson setup riscv64-build-gcc --cross-file config/riscv/riscv64_linux_gcc
> ninja -C riscv64-build-gcc
>
> If riscv-gnu-toolchain is used, binary names should be updated to match. Update
> <snip>
Thanks for fixing this!
Acked-by: Stanislaw Kardach <kda@semihalf.com>
--
Best Regards,
Stanisław Kardach
next prev parent reply other threads:[~2022-11-22 12:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-15 17:35 [PATCH] " Stephen Hemminger
2022-11-15 17:38 ` Bruce Richardson
2022-11-16 8:24 ` David Marchand
2022-11-16 1:24 ` Zhangfei Gao
2022-11-17 8:57 ` Ruifeng Wang
2022-11-22 11:37 ` [PATCH v2] " David Marchand
2022-11-22 12:00 ` Stanisław Kardach [this message]
2022-11-22 15:20 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALVGJW+FTz-SS8vJV_ZhAazBH3w8gWCwMYfehfCP8Jore3-RNQ@mail.gmail.com \
--to=kda@semihalf.com \
--cc=ajit.khaparde@broadcom.com \
--cc=bruce.richardson@intel.com \
--cc=david.hunt@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=dmitry.kozliuk@gmail.com \
--cc=dmitrym@microsoft.com \
--cc=eagostini@nvidia.com \
--cc=ed.czeck@atomicrules.com \
--cc=john.miller@atomicrules.com \
--cc=kirankumark@marvell.com \
--cc=lironh@marvell.com \
--cc=navasile@linux.microsoft.com \
--cc=ndabilpuram@marvell.com \
--cc=pallavi.kadam@intel.com \
--cc=raveendra.padasalagi@broadcom.com \
--cc=ruifeng.wang@arm.com \
--cc=shepard.siegel@atomicrules.com \
--cc=skori@marvell.com \
--cc=skoteshwar@marvell.com \
--cc=stephen@networkplumber.org \
--cc=vikas.gupta@broadcom.com \
--cc=zhangfei.gao@linaro.org \
--cc=zhoumin@loongson.cn \
--cc=zr@semihalf.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).