From: "Stanisław Kardach" <kda@semihalf.com>
To: David Marchand <david.marchand@redhat.com>
Cc: Olivier Matz <olivier.matz@6wind.com>, dev <dev@dpdk.org>,
dpdk stable <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH 0/3] add lock-free stack support discovery
Date: Mon, 19 Apr 2021 16:44:34 +0200 [thread overview]
Message-ID: <CALVGJWKC2cbT4n1kX5Wyy8WPWidVDUx7-gge6MApgQL9--ZCRw@mail.gmail.com> (raw)
In-Reply-To: <CAJFAV8wjBL4yCS06kex8ugQkr+BumHZVsFE4LS8HDDkYXbdHuw@mail.gmail.com>
On Fri, Apr 16, 2021 at 08:34:29AM +0200, David Marchand wrote:
> On Mon, Apr 12, 2021 at 10:29 AM Stanislaw Kardach <kda@semihalf.com> wrote:
> >
> > The lock-free stack implementation (RTE_STACK_F_LF) is supported only on a
> > subset of platforms, namely x86_64 and arm64. Platforms supporting 128b atomics
> > have to opt-in to a generic or C11 implementations. All other platforms use a
> > stubbed implementation for push/pop operations which are basically NOPs.
> > However rte_stack_create() will not fail and application can proceed assuming
> > it has a working lock-free stack.
>
> Did you actually hit this issue or is this only theoretical?
> I can only think of ppc64 displaying such behavior.
>
I actually hit this issue while working on a RISC-V port.
My reasoning here is that sooner or later someone else will stumble upon
this, either on ppc64 or while trying to port to some new platform.
It is also a really nasty limitation do debug given the silent nature of
the failure.
>
> --
> David Marchand
>
--
Best Regards,
Stanislaw Kardach
next prev parent reply other threads:[~2021-04-19 14:44 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-12 8:28 Stanislaw Kardach
2021-04-12 8:28 ` [dpdk-dev] [PATCH 1/3] stack: update lock-free supported archs Stanislaw Kardach
2021-04-27 13:54 ` Olivier Matz
2021-04-12 8:29 ` [dpdk-dev] [PATCH 2/3] stack: add lock-free support indication Stanislaw Kardach
2021-04-27 13:54 ` Olivier Matz
2021-04-12 8:29 ` [dpdk-dev] [PATCH 3/3] test: run lock-free stack tests when supported Stanislaw Kardach
2021-04-27 13:55 ` Olivier Matz
2021-04-16 6:34 ` [dpdk-dev] [PATCH 0/3] add lock-free stack support discovery David Marchand
2021-04-19 14:44 ` Stanisław Kardach [this message]
2021-05-03 14:21 ` David Marchand
2021-05-03 14:28 ` Olivier Matz
2021-05-03 18:34 ` Stanisław Kardach
2021-05-04 6:44 ` David Marchand
2021-05-04 6:44 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALVGJWKC2cbT4n1kX5Wyy8WPWidVDUx7-gge6MApgQL9--ZCRw@mail.gmail.com \
--to=kda@semihalf.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=olivier.matz@6wind.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).