From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id B0512A0032;
	Wed, 11 May 2022 16:19:17 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 5A98B40DDD;
	Wed, 11 May 2022 16:19:17 +0200 (CEST)
Received: from mail-lf1-f44.google.com (mail-lf1-f44.google.com
 [209.85.167.44]) by mails.dpdk.org (Postfix) with ESMTP id D3596406B4
 for <dev@dpdk.org>; Wed, 11 May 2022 16:19:15 +0200 (CEST)
Received: by mail-lf1-f44.google.com with SMTP id d15so3860345lfk.5
 for <dev@dpdk.org>; Wed, 11 May 2022 07:19:15 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=semihalf-com.20210112.gappssmtp.com; s=20210112;
 h=mime-version:references:in-reply-to:from:date:message-id:subject:to
 :cc; bh=7EdN0QDGTDHHr14DAsuykSdQBfxECZ70v3WiuRE3RO8=;
 b=NC850J6EOEqljVmNB/wUiZI/uL4eb05ALYiuZJXQG6vOrjL/i8NL5GuhX9Fqu7QxyH
 nevMbvZmTXTyAJzvcfP02YpqxGpcGFyRaTDn05o9I6d6nuOTnBPawZ2g/LwnknCwaEH1
 ZAhygQ9zJHOIp+XsFYi66jDKFZKheGXplPGmQZTc0C6hqDrUR3g+mzalJ1DaCN0Jzh/5
 tuX0HT+lfJ0PDWpu7U4CHc+e4Y1yiPH7jch/Sj8qA0BF9DJjmiDx4eGEi5m/VjagYH6W
 ESfwkPPO/SMZSleRZwy9+ZCUX+a+3JHrv9+jf5piqrb7cehPUksw7RZ53UmSosMAwuVy
 V21A==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=7EdN0QDGTDHHr14DAsuykSdQBfxECZ70v3WiuRE3RO8=;
 b=CTrJGTCVd0KNeUEKYoJ6/d2QnpZcVOywpzQgdTSxNQEcjoBmF5sHe+AE2VF48+JXDq
 KYjBkDt+yU49s1FfM57Xm1omrTcBRvCdPpVyHJ7NZHGnNjyo9pKCFuBL+ZzkV6qE3CZA
 F0yjFo+XrucjsxqyqrNLEhyjRp/+jRGgfyKdg9iYUFUIlZm0jKY2minWZTNX+8G2Ch4M
 3+1q0k6v5NvvyiW+PXsuWPmvdLJgNetA/6ffpiUZrb5rHHA++cBjmCFkuVHpRJ4eYCpj
 qjEaKb9JAX4UfJQa5MVQNaXGmY7l3RwGqnuWw2l/+Zjo1g6QBfy2UGdV2k/6hPeFSHkT
 rrbA==
X-Gm-Message-State: AOAM532YdWZyeDTd4cfuwhwhnjBXcR9dSPv5x36F0f7xo5TfBpdIFROd
 0RM55ZmshN7vY0OKx1SfjVn0zWIYA48miTG0xJeQeQ==
X-Google-Smtp-Source: ABdhPJyzsWo4QO4NegwqGzkkhbpNUvnWLm8M+vt+jjovSSLy58RjY5xq0XynvANOQvTcHucGS9oekRL1JkDq9OMjpVk=
X-Received: by 2002:a05:6512:ace:b0:473:b1fb:6c2e with SMTP id
 n14-20020a0565120ace00b00473b1fb6c2emr20483902lfu.394.1652278755299; Wed, 11
 May 2022 07:19:15 -0700 (PDT)
MIME-Version: 1.0
References: <20220510115844.458009-1-kda@semihalf.com>
 <CAJFAV8xNBTw2f9L=rp=J8-ovxcO0bFBKRYQFLA3xEg+DXLZGsQ@mail.gmail.com>
In-Reply-To: <CAJFAV8xNBTw2f9L=rp=J8-ovxcO0bFBKRYQFLA3xEg+DXLZGsQ@mail.gmail.com>
From: =?UTF-8?Q?Stanis=C5=82aw_Kardach?= <kda@semihalf.com>
Date: Wed, 11 May 2022 16:18:39 +0200
Message-ID: <CALVGJWLhgmYMdeYEfRX6DXH2xcBQkzT72Ev6XZ06N-PceVtfPg@mail.gmail.com>
Subject: Re: [PATCH 1/1] examples/l3fwd: fix scalar LPM compilation
To: David Marchand <david.marchand@redhat.com>
Cc: dev <dev@dpdk.org>, Frank Zhao <Frank.Zhao@starfivetech.com>, 
 Sam Grove <sam.grove@sifive.com>, Marcin Wojtas <mw@semihalf.com>,
 upstream@semihalf.com, Pavan Nikhilesh <pbhagavatula@marvell.com>, 
 Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>, 
 Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>
Content-Type: text/plain; charset="UTF-8"
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On Wed, May 11, 2022 at 1:39 PM David Marchand
<david.marchand@redhat.com> wrote:
<snip>
> Based on the vector specific implemtations of process_packet in this
> example, this code could be replaced with a call to rfc1812_process().
> Eth macs updates can be moved prior to rfc1812_process.
>
> What do you think of (untested):
That actually looks a lot better! Though it seems safer to use
rte_pktmbuf_mtod_offset() for getting the ipv4_hdr. I'll post V2 with
this update.