From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 336C84333B; Thu, 16 Nov 2023 00:21:28 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EB787402C4; Thu, 16 Nov 2023 00:21:27 +0100 (CET) Received: from mail-qv1-f43.google.com (mail-qv1-f43.google.com [209.85.219.43]) by mails.dpdk.org (Postfix) with ESMTP id 0CD724025F for ; Thu, 16 Nov 2023 00:21:26 +0100 (CET) Received: by mail-qv1-f43.google.com with SMTP id 6a1803df08f44-66d0f945893so1766676d6.1 for ; Wed, 15 Nov 2023 15:21:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf.com; s=google; t=1700090485; x=1700695285; darn=dpdk.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=X//now7cwA/FHH52ugYy1XiXzWuu8yPavB0LqpGcLlA=; b=DfxbLwc5wb2LZ/8y767t5oedvDmI3DnPkNfj+S/APAnj7oAqsdCDz6qHE/sZaN5YSu QHWRXXb6uWP1fdrVVr7qtzkQehR92lOwOYRL9aTQWs7k3j3waFZPmaNkEJGZ0Xvu2n8E EijIFvpR63snuEklHziTiVN+C4WIOsAQ5qrHNPwfvb+X4kFLMYDBbSDvuOjD98pmMDNl S6a0dXzU7F6VyhO7YAb3AO+pF0cCgzUKLJ0mERm+2WJylm6oyAk6jj0vt/j1MpLFYwQv EbbdEzGT2kqfVr0udkLCA8yrt8doNrzcHzhaQ6Le9EMgQSQqHtuC1e9JJCaRLhx4bsxT RVXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700090485; x=1700695285; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=X//now7cwA/FHH52ugYy1XiXzWuu8yPavB0LqpGcLlA=; b=MDHskO7uTRVqobq46NmYWS8HTsb/oSmlwJ5WpwEoprgQ9W3v+u8X94wD0xjZPGbDyn VezmsFc5t830wOTQxjLxLEoGB0JgGXcTjcTHEwUcES5lM5xl8myJn75YyITbbTftP2rF pyxqchcizyZgTdLgyu+oPpLjBZ02+ltgAgxtQm+OkI2obgt0m9XpLBuiKgxNjEKRbm8x J7DCOVpNbhIesh24I92xhaUmk1wquKDI89QiFUd1LZVn/0z8uCI9FW4WIaew2tmXsJMr ulhKk37MF/uE5/NXqxi8YHjFKR4rFqAdkhXPgJ0Y2kdKmSPJ3WBNoQhumQYOTb1vwg6F YS2A== X-Gm-Message-State: AOJu0YysejkigmU67STMMZHXc8mvDfhXMFyl1VVbYuU6OVNZN90LkD3h SP4ksasaN29b5tlIz9hxR5pRraaIAMoYVQMQesCmfg== X-Google-Smtp-Source: AGHT+IHODcVOqJ9js0J2vbQmF3UX0pNnQiXLzoZqAWZD7LaM6BbPGTgzPFyXwqbFtpDXUqvzArHbHYdxuj8e5dUxRD0= X-Received: by 2002:a05:6214:2b49:b0:66f:b9ef:9636 with SMTP id jy9-20020a0562142b4900b0066fb9ef9636mr9586767qvb.32.1700090485392; Wed, 15 Nov 2023 15:21:25 -0800 (PST) MIME-Version: 1.0 References: <1700083003-6641-1-git-send-email-roretzla@linux.microsoft.com> <98CBD80474FA8B44BF855DF32C47DC35E9F032@smartserver.smartshare.dk> In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35E9F032@smartserver.smartshare.dk> From: =?UTF-8?Q?Stanis=C5=82aw_Kardach?= Date: Thu, 16 Nov 2023 00:20:48 +0100 Message-ID: Subject: Re: [PATCH] eal: fix alignment of RISCV xmm vector type To: =?UTF-8?Q?Morten_Br=C3=B8rup?= Cc: Tyler Retzlaff , dev@dpdk.org, Michal Mazurek , stable@dpdk.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Nov 15, 2023 at 10:31=E2=80=AFPM Morten Br=C3=B8rup wrote: > > > From: Tyler Retzlaff [mailto:roretzla@linux.microsoft.com] > > Sent: Wednesday, 15 November 2023 22.17 > > > > Fix the alignment for rte_xmm_t it should be 16 instead of 8 bytes. > > > > Fixes: f22e705ebf12 ("eal/riscv: support RISC-V architecture") > > Cc: maz@semihalf.com > > Cc: stable@dpdk.org > > Signed-off-by: Tyler Retzlaff > > --- > > Reviewed-by: Morten Br=C3=B8rup > > As mentioned in the other thread: > > We need to urgently decide if this bug should live on in DPDK 23.11, or i= f the fix should be included although we are very late in the release proce= ss. > > Stanislaw, what do you think? Good catch! As for backporting I'm not sure of the urgency given that our examples still use scalar instructions for handling xmm_t. The question is whether there is a platform in use which has vector extensions enabled and that utilizes DPDK. I'm not that sure of it though I'd be happy to be proven wrong. Reviewed-by: Stanislaw Kardach > > Furthermore, I wonder if it can be backported to stable, and to what exte= nt backporting it would break the ABI/API. > -- Best Regards, Stanis=C5=82aw Kardach