From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A6D2FA04B6; Mon, 24 Aug 2020 23:51:44 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id DBD8E1C0AE; Mon, 24 Aug 2020 23:51:43 +0200 (CEST) Received: from mail-lj1-f195.google.com (mail-lj1-f195.google.com [209.85.208.195]) by dpdk.org (Postfix) with ESMTP id 33F531C07B for ; Mon, 24 Aug 2020 23:51:43 +0200 (CEST) Received: by mail-lj1-f195.google.com with SMTP id m22so11434897ljj.5 for ; Mon, 24 Aug 2020 14:51:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=atomicrules-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=E256dvjZ8KgVT+4Fsnld10WefuxWqhSWObzQgSW1TTM=; b=aVfH+e9Rh6rX3c6O4vVFaxZVOtC/q+w5Xtx51wUOQxSZ6txx+0KT47jHyB2hcqgQPD 3ZOO9d+mT8w8MDJQZ68QbXJFqYIaas+hG7nUFhUwcihseI4bLEXEGLLWuPH2Ku8WVKi2 SthmbHJP/Vk6iTF+y8YWmWnOgP/X+YCVEmLnwp7yJqOm8+yVNIhg8oQc4+H6ki/kFDBp 7UvUz2rUCynxF+UMXKUoMDQ7DbcUcqd+Vjs4L7hzeeuqQsSAe79mo8wv/KSRDjZ0jx4k jPHGQA8ebv+XHBgu1OdotV/SNbiebJK8F+9IEn7k9iuZzdMJUMsErVxwNqYQ+/XxwFXT 9eHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=E256dvjZ8KgVT+4Fsnld10WefuxWqhSWObzQgSW1TTM=; b=azNMaiK+yHnOKwF4LeHFeZBQYzg1qmbhFO+Mc1cglL9o97wT6VoVi31w+NIXX3Ilr4 JU12W/3AjJp4Edjad7uLYQ6kiBlR4NZqOwrTtjvyRsdQgZEtaBMLmGrGlDcYofZFVtkH DAJ7oUpGl7i5toer8eFg3eqPqgF362HtDnj8u1xKfLxCKi33KEC/Er/FZOIRpe5VU1ex hWbZwz1xnhKNFqmDdTp69LkSdZ+MT3OmwxZecjuFyzo0DHq7ulJK1x7wK7oe3vUkOFUJ g5HjaQqkEM9EZGkd1rN5hBXtUEjW794fyFDcepCS5OAqgOtbgkSU1llX5A61NyXGGCYw Pf4g== X-Gm-Message-State: AOAM530eCjcAEPXxhsrkQHiItnXioWOzhDKf4fLBfDq0ufot6k0ndIbN 9AjTZdKTJMWoM8NNjNq7mDE2xeqx0XdWb1FAKZLSDA== X-Google-Smtp-Source: ABdhPJxOEcwi0o9CGZCkxYozUUnMr6PdwVcUcobDeDN294ijG2JhN+M/dInw0dw5ff3tALy98Oe0aTygyR35xkr5IMg= X-Received: by 2002:a2e:8215:: with SMTP id w21mr3473232ljg.43.1598305902582; Mon, 24 Aug 2020 14:51:42 -0700 (PDT) MIME-Version: 1.0 References: <20200819153539.32698-1-ed.czeck@atomicrules.com> <20200824133641.19450-1-ed.czeck@atomicrules.com> <20200824133641.19450-2-ed.czeck@atomicrules.com> <7ec68135-b8b3-08c4-e5f2-4d52b047ca0f@intel.com> In-Reply-To: <7ec68135-b8b3-08c4-e5f2-4d52b047ca0f@intel.com> From: Ed Czeck Date: Mon, 24 Aug 2020 17:51:31 -0400 Message-ID: To: Ferruh Yigit Cc: dev@dpdk.org, "Richardson, Bruce" , Shepard Siegel , John Miller Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH 2/2] net/ark: remove RTE_LIBRTE_ARK_PAD_TX configuration macro X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Aug 24, 2020 at 10:55 AM Ferruh Yigit wrote: > > On 8/24/2020 2:36 PM, Ed Czeck wrote: > > Replace behavior with RTE_LIBRTE_ARK_MIN_TX_PKTLEN > > with a default value of 0. > > Update documentation as needed. > > > > Signed-off-by: Ed Czeck > > --- > > doc/guides/nics/ark.rst | 13 ++++++++-- > > drivers/net/ark/ark_ethdev_tx.c | 44 +++++++++++++++++++-------------- > > drivers/net/ark/ark_logs.h | 8 ------ > > 3 files changed, 36 insertions(+), 29 deletions(-) > > > > diff --git a/doc/guides/nics/ark.rst b/doc/guides/nics/ark.rst > > index c3ffcbbc2..f4d4539e5 100644 > > --- a/doc/guides/nics/ark.rst > > +++ b/doc/guides/nics/ark.rst > > @@ -129,8 +129,10 @@ Configuration Information > > * **CONFIG_RTE_LIBRTE_ARK_PMD** (default y): Enables or disables inclusion > > of the ARK PMD driver in the DPDK compilation. > > > > - * **CONFIG_RTE_LIBRTE_ARK_PAD_TX** (default y): When enabled TX > > - packets are padded to 60 bytes to support downstream MACS. > > + * **CONFIG_RTE_LIBRTE_ARK_MIN_TX_PKTLEN** (default 0): Sets the minimum > > + packet length for tx packets to the FPGA. Packets less than this > > + length are padded to meet the requirement. This allows padding to > > + be offloaded or remain in host software. > > > > There is no 'CONFIG_RTE_LIBRTE_ARK_MIN_TX_PKTLEN' option, I think it is > confusing to add it to documentation. There is already some documentation in > below for 'RTE_LIBRTE_ARK_MIN_TX_PKTLEN', what do you think removing this part? > Should I remove the all references to the CONFIG_RTE_LIBRTE_ARK from the net/ark section of the guide? It appears that CONFIG_.* will be removed along with the makefile build system. > And can you please remove 'CONFIG_RTE_LIBRTE_ARK_PAD_TX' form 'config/common_base'? > I am hesitant to modify config/common_base, since it is slated for removal and edits will cause merge conflicts. Are you OK with this? > Another option is, do you think does it help your users to keep the config name > same, like keep the 'CONFIG_RTE_LIBRTE_ARK_PAD_TX' as 'RTE_LIBRTE_ARK_PAD_TX' > for the meson CFLAGs, instead of renaming it to 'RTE_LIBRTE_ARK_MIN_TX_PKTLEN'? I will drop the CONFIG names and leave the compiler marco documented in my next patch. Thx,