From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A088CA04B5; Tue, 27 Oct 2020 16:32:18 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 5F6D16CAB; Tue, 27 Oct 2020 16:32:17 +0100 (CET) Received: from mail-lf1-f67.google.com (mail-lf1-f67.google.com [209.85.167.67]) by dpdk.org (Postfix) with ESMTP id E36086A15 for ; Tue, 27 Oct 2020 16:32:14 +0100 (CET) Received: by mail-lf1-f67.google.com with SMTP id c141so2881293lfg.5 for ; Tue, 27 Oct 2020 08:32:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=atomicrules-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=aCRGovLHT97HkH4+3dp0Fpio3lwrmGri3QlThsIwyk8=; b=aTlf5Z9t0lWTk9k5LKLyIHp906szJw+8HryO/6StJ/Fh43+izXH09RQWvFomVt5O28 KoerFSVouQRTMDBrPLhNjeQxF6G2akdVmgfLgTWTT4Bb7GnZUPhROewdDsg9we1759G9 HDrqs7pXZ6rWGhRm+eL302Qq+7t22rsWYxil3UAxth9uO0LiBY3vj9dVehB491wtjB5J q+HhGwslLTWaNePc4VffCn9W9Dz8f5+xAk7xrPWPeL+Vo0WY6lvOCgCb1f3lN5c5edLf kLo/Bz5DpMQBLZwkKfGPEJpVEqg3qYLuRdfGVr3PlwwZcvSssHHI+1jF1sR81KSygPOd u/PQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=aCRGovLHT97HkH4+3dp0Fpio3lwrmGri3QlThsIwyk8=; b=BwRsBdZwOQTgKjbqozrjUdcst2A9wBnxzW3+wT0KlPZGeEnGQW/K67V0goKB5DGnpu UCPK3lY89yFVHUD736aJACACgvCj1n/6+KiDchEOdTUfPBn4EmEKAOl+Xy3vHKs70FKm 9/jyAOf5dm7QnVfNqFZggflcW5OwlV3MxVl90tFeYv21hsEC0Lr/YXoLVz3r2sCnDCQP WrjRqxcodhPOWjbCAqPd6rezyJQRLCp82A0i5YO0OjM7V4lCJPsupshjXI7tWm0dgfV/ VUfKrggG9AjlDwaC3uGHRiG+Sk/MFINokL0jqj7xJxeDcE505XnVydxOjei48tZZDkKp uyNw== X-Gm-Message-State: AOAM531GEsKAmAbYcGCUuWPvuf7rnnmdrHlNL0EwLCDSPTNG0WdA9jRR MhgqQY1I6S5QElqG60+Na6US180TRv6YQLKWdsC02DbnEhNPQw== X-Google-Smtp-Source: ABdhPJyhnYMhA0PED6FouZ8vOVcy3ocA6LkQqCgtMTWBnZ/XyZ0D8bzbtqPGqe/noyvHwTJAtLHs2Qb6oZnpVtdwdFM= X-Received: by 2002:ac2:4183:: with SMTP id z3mr736045lfh.510.1603812734456; Tue, 27 Oct 2020 08:32:14 -0700 (PDT) MIME-Version: 1.0 References: <20201026052105.1561859-1-thomas@monjalon.net> <20201026222013.2147904-1-thomas@monjalon.net> <20201026222013.2147904-8-thomas@monjalon.net> In-Reply-To: <20201026222013.2147904-8-thomas@monjalon.net> From: Ed Czeck Date: Tue, 27 Oct 2020 11:32:03 -0400 Message-ID: To: Thomas Monjalon Cc: dev@dpdk.org, Ferruh Yigit , david.marchand@redhat.com, "Richardson, Bruce" , Olivier MATZ , andrew.rybchenko@oktetlabs.ru, akhil.goyal@nxp.com, Shepard Siegel , John Miller Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v2 07/15] net/ark: ignore user data X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" HI Thomas, Atomic Rules will be submitting a patch to connect user_data into the mbuf stuct using the dynfield interface restoring lost functionality from this patch. You can expect a patch in the next few days. Are you targeting this patch series for the 20.11 release? Thanks Ed. On Mon, Oct 26, 2020 at 6:20 PM Thomas Monjalon wrote: > > The second field of metadata is reserved for user data > which is a deprecated mbuf field. > The usage of mbuf udata64 is removed > and the corresponding ark metadata field is annotated as ignored. > > Signed-off-by: Thomas Monjalon > --- > drivers/net/ark/ark_ddm.h | 2 +- > drivers/net/ark/ark_ethdev_rx.c | 1 - > drivers/net/ark/ark_ethdev_tx.c | 1 - > drivers/net/ark/ark_udm.h | 2 +- > 4 files changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/net/ark/ark_ddm.h b/drivers/net/ark/ark_ddm.h > index 5456b4b5cc..99eded8524 100644 > --- a/drivers/net/ark/ark_ddm.h > +++ b/drivers/net/ark/ark_ddm.h > @@ -19,7 +19,7 @@ > /* struct defining Tx meta data -- fixed in FPGA -- 16 bytes */ > struct ark_tx_meta { > uint64_t physaddr; > - uint32_t user1; > + uint32_t user1; /* ignored */ > uint16_t data_len; /* of this MBUF */ > #define ARK_DDM_EOP 0x01 > #define ARK_DDM_SOP 0x02 > diff --git a/drivers/net/ark/ark_ethdev_rx.c b/drivers/net/ark/ark_ethdev_rx.c > index 2f8d05099c..5ead67e6b8 100644 > --- a/drivers/net/ark/ark_ethdev_rx.c > +++ b/drivers/net/ark/ark_ethdev_rx.c > @@ -272,7 +272,6 @@ eth_ark_recv_pkts(void *rx_queue, > mbuf->pkt_len = meta->pkt_len; > mbuf->data_len = meta->pkt_len; > mbuf->timestamp = meta->timestamp; > - mbuf->udata64 = meta->user_data; > > if (ARK_DEBUG_CORE) { /* debug sanity checks */ > if ((meta->pkt_len > (1024 * 16)) || > diff --git a/drivers/net/ark/ark_ethdev_tx.c b/drivers/net/ark/ark_ethdev_tx.c > index a0e35af880..8a0a9381f7 100644 > --- a/drivers/net/ark/ark_ethdev_tx.c > +++ b/drivers/net/ark/ark_ethdev_tx.c > @@ -70,7 +70,6 @@ eth_ark_tx_meta_from_mbuf(struct ark_tx_meta *meta, > uint8_t flags) > { > meta->physaddr = rte_mbuf_data_iova(mbuf); > - meta->user1 = (uint32_t)mbuf->udata64; > meta->data_len = rte_pktmbuf_data_len(mbuf); > meta->flags = flags; > } > diff --git a/drivers/net/ark/ark_udm.h b/drivers/net/ark/ark_udm.h > index 5846c825b8..ba436ee25b 100644 > --- a/drivers/net/ark/ark_udm.h > +++ b/drivers/net/ark/ark_udm.h > @@ -18,7 +18,7 @@ > /* Meta data structure apssed from FPGA, must match layout in FPGA */ > struct ark_rx_meta { > uint64_t timestamp; > - uint64_t user_data; > + uint64_t user_data; /* ignored */ > uint8_t port; > uint8_t dst_queue; > uint16_t pkt_len; > -- > 2.28.0 >