From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 31D7443A2A; Mon, 5 Feb 2024 22:12:35 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BA0AD40A67; Mon, 5 Feb 2024 22:12:34 +0100 (CET) Received: from mail-lf1-f52.google.com (mail-lf1-f52.google.com [209.85.167.52]) by mails.dpdk.org (Postfix) with ESMTP id 2CA7F4067E for ; Mon, 5 Feb 2024 22:12:33 +0100 (CET) Received: by mail-lf1-f52.google.com with SMTP id 2adb3069b0e04-5112bd13a4fso4385302e87.0 for ; Mon, 05 Feb 2024 13:12:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=atomicrules-com.20230601.gappssmtp.com; s=20230601; t=1707167552; x=1707772352; darn=dpdk.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=EYErzjKn+hx67N5g6YyAppuh1EJW2JIFTYhr/9xL1c8=; b=AYXF91l3l9tkKV9a9//RoB0CRukdAcJ561ozHaAa/beZ0gV0XVXTu/Cw/GfknB5SxR TDUB1CW97mLnvUj1UvuAYzh/NCE2avUb1jCJvdxw6042tFvlgH4hZDlkJ6YjGSZzba4e 6I638zWptUnFc0Qr0qZ2/ys7grHddMDT9Ey7iCBWEXO7yPoUt6zqIYWQUol0vcNiOydD lfaRmf3XmDT6VJroPNhKfZft6RwC9Xc6S28faqxeFVmDXyK/sCeP18oHtJMSWhHKCD0b indgZ80XlVYbq5VnutpHfl0nxvLUMNbn+XNPI3ZNja+6zhTwOohWScdj9TI9GLINb00M MBPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707167552; x=1707772352; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=EYErzjKn+hx67N5g6YyAppuh1EJW2JIFTYhr/9xL1c8=; b=rRG1wyHGs78JBkfKaD8oTZ6hbYNjrhRkfGXHmEnnKEq9kXifWCa2q7TJiRZ8L1rODQ g2A4tayFOM1FuA9Kyx0BeBhVPT1v2g3PWcT5fmdHcwIikc9DOdpD5112kTzbgN8ltMRq HjgOhvmAO6ZWdTf5w89aNsFLwMZAfynxB+lBBgMYqXL11OLjGpNwnERakx2GkwfHIE5b iyddYJXpulb60lcGSyJ58X+CsnEcqAxJ4ZTUYLwKQKbkYGrmZMhRW04r1ePReoWHHuzM aD8dCQVVWQaDPmemriWsAgScC8TZQSVeuPwSDyWBQwu3/rnV7Nw5ZTphe5HGxaG0PvQo pTHA== X-Gm-Message-State: AOJu0Yz6LuYb7jg+zasj5VRHbLpfvEkbwGYGrF+YbvGZqfZUCBjrpAA/ vowcdmImNG9HBuhPbzkH+wuh3+C7AM88Dn4uYieXIcFrjS3l+bYGuel6P1+PEUGgpw2QRQirl+w IBsD0S2h1TuQ3d7qpmhG7mWMjob3+cLrkPAY5WI+FnvXp5pLIkg== X-Google-Smtp-Source: AGHT+IE0jLLv6F9jldsbUvHIQI9cmGLnAnK6TzY5nblmzsk7PeDdv0L5Nd3wffyS7m4/gNvPkMwfDriShfCKIvzuHQQ= X-Received: by 2002:a19:4359:0:b0:511:4a8d:46d1 with SMTP id m25-20020a194359000000b005114a8d46d1mr1887352lfj.3.1707167552055; Mon, 05 Feb 2024 13:12:32 -0800 (PST) MIME-Version: 1.0 References: <0230331200824.195294-1-stephen@networkplumber.org> <20240205180328.131019-1-stephen@networkplumber.org> <20240205180328.131019-16-stephen@networkplumber.org> In-Reply-To: <20240205180328.131019-16-stephen@networkplumber.org> From: Ed Czeck Date: Mon, 5 Feb 2024 16:12:20 -0500 Message-ID: Subject: Re: [PATCH v9 15/23] net/ark: replace use of term sanity To: Stephen Hemminger Cc: dev@dpdk.org, Shepard Siegel , John Miller Content-Type: multipart/alternative; boundary="0000000000008341c40610a8eb6f" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --0000000000008341c40610a8eb6f Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, Feb 5, 2024 at 1:03=E2=80=AFPM Stephen Hemminger wrote: > > Do not use non inclusive terms. > > Signed-off-by: Stephen Hemminger > --- > drivers/net/ark/ark_ethdev.c | 8 ++++---- > drivers/net/ark/ark_ethdev_rx.c | 2 +- > 2 files changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/net/ark/ark_ethdev.c b/drivers/net/ark/ark_ethdev.c > index 0ffd4b9e9e4a..68edb542db43 100644 > --- a/drivers/net/ark/ark_ethdev.c > +++ b/drivers/net/ark/ark_ethdev.c > @@ -346,10 +346,10 @@ eth_ark_dev_init(struct rte_eth_dev *dev) > ARK_PMD_LOG(NOTICE, "Arkville HW Commit_ID: %08x\n", > rte_be_to_cpu_32(ark->sysctrl.t32[0x20 / 4])); > > - /* If HW sanity test fails, return an error */ > + /* If HW test fails, return an error */ > if (ark->sysctrl.t32[4] !=3D 0xcafef00d) { > ARK_PMD_LOG(ERR, > - "HW Sanity test has failed, expected constant= " > + "HW test has failed, expected constant" > " 0x%x, read 0x%x (%s)\n", > 0xcafef00d, > ark->sysctrl.t32[4], __func__); > @@ -357,7 +357,7 @@ eth_ark_dev_init(struct rte_eth_dev *dev) > } > > ARK_PMD_LOG(DEBUG, > - "HW Sanity test has PASSED, expected constant" > + "HW test has PASSED, expected constant" > " 0x%x, read 0x%x (%s)\n", > 0xcafef00d, ark->sysctrl.t32[4], __func__); > > @@ -587,7 +587,7 @@ eth_ark_dev_start(struct rte_eth_dev *dev) > rte_thread_t thread; > > /* Delay packet generator start allow the hardware to be ready > - * This is only used for sanity checking with internal generator > + * This is only used for checking with internal generator > */ > char tname[RTE_THREAD_INTERNAL_NAME_SIZE]; > snprintf(tname, sizeof(tname), "ark-pg%d", dev->data->port_id); > diff --git a/drivers/net/ark/ark_ethdev_rx.c b/drivers/net/ark/ark_ethdev_rx.c > index 24f1c65690eb..8ac9d904e795 100644 > --- a/drivers/net/ark/ark_ethdev_rx.c > +++ b/drivers/net/ark/ark_ethdev_rx.c > @@ -283,7 +283,7 @@ eth_ark_recv_pkts(void *rx_queue, > mbuf->pkt_len =3D meta->pkt_len; > mbuf->data_len =3D meta->pkt_len; > > - if (ARK_DEBUG_CORE) { /* debug sanity checks */ > + if (ARK_DEBUG_CORE) { /* debug checks */ > > if ((meta->pkt_len > (1024 * 16)) || > (meta->pkt_len =3D=3D 0)) { > -- > 2.43.0 > Acked-by: Ed Czeck --0000000000008341c40610a8eb6f Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


On Mon, Feb 5, 2024 at 1:03=E2=80=AFPM Stephen Hem= minger <stephen@networkplu= mber.org> wrote:
>
> Do not use non inclusive terms.
= >
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
>= =C2=A0drivers/net/ark/ark_ethdev.c =C2=A0 =C2=A0| 8 ++++----
> =C2= =A0drivers/net/ark/ark_ethdev_rx.c | 2 +-
> =C2=A02 files changed, 5 = insertions(+), 5 deletions(-)
>
> diff --git a/drivers/net/ark/= ark_ethdev.c b/drivers/net/ark/ark_ethdev.c
> index 0ffd4b9e9e4a..68e= db542db43 100644
> --- a/drivers/net/ark/ark_ethdev.c
> +++ b/d= rivers/net/ark/ark_ethdev.c
> @@ -346,10 +346,10 @@ eth_ark_dev_init(= struct rte_eth_dev *dev)
> =C2=A0 =C2=A0 =C2=A0 =C2=A0 ARK_PMD_LOG(NO= TICE, "Arkville HW Commit_ID: %08x\n",
> =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 rte_be_to_cpu_32(ark-&= gt;sysctrl.t32[0x20 / 4]));
>
> - =C2=A0 =C2=A0 =C2=A0 /* If HW= sanity test fails, return an error */
> + =C2=A0 =C2=A0 =C2=A0 /* If= HW test fails, return an error */
> =C2=A0 =C2=A0 =C2=A0 =C2=A0 if (= ark->sysctrl.t32[4] !=3D 0xcafef00d) {
> =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ARK_PMD_LOG(ERR,
> - =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 "HW Sanity test has failed, expected constant"
> + =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 "HW test has failed, expected constant"
> =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 " 0x%x, read 0x%x (%s)\n",
> =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 0xcafef00d,
> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ark->sysc= trl.t32[4], __func__);
> @@ -357,7 +357,7 @@ eth_ark_dev_init(struct = rte_eth_dev *dev)
> =C2=A0 =C2=A0 =C2=A0 =C2=A0 }
>
> =C2= =A0 =C2=A0 =C2=A0 =C2=A0 ARK_PMD_LOG(DEBUG,
> - =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 "HW Sanity test has PASSED, = expected constant"
> + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 "HW test has PASSED, expected constant"
= > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = " 0x%x, read 0x%x (%s)\n",
> =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 0xcafef00d, ark->sysctrl.t32[4= ], __func__);
>
> @@ -587,7 +587,7 @@ eth_ark_dev_start(struct = rte_eth_dev *dev)
> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 rte_thread_t thread;
>
> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 /* Delay packet generator start allow the hardware= to be ready
> - =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0* This is only used for sanity checking with internal generator
> = + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0* This is only use= d for checking with internal generator
> =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0*/
> =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 char tname[RTE_THREAD_INTERNAL_NAME_SIZE];
&= gt; =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 snprintf(tname,= sizeof(tname), "ark-pg%d", dev->data->port_id);
> di= ff --git a/drivers/net/ark/ark_ethdev_rx.c b/drivers/net/ark/ark_ethdev_rx.= c
> index 24f1c65690eb..8ac9d904e795 100644
> --- a/drivers/net= /ark/ark_ethdev_rx.c
> +++ b/drivers/net/ark/ark_ethdev_rx.c
> = @@ -283,7 +283,7 @@ eth_ark_recv_pkts(void *rx_queue,
> =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 mbuf->pkt_len =3D meta->pk= t_len;
> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 mbuf= ->data_len =3D meta->pkt_len;
>
> - =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 if (ARK_DEBUG_CORE) { =C2=A0 /* debug sanity ch= ecks */
> + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 if (ARK_= DEBUG_CORE) { =C2=A0 /* debug checks */
>
> =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 if ((met= a->pkt_len > (1024 * 16)) ||
> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (meta-&g= t;pkt_len =3D=3D 0)) {
> --
> 2.43.0
>
Ack= ed-by: Ed Czeck <ed.czeck@at= omicrules.com>


--0000000000008341c40610a8eb6f--