From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wj0-f194.google.com (mail-wj0-f194.google.com [209.85.210.194]) by dpdk.org (Postfix) with ESMTP id DD6A9FAFE for ; Tue, 20 Dec 2016 12:16:20 +0100 (CET) Received: by mail-wj0-f194.google.com with SMTP id he10so27232223wjc.2 for ; Tue, 20 Dec 2016 03:16:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=OslTPilskgprl3W9Kg27sVH58baB7C3ZLpYzGEkINsk=; b=D7v2blKXDD+YZQa0SvCXROcjjauOYl6QAnj4czl3lX5LApl/is2iFX9bPmUq5kYK+u cSjhJC5andXB1p3xaeEwTIr9EEHUlptAjfq8jC+kSSdecv0+coWVN52A7BBxLN9zjwoI kvBxcn6K6g5vAKObIaV36/pvU+S0PG/0X8TuWLeu3scv5J5XLCydACJ0ODcQNLZNu+gh YlhtI9AQuMMkrjl6cod0zPr6CS0TfpACm7InmoQg5HgjxXuxL7YH+WYQc1zr68b/xiG2 ZC7ScCxMAAk8r3ANx4ZIzuzjaH49dearCEYp36Whx+TYa6HNoB2OOfKjlNo/nnXOglAu kQHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=OslTPilskgprl3W9Kg27sVH58baB7C3ZLpYzGEkINsk=; b=Hd1/m3J8jVJRbCpZoF0KZghK3Z9Otzr4uxg69ADbdEYuqBiDyh1c4HOv8gNHOulzUh 22gS788IxllX830GNThlxzpYlg/D/KcoFhGrRazUJajoQD6UtJC4UJJfU5Cb29D7uO7O sNwGWftk6uSqORobL6s18hiPTA+Ee1ubJKZzLYD+vI6fUOpKaQicD6wOPRgmhPw2Ddeq MUwGQZelmW7JNu1XAGKS6xBNACmNXA+UYw5EzaxKDk6xs40Bxc9iMYTdjl4Mg1LmNxHb d/57uPNpSaZMBH71604JE4CTgWt88R18aTSrEMp6iyqD/7gIb8SOEq231ZKVfMsQyJc/ txng== X-Gm-Message-State: AIkVDXKKBuJjvbaxgunq3mLz02x3OaH8BqDQeHU5mokQWDxtOQXufrKQrX7/9cRA4Iv4SjeR+2fxSEcEGT9HTg== X-Received: by 10.194.95.194 with SMTP id dm2mr17300792wjb.207.1482232580593; Tue, 20 Dec 2016 03:16:20 -0800 (PST) MIME-Version: 1.0 Sender: jblunck@gmail.com Received: by 10.28.63.83 with HTTP; Tue, 20 Dec 2016 03:16:20 -0800 (PST) In-Reply-To: <20161219215944.17226-6-sthemmin@microsoft.com> References: <20161219215944.17226-1-sthemmin@microsoft.com> <20161219215944.17226-6-sthemmin@microsoft.com> From: Jan Blunck Date: Tue, 20 Dec 2016 12:16:20 +0100 X-Google-Sender-Auth: MrZweafve8GeATZndGJbmQspv5c Message-ID: To: Stephen Hemminger Cc: dev@dpdk.org, Stephen Hemminger Content-Type: text/plain; charset=UTF-8 Subject: Re: [dpdk-dev] [PATCH 05/13] pmd: remove useless reset of dev_info->dev_pci X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Dec 2016 11:16:21 -0000 On Mon, Dec 19, 2016 at 10:59 PM, Stephen Hemminger wrote: > Since rte_eth_dev_info_get does memset() on dev_info before > calling device specific code, the explicit assignment of NULL > in all these virtual drivers has no effect. > > Signed-off-by: Stephen Hemminger > --- > app/test/virtual_pmd.c | 1 - > drivers/net/af_packet/rte_eth_af_packet.c | 1 - > drivers/net/bonding/rte_eth_bond_pmd.c | 1 - > drivers/net/null/rte_eth_null.c | 1 - > drivers/net/pcap/rte_eth_pcap.c | 1 - > drivers/net/ring/rte_eth_ring.c | 1 - > drivers/net/xenvirt/rte_eth_xenvirt.c | 1 - > 7 files changed, 7 deletions(-) > > diff --git a/app/test/virtual_pmd.c b/app/test/virtual_pmd.c > index 65b44c64..e0447fda 100644 > --- a/app/test/virtual_pmd.c > +++ b/app/test/virtual_pmd.c > @@ -117,7 +117,6 @@ virtual_ethdev_info_get(struct rte_eth_dev *dev __rte_unused, > dev_info->max_tx_queues = (uint16_t)512; > > dev_info->min_rx_bufsize = 0; > - dev_info->pci_dev = NULL; > } > > static int > diff --git a/drivers/net/af_packet/rte_eth_af_packet.c b/drivers/net/af_packet/rte_eth_af_packet.c > index ff450685..2951f86c 100644 > --- a/drivers/net/af_packet/rte_eth_af_packet.c > +++ b/drivers/net/af_packet/rte_eth_af_packet.c > @@ -287,7 +287,6 @@ eth_dev_info(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info) > dev_info->max_rx_queues = (uint16_t)internals->nb_queues; > dev_info->max_tx_queues = (uint16_t)internals->nb_queues; > dev_info->min_rx_bufsize = 0; > - dev_info->pci_dev = NULL; > } > > static void > diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bonding/rte_eth_bond_pmd.c > index a80b6fa9..74af6589 100644 > --- a/drivers/net/bonding/rte_eth_bond_pmd.c > +++ b/drivers/net/bonding/rte_eth_bond_pmd.c > @@ -1675,7 +1675,6 @@ bond_ethdev_info(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info) > dev_info->max_tx_queues = (uint16_t)512; > > dev_info->min_rx_bufsize = 0; > - dev_info->pci_dev = NULL; > > dev_info->rx_offload_capa = internals->rx_offload_capa; > dev_info->tx_offload_capa = internals->tx_offload_capa; > diff --git a/drivers/net/null/rte_eth_null.c b/drivers/net/null/rte_eth_null.c > index 836d982a..b4f253ad 100644 > --- a/drivers/net/null/rte_eth_null.c > +++ b/drivers/net/null/rte_eth_null.c > @@ -301,7 +301,6 @@ eth_dev_info(struct rte_eth_dev *dev, > dev_info->max_rx_queues = RTE_DIM(internals->rx_null_queues); > dev_info->max_tx_queues = RTE_DIM(internals->tx_null_queues); > dev_info->min_rx_bufsize = 0; > - dev_info->pci_dev = NULL; > dev_info->reta_size = internals->reta_size; > dev_info->flow_type_rss_offloads = internals->flow_type_rss_offloads; > } > diff --git a/drivers/net/pcap/rte_eth_pcap.c b/drivers/net/pcap/rte_eth_pcap.c > index 0162f446..7253b9ad 100644 > --- a/drivers/net/pcap/rte_eth_pcap.c > +++ b/drivers/net/pcap/rte_eth_pcap.c > @@ -559,7 +559,6 @@ eth_dev_info(struct rte_eth_dev *dev, > dev_info->max_rx_queues = dev->data->nb_rx_queues; > dev_info->max_tx_queues = dev->data->nb_tx_queues; > dev_info->min_rx_bufsize = 0; > - dev_info->pci_dev = NULL; > } > > static void > diff --git a/drivers/net/ring/rte_eth_ring.c b/drivers/net/ring/rte_eth_ring.c > index c1767c48..dc99a1fe 100644 > --- a/drivers/net/ring/rte_eth_ring.c > +++ b/drivers/net/ring/rte_eth_ring.c > @@ -179,7 +179,6 @@ eth_dev_info(struct rte_eth_dev *dev, > dev_info->max_rx_queues = (uint16_t)internals->max_rx_queues; > dev_info->max_tx_queues = (uint16_t)internals->max_tx_queues; > dev_info->min_rx_bufsize = 0; > - dev_info->pci_dev = NULL; > } > > static void > diff --git a/drivers/net/xenvirt/rte_eth_xenvirt.c b/drivers/net/xenvirt/rte_eth_xenvirt.c > index c08a0568..609824b6 100644 > --- a/drivers/net/xenvirt/rte_eth_xenvirt.c > +++ b/drivers/net/xenvirt/rte_eth_xenvirt.c > @@ -337,7 +337,6 @@ eth_dev_info(struct rte_eth_dev *dev, > dev_info->max_rx_queues = (uint16_t)1; > dev_info->max_tx_queues = (uint16_t)1; > dev_info->min_rx_bufsize = 0; > - dev_info->pci_dev = NULL; > } > > static void > -- > 2.11.0 > Acked-by: Jan Blunck