From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f68.google.com (mail-wm0-f68.google.com [74.125.82.68]) by dpdk.org (Postfix) with ESMTP id 79DC4214A for ; Wed, 15 Mar 2017 09:38:52 +0100 (CET) Received: by mail-wm0-f68.google.com with SMTP id n11so3458640wma.0 for ; Wed, 15 Mar 2017 01:38:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=QJMAmb0KngYUr6O4lWksTRO2lwWZDmIxAuQP5UyV1Zk=; b=hJZ0aPxZmIMtK233FoV6OXOAI9PY27Z56jz/KXmtafsXhUdoyGex0cMzOUpb/oYPb9 gdTPIArUQwhiYV6taLuKGLu/pd/cNeSLCXwT1RsP9b4x3x2S5Wy4+vCgphPI5U2CcC5r StacaRXxjPI5ZULvyBe8BisI5edHGQRqZGPukS/RsrbsIqe9wYU9kuTV+V4gAEjZccyD Au/CnV0+ZHiMWRYFIiktPoPJO9iV+xJrvYkk0WyYKV1jVWMg7jCaxB5UVy6R2MlsF8fz bmY2ZH4Mf4STilLEDaByjaTkcuhTR9TrYU4k+Vuq38l/Xq54zjUVSIhMieQY/0x7J6Wx 15Yg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=QJMAmb0KngYUr6O4lWksTRO2lwWZDmIxAuQP5UyV1Zk=; b=A624R0Qn74kqkoy2pm2mBTBV8YEO801k538iEOeuOlYXo29VnUZ4tLVTKoB4zRO01q 03o41u/6w+owARNvs4UQlR3oUSlSTzaUTkQrO2mbmM1euczNA7UFkgWnFOY2CBqiOGpk Ux88e7CZcLLAWU2Z00Um0D08xaUgiPqVI3p6ROH5YkQnAOTInLbO6u3fRYsTDgofs5e9 QslYgsbTis7VRWFtPQybaad/7OpAK53nMksHePT7xFr0m2EF3VZA/i/JX2Of+4hayAot 9hnUf4N2eq9LnSmi9wih8GdPN6i5U6iUulbJTl8ZKDuT6PoB4o2VcVGSpITz/TjfWjtw J1Mw== X-Gm-Message-State: AFeK/H3p7sBe28rLEDxLmkSzicG46bJVo0qSM2FA31OhKH+AzloXS/dANvKfifEzGIPr52vgQ1RoTbZIYWj4rg== X-Received: by 10.28.129.212 with SMTP id c203mr3171021wmd.19.1489567132323; Wed, 15 Mar 2017 01:38:52 -0700 (PDT) MIME-Version: 1.0 Sender: jblunck@gmail.com Received: by 10.28.211.20 with HTTP; Wed, 15 Mar 2017 01:38:51 -0700 (PDT) In-Reply-To: <49759EB36A64CF4892C1AFEC9231E8D63A37768B@PGSMSX106.gar.corp.intel.com> References: <1489147132-40922-1-git-send-email-wei.dai@intel.com> <1489147132-40922-4-git-send-email-wei.dai@intel.com> <1517181.dliHzHtphb@xps13> <49759EB36A64CF4892C1AFEC9231E8D63A37768B@PGSMSX106.gar.corp.intel.com> From: Jan Blunck Date: Wed, 15 Mar 2017 09:38:51 +0100 X-Google-Sender-Auth: R8xKECTkAV_jU-1CTGDqtHmXuos Message-ID: To: "Dai, Wei" Cc: Thomas Monjalon , dev , "Mcnamara, John" , "david.marchand@intel.com" , "Tan, Raymond" Content-Type: text/plain; charset=UTF-8 Subject: Re: [dpdk-dev] [PATCH 3/3] eal: remove references to execinfo.h for musl X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Mar 2017 08:38:52 -0000 On Mon, Mar 13, 2017 at 9:10 AM, Dai, Wei wrote: >> -----Original Message----- >> From: jblunck@gmail.com [mailto:jblunck@gmail.com] On Behalf Of Jan Blunck >> Sent: Friday, March 10, 2017 10:50 PM >> To: Thomas Monjalon >> Cc: Dai, Wei ; dev ; Mcnamara, John >> ; david.marchand@intel.com >> Subject: Re: [dpdk-dev] [PATCH 3/3] eal: remove references to execinfo.h for >> musl >> >> On Fri, Mar 10, 2017 at 1:40 PM, Thomas Monjalon >> wrote: >> > 2017-03-10 19:58, Wei Dai: >> >> @@ -47,6 +50,7 @@ >> >> /* dump the stack of the calling core */ void rte_dump_stack(void) >> >> { >> >> +#ifndef RTE_LIBC_MUSL >> >> void *func[BACKTRACE_SIZE]; >> >> char **symb = NULL; >> >> int size; >> >> @@ -64,6 +68,7 @@ void rte_dump_stack(void) >> >> } >> >> >> >> free(symb); >> >> +#endif >> >> } >> > >> > There are probably other libc implementations not supporting this feature. >> > Instead of calling it "RTE_LIBC_MUSL", it should something like >> > "ENABLE_BACKTRACE". >> > Then you can add a musl section in the Linux quick start guide. >> >> Also I would improve the code readability by removing the preprocessor junk >> from it by moving the rte_dump_stack() function into eal_backtrace.c and make >> that conditionally compile based on CONFIG_ENABLE_BACKTRACE. > > I'd like to change CONFIG_RTE_LIBC_MUSL to CONFIG_RTE_EAL_ENABLE_BACKTRACE and > Will send a v2 patch soon. > Anyway, you also still can move rte_dump_stack() to another file when my change is accepted. > Thanks for working on it! Please also merge the introduction of the configuration and its usage into one patch.