From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <jblunck@gmail.com>
Received: from mail-wm0-f65.google.com (mail-wm0-f65.google.com [74.125.82.65])
 by dpdk.org (Postfix) with ESMTP id 3821B36E
 for <dev@dpdk.org>; Fri, 10 Mar 2017 15:49:54 +0100 (CET)
Received: by mail-wm0-f65.google.com with SMTP id v190so2664090wme.3
 for <dev@dpdk.org>; Fri, 10 Mar 2017 06:49:54 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=mime-version:sender:in-reply-to:references:from:date:message-id
 :subject:to:cc;
 bh=pMVySI1YQLwTV7OzzAI/7DGovpyK/kSGgLJI/MESt0w=;
 b=bHi0uH5UFcCRJAH6diQkCT3TZh3qpHKf2cenllBK2iy3hvFHBoY6FA0Jd12165pmpQ
 hppweMPPScJBtxvyR1unuBjZ8FzhK4cXjCxwxhdbSuuBIqb9UOZEqwSm1EB5Z1grfIc3
 lBiUs9xKTKvnYq2EjA9lMIuJac+LHunmC/noCbYpkVDgdwStPIvxl5fVFMQmuVe53xwg
 FrTt8RJtIz7o9GnLRGkmZBv1Hm7GxMf1hmW35m8U71UxQi3IEF7j+M76XNnEcgzvrzCh
 Y9MgdQV27Q+3fK+kprwU4dXsCy9flTBzgKEqECYdti5uHXGIYwMKB1d6QkeUnjNHiLHv
 ulIg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:sender:in-reply-to:references:from
 :date:message-id:subject:to:cc;
 bh=pMVySI1YQLwTV7OzzAI/7DGovpyK/kSGgLJI/MESt0w=;
 b=k0OhOdz6W2+3hHCBrE61keGFhQat+0T/OcgtsHTs6Fp/uBbJ1mpA7+U2QvGtuyC6Nh
 JZrGxKXOHGHvsZsm8jjBvNEL6ti3+wAjnUD4fhWLixcTRk6pywIa2G6TwM/uxmUcvbxX
 4ZwvgTfoJh/jaF2SCsmYUGulrkDc+pIJHSTcjO5BgKw5mDqTtpDd/k3NtUZ01bcPKj25
 Th8SZ7h/ASPwUkp8OmtfpaUp9x7TmvJLuOKxI8J2EcpUA+07QI8gTRM05KRY69CScjoH
 +VQWliTwZtG4DC5VOHwvSPmZItn64USNlsohbqGSzb6OwJrmBKB8NH9ayaAYHTjnCi7z
 swDQ==
X-Gm-Message-State: AFeK/H3lAkamnyyqJJnkQ3JeowjQacjjl7CSvzlUTR9BEe1rllx937l9j8QBOGV71RY0XwYqBIEmhvdoyLLEWg==
X-Received: by 10.28.71.87 with SMTP id u84mr2843840wma.101.1489157393977;
 Fri, 10 Mar 2017 06:49:53 -0800 (PST)
MIME-Version: 1.0
Sender: jblunck@gmail.com
Received: by 10.28.211.20 with HTTP; Fri, 10 Mar 2017 06:49:53 -0800 (PST)
In-Reply-To: <1517181.dliHzHtphb@xps13>
References: <1489147132-40922-1-git-send-email-wei.dai@intel.com>
 <1489147132-40922-4-git-send-email-wei.dai@intel.com>
 <1517181.dliHzHtphb@xps13>
From: Jan Blunck <jblunck@infradead.org>
Date: Fri, 10 Mar 2017 15:49:53 +0100
X-Google-Sender-Auth: 6brPg6kcmuJ75u7Oc_VNR6TIPCY
Message-ID: <CALe+Z00SkOQ6UL+bxg0ru0zORTAY9cxR=BaNdu-usj0+wdbQ4A@mail.gmail.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: Wei Dai <wei.dai@intel.com>, dev <dev@dpdk.org>, 
 "Mcnamara, John" <john.mcnamara@intel.com>, david.marchand@intel.com
Content-Type: text/plain; charset=UTF-8
Subject: Re: [dpdk-dev] [PATCH 3/3] eal: remove references to execinfo.h for
	musl
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 10 Mar 2017 14:49:54 -0000

On Fri, Mar 10, 2017 at 1:40 PM, Thomas Monjalon
<thomas.monjalon@6wind.com> wrote:
> 2017-03-10 19:58, Wei Dai:
>> @@ -47,6 +50,7 @@
>>  /* dump the stack of the calling core */
>>  void rte_dump_stack(void)
>>  {
>> +#ifndef RTE_LIBC_MUSL
>>       void *func[BACKTRACE_SIZE];
>>       char **symb = NULL;
>>       int size;
>> @@ -64,6 +68,7 @@ void rte_dump_stack(void)
>>       }
>>
>>       free(symb);
>> +#endif
>>  }
>
> There are probably other libc implementations not supporting this feature.
> Instead of calling it "RTE_LIBC_MUSL", it should something like
> "ENABLE_BACKTRACE".
> Then you can add a musl section in the Linux quick start guide.

Also I would improve the code readability by removing the preprocessor
junk from it by moving the rte_dump_stack() function into
eal_backtrace.c and make that conditionally compile based on
CONFIG_ENABLE_BACKTRACE.